| Message ID | 1559731921-14023-2-git-send-email-talel@amazon.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Amazon's Annapurna Labs Fabric Interrupt Controller | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Wed, Jun 05, 2019 at 01:52:00PM +0300, Talel Shenhar wrote: > Document Amazon's Annapurna Labs Fabric Interrupt Controller SoC binding. > > Signed-off-by: Talel Shenhar <talel@amazon.com> > --- > .../interrupt-controller/amazon,al-fic.txt | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt b/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt > new file mode 100644 > index 0000000..a2f31a6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt > @@ -0,0 +1,22 @@ > +Amazon's Annapurna Labs Fabric Interrupt Controller > + > +Required properties: > + > +- compatible: should be "amazon,al-fic" > +- reg: physical base address and size of the registers > +- interrupt-controller: identifies the node as an interrupt controller > +- #interrupt-cells: must be 2. > +- interrupt-parent: specifies the parent interrupt controller. > +- interrupts: describes which input line in the interrupt parent, this > + fic's output is connected to. > + > +Example: > + > +amazon_fic: amazon_fic { above must be: amazon_fic: interrupt-controller@0xfd8a8500 { -- Regards, Sudeep
On Wed, Jun 05, 2019 at 01:52:00PM +0300, Talel Shenhar wrote: > Document Amazon's Annapurna Labs Fabric Interrupt Controller SoC binding. > > Signed-off-by: Talel Shenhar <talel@amazon.com> > --- > .../interrupt-controller/amazon,al-fic.txt | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt b/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt > new file mode 100644 > index 0000000..a2f31a6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt > @@ -0,0 +1,22 @@ > +Amazon's Annapurna Labs Fabric Interrupt Controller > + > +Required properties: > + > +- compatible: should be "amazon,al-fic" > +- reg: physical base address and size of the registers > +- interrupt-controller: identifies the node as an interrupt controller > +- #interrupt-cells: must be 2. It would be great if you describe what the 2 numbers must represent here.. > +- interrupt-parent: specifies the parent interrupt controller. > +- interrupts: describes which input line in the interrupt parent, this > + fic's output is connected to. > + > +Example: > + > +amazon_fic: amazon_fic { > + compatible = "amazon,al-fic"; > + interrupt-controller; > + #interrupt-cells = <1>; > + reg = <0x0 0xfd8a8500 0x0 0x1000>; > + interrupt-parent = <&gic>; > + interrupts = <GIC_SPI 0x0 IRQ_TYPE_LEVEL_HIGH>; > +}; > -- > 2.7.4 >
On 6/5/2019 6:49 PM, Eduardo Valentin wrote: > On Wed, Jun 05, 2019 at 01:52:00PM +0300, Talel Shenhar wrote: >> +- compatible: should be "amazon,al-fic" >> +- reg: physical base address and size of the registers >> +- interrupt-controller: identifies the node as an interrupt controller >> +- #interrupt-cells: must be 2. > It would be great if you describe what the 2 numbers must represent here.. will be included in v4 Thanks, Talel.
diff --git a/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt b/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt new file mode 100644 index 0000000..a2f31a6 --- /dev/null +++ b/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt @@ -0,0 +1,22 @@ +Amazon's Annapurna Labs Fabric Interrupt Controller + +Required properties: + +- compatible: should be "amazon,al-fic" +- reg: physical base address and size of the registers +- interrupt-controller: identifies the node as an interrupt controller +- #interrupt-cells: must be 2. +- interrupt-parent: specifies the parent interrupt controller. +- interrupts: describes which input line in the interrupt parent, this + fic's output is connected to. + +Example: + +amazon_fic: amazon_fic { + compatible = "amazon,al-fic"; + interrupt-controller; + #interrupt-cells = <1>; + reg = <0x0 0xfd8a8500 0x0 0x1000>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 0x0 IRQ_TYPE_LEVEL_HIGH>; +};
Document Amazon's Annapurna Labs Fabric Interrupt Controller SoC binding. Signed-off-by: Talel Shenhar <talel@amazon.com> --- .../interrupt-controller/amazon,al-fic.txt | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt