| Message ID | 1548921464-28917-3-git-send-email-aisheng.dong@nxp.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | irq: imx-irqsteer: add 32 interrupts chan and multi outputs support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | "total: 0 errors, 1 warnings, 11 lines checked" |
Am Donnerstag, den 31.01.2019, 08:03 +0000 schrieb Aisheng Dong: > One irqsteer channel can support up to 8 output interrupts. > > > Cc: Marc Zyngier <marc.zyngier@arm.com> > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Lucas Stach <l.stach@pengutronix.de> > > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: devicetree@vger.kernel.org > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > --- > ChangeLog: > v2->v3: > * fix a typo > v1->v2: > * remove one unnecessary note. > --- > .../devicetree/bindings/interrupt-controller/fsl,irqsteer.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > index 6d0a41b..582991c 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > @@ -6,8 +6,9 @@ Required properties: > > - "fsl,imx8m-irqsteer" > > - "fsl,imx-irqsteer" > - reg: Physical base address and size of registers. > -- interrupts: Should contain the parent interrupt line used to multiplex the > - input interrupts. > +- interrupts: Should contain the up to 8 parent interrupt lines used to > + multiplex the input interrupts. They should be specified sequentially > + from output 0 to 7. > - clocks: Should contain one clock for entry in clock-names > see Documentation/devicetree/bindings/clock/clock-bindings.txt > - clock-names:
On 31/01/2019 08:03, Aisheng Dong wrote: > One irqsteer channel can support up to 8 output interrupts. > > Cc: Marc Zyngier <marc.zyngier@arm.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: devicetree@vger.kernel.org > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > --- > ChangeLog: > v2->v3: > * fix a typo > v1->v2: > * remove one unnecessary note. > --- > .../devicetree/bindings/interrupt-controller/fsl,irqsteer.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > index 6d0a41b..582991c 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > @@ -6,8 +6,9 @@ Required properties: > - "fsl,imx8m-irqsteer" > - "fsl,imx-irqsteer" > - reg: Physical base address and size of registers. > -- interrupts: Should contain the parent interrupt line used to multiplex the > - input interrupts. > +- interrupts: Should contain the up to 8 parent interrupt lines used to > + multiplex the input interrupts. They should be specified sequentially > + from output 0 to 7. > - clocks: Should contain one clock for entry in clock-names > see Documentation/devicetree/bindings/clock/clock-bindings.txt > - clock-names: > I'd like an Ack from a DT person, as this is a change to an existing binding. Thanks, M.
On Mon, Feb 11, 2019 at 03:34:23PM +0000, Marc Zyngier wrote: > On 31/01/2019 08:03, Aisheng Dong wrote: > > One irqsteer channel can support up to 8 output interrupts. > > > > Cc: Marc Zyngier <marc.zyngier@arm.com> > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Lucas Stach <l.stach@pengutronix.de> > > Cc: Shawn Guo <shawnguo@kernel.org> > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > > --- > > ChangeLog: > > v2->v3: > > * fix a typo > > v1->v2: > > * remove one unnecessary note. > > --- > > .../devicetree/bindings/interrupt-controller/fsl,irqsteer.txt | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > > index 6d0a41b..582991c 100644 > > --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > > @@ -6,8 +6,9 @@ Required properties: > > - "fsl,imx8m-irqsteer" > > - "fsl,imx-irqsteer" > > - reg: Physical base address and size of registers. > > -- interrupts: Should contain the parent interrupt line used to multiplex the > > - input interrupts. > > +- interrupts: Should contain the up to 8 parent interrupt lines used to > > + multiplex the input interrupts. They should be specified sequentially > > + from output 0 to 7. > > - clocks: Should contain one clock for entry in clock-names > > see Documentation/devicetree/bindings/clock/clock-bindings.txt > > - clock-names: > > > > I'd like an Ack from a DT person, as this is a change to an existing > binding. It's fine as long as old kernels ignore extra entries and new kernels still support a single entry. Otherwise, it needs a explanation. Rob
> From: Rob Herring [mailto:robh@kernel.org] > Sent: Thursday, February 14, 2019 6:30 AM > On Mon, Feb 11, 2019 at 03:34:23PM +0000, Marc Zyngier wrote: > > On 31/01/2019 08:03, Aisheng Dong wrote: > > > One irqsteer channel can support up to 8 output interrupts. > > > > > > Cc: Marc Zyngier <marc.zyngier@arm.com> > > > Cc: Rob Herring <robh+dt@kernel.org> > > > Cc: Lucas Stach <l.stach@pengutronix.de> > > > Cc: Shawn Guo <shawnguo@kernel.org> > > > Cc: devicetree@vger.kernel.org > > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > > > --- > > > ChangeLog: > > > v2->v3: > > > * fix a typo > > > v1->v2: > > > * remove one unnecessary note. > > > --- > > > .../devicetree/bindings/interrupt-controller/fsl,irqsteer.txt | 5 > +++-- > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqstee > > > r.txt > > > b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqstee > > > r.txt > > > index 6d0a41b..582991c 100644 > > > --- > > > a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqstee > > > r.txt > > > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irq > > > +++ steer.txt > > > @@ -6,8 +6,9 @@ Required properties: > > > - "fsl,imx8m-irqsteer" > > > - "fsl,imx-irqsteer" > > > - reg: Physical base address and size of registers. > > > -- interrupts: Should contain the parent interrupt line used to > > > multiplex the > > > - input interrupts. > > > +- interrupts: Should contain the up to 8 parent interrupt lines > > > +used to > > > + multiplex the input interrupts. They should be specified > > > +sequentially > > > + from output 0 to 7. > > > - clocks: Should contain one clock for entry in clock-names > > > see Documentation/devicetree/bindings/clock/clock-bindings.txt > > > - clock-names: > > > > > > > I'd like an Ack from a DT person, as this is a change to an existing > > binding. > > It's fine as long as old kernels ignore extra entries and new kernels still support > a single entry. Otherwise, it needs a explanation. Yes, it's like that. No compatibility break. Regards Dong Aisheng > > Rob
diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt index 6d0a41b..582991c 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt @@ -6,8 +6,9 @@ Required properties: - "fsl,imx8m-irqsteer" - "fsl,imx-irqsteer" - reg: Physical base address and size of registers. -- interrupts: Should contain the parent interrupt line used to multiplex the - input interrupts. +- interrupts: Should contain the up to 8 parent interrupt lines used to + multiplex the input interrupts. They should be specified sequentially + from output 0 to 7. - clocks: Should contain one clock for entry in clock-names see Documentation/devicetree/bindings/clock/clock-bindings.txt - clock-names:
One irqsteer channel can support up to 8 output interrupts. Cc: Marc Zyngier <marc.zyngier@arm.com> Cc: Rob Herring <robh+dt@kernel.org> Cc: Lucas Stach <l.stach@pengutronix.de> Cc: Shawn Guo <shawnguo@kernel.org> Cc: devicetree@vger.kernel.org Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> --- ChangeLog: v2->v3: * fix a typo v1->v2: * remove one unnecessary note. --- .../devicetree/bindings/interrupt-controller/fsl,irqsteer.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)