| Message ID | 1547797668-30342-3-git-send-email-aisheng.dong@nxp.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | irq: imx-irqsteer: add 32 interrupts chan and multi outputs support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | "total: 0 errors, 1 warnings, 11 lines checked" |
Am Freitag, den 18.01.2019, 07:53 +0000 schrieb Aisheng Dong: > One irqsteer channel can support up to 8 output interrupts. > > > Cc: Marc Zyngier <marc.zyngier@arm.com> > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Lucas Stach <l.stach@pengutronix.de> > > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: devicetree@vger.kernel.org > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > --- > .../devicetree/bindings/interrupt-controller/fsl,irqsteer.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > index eaabcda..beeed4a 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > @@ -6,8 +6,9 @@ Required properties: > > - "fsl,imx8m-irqsteer" > > - "fsl,imx-irqsteer" > - reg: Physical base address and size of registers. > -- interrupts: Should contain the parent interrupt line used to multiplex the > - input interrupts. > +- interrupts: Should contain the up to 8 parent interrupt lines used to > + multiplex the input interrupts. They should be sepcified seqencially > + from output 0 to 7. NOTE at least one output interrupt has to be specified. I don't think the note clarifies anything. Given that the thing is a irq multiplexer I don't think anyone expects that you could get away with no output irq. If anything this should specify that it's always groups of (up to) 64 input irqs being muxed onto a single output irq. Regards, Lucas
On Fri, Jan 25, 2019 at 6:47 PM Lucas Stach <l.stach@pengutronix.de> wrote: > > Am Freitag, den 18.01.2019, 07:53 +0000 schrieb Aisheng Dong: > > One irqsteer channel can support up to 8 output interrupts. > > > > > Cc: Marc Zyngier <marc.zyngier@arm.com> > > > Cc: Rob Herring <robh+dt@kernel.org> > > > Cc: Lucas Stach <l.stach@pengutronix.de> > > > Cc: Shawn Guo <shawnguo@kernel.org> > > Cc: devicetree@vger.kernel.org > > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > > --- > > .../devicetree/bindings/interrupt-controller/fsl,irqsteer.txt | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > > index eaabcda..beeed4a 100644 > > --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > > @@ -6,8 +6,9 @@ Required properties: > > > - "fsl,imx8m-irqsteer" > > > - "fsl,imx-irqsteer" > > - reg: Physical base address and size of registers. > > -- interrupts: Should contain the parent interrupt line used to multiplex the > > - input interrupts. > > +- interrupts: Should contain the up to 8 parent interrupt lines used to > > + multiplex the input interrupts. They should be sepcified seqencially > > + from output 0 to 7. NOTE at least one output interrupt has to be specified. > > I don't think the note clarifies anything. Given that the thing is a > irq multiplexer I don't think anyone expects that you could get away > with no output irq. > Sound reasonable to me. I will remove the note and keep other as it is. Regards Dong Aisheng
diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt index eaabcda..beeed4a 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt @@ -6,8 +6,9 @@ Required properties: - "fsl,imx8m-irqsteer" - "fsl,imx-irqsteer" - reg: Physical base address and size of registers. -- interrupts: Should contain the parent interrupt line used to multiplex the - input interrupts. +- interrupts: Should contain the up to 8 parent interrupt lines used to + multiplex the input interrupts. They should be sepcified seqencially + from output 0 to 7. NOTE at least one output interrupt has to be specified. - clocks: Should contain one clock for entry in clock-names see Documentation/devicetree/bindings/clock/clock-bindings.txt - clock-names:
One irqsteer channel can support up to 8 output interrupts. Cc: Marc Zyngier <marc.zyngier@arm.com> Cc: Rob Herring <robh+dt@kernel.org> Cc: Lucas Stach <l.stach@pengutronix.de> Cc: Shawn Guo <shawnguo@kernel.org> Cc: devicetree@vger.kernel.org Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> --- .../devicetree/bindings/interrupt-controller/fsl,irqsteer.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)