| Message ID | 1539886483-15775-5-git-send-email-aisheng.dong@nxp.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | None | expand |
On Thu, 18 Oct 2018 18:19:29 +0000, "A.s. Dong" wrote: > Add imx8qxp compatible string > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Wolfram Sang <wsa@the-dreams.de> > Cc: linux-i2c@vger.kernel.org > Cc: devicetree@vger.kernel.org > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > --- > Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.txt | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Rob Herring <robh@kernel.org>
Hi, On Thu, Oct 18, 2018 at 06:19:29PM +0000, A.s. Dong wrote: > Add imx8qxp compatible string > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Wolfram Sang <wsa@the-dreams.de> > Cc: linux-i2c@vger.kernel.org > Cc: devicetree@vger.kernel.org > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> Doesn't apply... > - "fsl,imx8dv-lpi2c" for LPI2C compatible with the one integrated on i.MX8DV soc ... I don't have this line in my tree. Would you maybe volunteer to maintain this driver? To prevent stuff like this from happening? :) Regards, Wolfram
Hi Wolfram, [...] > Hi, > > On Thu, Oct 18, 2018 at 06:19:29PM +0000, A.s. Dong wrote: > > Add imx8qxp compatible string > > > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Mark Rutland <mark.rutland@arm.com> > > Cc: Wolfram Sang <wsa@the-dreams.de> > > Cc: linux-i2c@vger.kernel.org > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > > Doesn't apply... > > > - "fsl,imx8dv-lpi2c" for LPI2C compatible with the one integrated > > on i.MX8DV soc > > ... I don't have this line in my tree. > It seems to be caused by the following commit during the 4.19 RC2+. f6eb89349078 dt-bindings: imx-lpi2c: Remove mx8dv compatible entry > Would you maybe volunteer to maintain this driver? To prevent stuff like this > from happening? :) Sure, I will open an eye on this driver patches from now on. And I will resend the patch against your tree. Thanks Regards Dong Aisheng > > Regards, > > Wolfram
> > Would you maybe volunteer to maintain this driver? To prevent stuff like this > > from happening? :) > > Sure, I will open an eye on this driver patches from now on. Great, thank you! Can you add an entry to MAINTAINERS and send this as a patch, too? > And I will resend the patch against your tree. Thanks!
[...] > > > Would you maybe volunteer to maintain this driver? To prevent stuff > > > like this from happening? :) > > > > Sure, I will open an eye on this driver patches from now on. > > Great, thank you! Can you add an entry to MAINTAINERS and send this as a > patch, too? > Got it. Thanks Regards Dong Aisheng > > And I will resend the patch against your tree. > > Thanks!
diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.txt b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.txt index 00e4365..abbc905 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.txt +++ b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.txt @@ -4,6 +4,7 @@ Required properties: - compatible : - "fsl,imx7ulp-lpi2c" for LPI2C compatible with the one integrated on i.MX7ULP soc - "fsl,imx8dv-lpi2c" for LPI2C compatible with the one integrated on i.MX8DV soc + - "fsl,imx8qxp-lpi2c" for LPI2C compatible with the one integrated on i.MX8QXP soc - reg : address and length of the lpi2c master registers - interrupts : lpi2c interrupt - clocks : lpi2c clock specifier
Add imx8qxp compatible string Cc: Rob Herring <robh+dt@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Wolfram Sang <wsa@the-dreams.de> Cc: linux-i2c@vger.kernel.org Cc: devicetree@vger.kernel.org Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> --- Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.txt | 1 + 1 file changed, 1 insertion(+)