| Message ID | 1539696935-4433-3-git-send-email-gilad@benyossef.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | crypto: ccree: add CryptoCell 713 baseline support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Tue, Oct 16, 2018 at 02:35:32PM +0100, Gilad Ben-Yossef wrote: > Add device tree bindings associating Arm TrustZone CryptoCell 713 with the > ccree driver. "dt-bindings: crypto: ..." for the subject. > > Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> > --- > Documentation/devicetree/bindings/crypto/arm-cryptocell.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/crypto/arm-cryptocell.txt b/Documentation/devicetree/bindings/crypto/arm-cryptocell.txt > index 999fb2a..880de07 100644 > --- a/Documentation/devicetree/bindings/crypto/arm-cryptocell.txt > +++ b/Documentation/devicetree/bindings/crypto/arm-cryptocell.txt > @@ -1,8 +1,9 @@ > Arm TrustZone CryptoCell cryptographic engine > > Required properties: > -- compatible: Should be one of: "arm,cryptocell-712-ree", > - "arm,cryptocell-710-ree" or "arm,cryptocell-630p-ree". > +- compatible: Should be one of: "arm,cryptocell-713-ree", > + "arm,cryptocell-712-ree", "arm,cryptocell-710-ree" or > + "arm,cryptocell-630p-ree". Please format 1 per line. > - reg: Base physical address of the engine and length of memory mapped region. > - interrupts: Interrupt number for the device. > > -- > 2.7.4 >
On Thu, Oct 25, 2018 at 3:12 AM Rob Herring <robh@kernel.org> wrote: > > On Tue, Oct 16, 2018 at 02:35:32PM +0100, Gilad Ben-Yossef wrote: > > Add device tree bindings associating Arm TrustZone CryptoCell 713 with the > > ccree driver. > > "dt-bindings: crypto: ..." for the subject. > > > > Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> > > --- > > Documentation/devicetree/bindings/crypto/arm-cryptocell.txt | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/crypto/arm-cryptocell.txt b/Documentation/devicetree/bindings/crypto/arm-cryptocell.txt > > index 999fb2a..880de07 100644 > > --- a/Documentation/devicetree/bindings/crypto/arm-cryptocell.txt > > +++ b/Documentation/devicetree/bindings/crypto/arm-cryptocell.txt > > @@ -1,8 +1,9 @@ > > Arm TrustZone CryptoCell cryptographic engine > > > > Required properties: > > -- compatible: Should be one of: "arm,cryptocell-712-ree", > > - "arm,cryptocell-710-ree" or "arm,cryptocell-630p-ree". > > +- compatible: Should be one of: "arm,cryptocell-713-ree", > > + "arm,cryptocell-712-ree", "arm,cryptocell-710-ree" or > > + "arm,cryptocell-630p-ree". > > Please format 1 per line. > Will do. Thanks for the review. I will send a corrected patch. Gilad
diff --git a/Documentation/devicetree/bindings/crypto/arm-cryptocell.txt b/Documentation/devicetree/bindings/crypto/arm-cryptocell.txt index 999fb2a..880de07 100644 --- a/Documentation/devicetree/bindings/crypto/arm-cryptocell.txt +++ b/Documentation/devicetree/bindings/crypto/arm-cryptocell.txt @@ -1,8 +1,9 @@ Arm TrustZone CryptoCell cryptographic engine Required properties: -- compatible: Should be one of: "arm,cryptocell-712-ree", - "arm,cryptocell-710-ree" or "arm,cryptocell-630p-ree". +- compatible: Should be one of: "arm,cryptocell-713-ree", + "arm,cryptocell-712-ree", "arm,cryptocell-710-ree" or + "arm,cryptocell-630p-ree". - reg: Base physical address of the engine and length of memory mapped region. - interrupts: Interrupt number for the device.
Add device tree bindings associating Arm TrustZone CryptoCell 713 with the ccree driver. Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> --- Documentation/devicetree/bindings/crypto/arm-cryptocell.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)