| Message ID | 1538062603-7490-2-git-send-email-srinath.mannam@broadcom.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Stingray thermal driver support | expand |
On Thu, Sep 27, 2018 at 09:06:41PM +0530, Srinath Mannam wrote: > From: Pramod Kumar <pramod.kumar@broadcom.com> > > Add binding document for supported thermal implementation > in Stingray. > > Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com> > Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com> > Reviewed-by: Ray Jui <ray.jui@broadcom.com> > Reviewed-by: Scott Branden <scott.branden@broadcom.com> > --- > .../bindings/thermal/brcm,sr-thermal.txt | 25 ++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt > > diff --git a/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt > new file mode 100644 > index 0000000..717617b > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt > @@ -0,0 +1,25 @@ > +* Broadcom Stingray Thermal > + > +This binding describes thermal sensors that is part of Stingray SoCs. > + > +Required properties: > +- compatible : Must be "brcm,sr-thermal" > +- reg : memory where tmon data will be available. > +- brcm,tmon-mask: A one cell bit mask of valid TMON sources. > + Each bit represents single TMON source. > +- brcm,max-crit-temp: Maximum supported critical temperature. We already have a defined binding for setting trip points. > + > +Example: > + tmons { > + compatible = "simple-bus"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0x0 0x8f100000 0x100>; > + > + tmon: thermal@0 { > + compatible = "brcm,sr-thermal"; > + reg = <0 0x40>; > + brcm,tmon-mask = <0x3f>; > + brcm,max-crit-temp = <105000>; > + }; > + }; > -- > 2.7.4 >
On 09/27/2018 10:27 AM, Rob Herring wrote: > On Thu, Sep 27, 2018 at 09:06:41PM +0530, Srinath Mannam wrote: >> From: Pramod Kumar <pramod.kumar@broadcom.com> >> >> Add binding document for supported thermal implementation >> in Stingray. >> >> Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com> >> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com> >> Reviewed-by: Ray Jui <ray.jui@broadcom.com> >> Reviewed-by: Scott Branden <scott.branden@broadcom.com> >> --- >> .../bindings/thermal/brcm,sr-thermal.txt | 25 ++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt >> >> diff --git a/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt >> new file mode 100644 >> index 0000000..717617b >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt >> @@ -0,0 +1,25 @@ >> +* Broadcom Stingray Thermal >> + >> +This binding describes thermal sensors that is part of Stingray SoCs. >> + >> +Required properties: >> +- compatible : Must be "brcm,sr-thermal" >> +- reg : memory where tmon data will be available. >> +- brcm,tmon-mask: A one cell bit mask of valid TMON sources. >> + Each bit represents single TMON source. >> +- brcm,max-crit-temp: Maximum supported critical temperature. > > We already have a defined binding for setting trip points. Indeed, and if you have multiple TMONs, they would in premise possibly each have a different critical trip point. > >> + >> +Example: >> + tmons { >> + compatible = "simple-bus"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges = <0x0 0x0 0x8f100000 0x100>; >> + >> + tmon: thermal@0 { >> + compatible = "brcm,sr-thermal"; >> + reg = <0 0x40>; >> + brcm,tmon-mask = <0x3f>; >> + brcm,max-crit-temp = <105000>; >> + }; >> + }; >> -- >> 2.7.4 >>
On 18-09-27 10:31 AM, Florian Fainelli wrote: > On 09/27/2018 10:27 AM, Rob Herring wrote: >> On Thu, Sep 27, 2018 at 09:06:41PM +0530, Srinath Mannam wrote: >>> From: Pramod Kumar <pramod.kumar@broadcom.com> >>> >>> Add binding document for supported thermal implementation >>> in Stingray. >>> >>> Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com> >>> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com> >>> Reviewed-by: Ray Jui <ray.jui@broadcom.com> >>> Reviewed-by: Scott Branden <scott.branden@broadcom.com> >>> --- >>> .../bindings/thermal/brcm,sr-thermal.txt | 25 ++++++++++++++++++++++ >>> 1 file changed, 25 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt >>> >>> diff --git a/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt >>> new file mode 100644 >>> index 0000000..717617b >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt >>> @@ -0,0 +1,25 @@ >>> +* Broadcom Stingray Thermal >>> + >>> +This binding describes thermal sensors that is part of Stingray SoCs. >>> + >>> +Required properties: >>> +- compatible : Must be "brcm,sr-thermal" >>> +- reg : memory where tmon data will be available. >>> +- brcm,tmon-mask: A one cell bit mask of valid TMON sources. >>> + Each bit represents single TMON source. >>> +- brcm,max-crit-temp: Maximum supported critical temperature. >> We already have a defined binding for setting trip points. > Indeed, and if you have multiple TMONs, they would in premise possibly > each have a different critical trip point. Which may be a good reason to go back to our original bindings which were generic and had each sensor in its own node? >>> + >>> +Example: >>> + tmons { >>> + compatible = "simple-bus"; >>> + #address-cells = <1>; >>> + #size-cells = <1>; >>> + ranges = <0x0 0x0 0x8f100000 0x100>; >>> + >>> + tmon: thermal@0 { >>> + compatible = "brcm,sr-thermal"; >>> + reg = <0 0x40>; >>> + brcm,tmon-mask = <0x3f>; >>> + brcm,max-crit-temp = <105000>; >>> + }; >>> + }; >>> -- >>> 2.7.4 >>> >
On Thu, Sep 27, 2018 at 11:00:33AM -0700, Scott Branden wrote: > > > On 18-09-27 10:31 AM, Florian Fainelli wrote: > > On 09/27/2018 10:27 AM, Rob Herring wrote: > > > On Thu, Sep 27, 2018 at 09:06:41PM +0530, Srinath Mannam wrote: > > > > From: Pramod Kumar <pramod.kumar@broadcom.com> > > > > > > > > Add binding document for supported thermal implementation > > > > in Stingray. > > > > > > > > Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com> > > > > Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com> > > > > Reviewed-by: Ray Jui <ray.jui@broadcom.com> > > > > Reviewed-by: Scott Branden <scott.branden@broadcom.com> > > > > --- > > > > .../bindings/thermal/brcm,sr-thermal.txt | 25 ++++++++++++++++++++++ > > > > 1 file changed, 25 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt > > > > > > > > diff --git a/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt > > > > new file mode 100644 > > > > index 0000000..717617b > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt > > > > @@ -0,0 +1,25 @@ > > > > +* Broadcom Stingray Thermal > > > > + > > > > +This binding describes thermal sensors that is part of Stingray SoCs. > > > > + > > > > +Required properties: > > > > +- compatible : Must be "brcm,sr-thermal" > > > > +- reg : memory where tmon data will be available. > > > > +- brcm,tmon-mask: A one cell bit mask of valid TMON sources. > > > > + Each bit represents single TMON source. > > > > +- brcm,max-crit-temp: Maximum supported critical temperature. > > > We already have a defined binding for setting trip points. > > Indeed, and if you have multiple TMONs, they would in premise possibly > > each have a different critical trip point. > Which may be a good reason to go back to our original bindings which were > generic and had each sensor in its own node? Perhaps. I wouldn't call it going back to your original, but rather defining a complete binding. Of course, if you don't need different trip points, then again that is just unnecessary bloat. But I can't argue whether you do or don't. Rob
On 18-09-27 11:59 AM, Rob Herring wrote: > On Thu, Sep 27, 2018 at 11:00:33AM -0700, Scott Branden wrote: >> >> On 18-09-27 10:31 AM, Florian Fainelli wrote: >>> On 09/27/2018 10:27 AM, Rob Herring wrote: >>>> On Thu, Sep 27, 2018 at 09:06:41PM +0530, Srinath Mannam wrote: >>>>> From: Pramod Kumar <pramod.kumar@broadcom.com> >>>>> >>>>> Add binding document for supported thermal implementation >>>>> in Stingray. >>>>> >>>>> Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com> >>>>> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com> >>>>> Reviewed-by: Ray Jui <ray.jui@broadcom.com> >>>>> Reviewed-by: Scott Branden <scott.branden@broadcom.com> >>>>> --- >>>>> .../bindings/thermal/brcm,sr-thermal.txt | 25 ++++++++++++++++++++++ >>>>> 1 file changed, 25 insertions(+) >>>>> create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt >>>>> new file mode 100644 >>>>> index 0000000..717617b >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt >>>>> @@ -0,0 +1,25 @@ >>>>> +* Broadcom Stingray Thermal >>>>> + >>>>> +This binding describes thermal sensors that is part of Stingray SoCs. >>>>> + >>>>> +Required properties: >>>>> +- compatible : Must be "brcm,sr-thermal" >>>>> +- reg : memory where tmon data will be available. >>>>> +- brcm,tmon-mask: A one cell bit mask of valid TMON sources. >>>>> + Each bit represents single TMON source. >>>>> +- brcm,max-crit-temp: Maximum supported critical temperature. >>>> We already have a defined binding for setting trip points. >>> Indeed, and if you have multiple TMONs, they would in premise possibly >>> each have a different critical trip point. >> Which may be a good reason to go back to our original bindings which were >> generic and had each sensor in its own node? > Perhaps. I wouldn't call it going back to your original, but rather > defining a complete binding. Of course, if you don't need different trip > points, then again that is just unnecessary bloat. But I can't argue > whether you do or don't. We currently do not need different trip points as detailed analysis of each sensor's trip point has not been needed. If we do add different trip points per sensor the node per sensor approach looks very flexible. Call it what you like: Srinath's original driver. > > Rob
diff --git a/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt new file mode 100644 index 0000000..717617b --- /dev/null +++ b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt @@ -0,0 +1,25 @@ +* Broadcom Stingray Thermal + +This binding describes thermal sensors that is part of Stingray SoCs. + +Required properties: +- compatible : Must be "brcm,sr-thermal" +- reg : memory where tmon data will be available. +- brcm,tmon-mask: A one cell bit mask of valid TMON sources. + Each bit represents single TMON source. +- brcm,max-crit-temp: Maximum supported critical temperature. + +Example: + tmons { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x0 0x8f100000 0x100>; + + tmon: thermal@0 { + compatible = "brcm,sr-thermal"; + reg = <0 0x40>; + brcm,tmon-mask = <0x3f>; + brcm,max-crit-temp = <105000>; + }; + };