| Message ID | 1524054002-17869-3-git-send-email-spanda@codeaurora.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [[RFC] DPU PATCH 2/4] dt-bindings: drm/bridge: Document sn65dsi86 bridge bindings | expand |
On Wed, Apr 18, 2018 at 05:50:00PM +0530, Sandeep Panda wrote: > Document the bindings used for the sn65dsi86 DSI to eDP bridge. > Please add a changelog to your patches so reviewers know what has changed between patch versions. > Signed-off-by: Sandeep Panda <spanda@codeaurora.org> > --- > .../bindings/display/bridge/ti,sn65dsi86.txt | 60 ++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt > new file mode 100644 > index 0000000..9e2612e > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt > @@ -0,0 +1,60 @@ > +SN65DSI86 DSI to eDP bridge chip > +-------------------------------- > + > +This is the binding for Texas Instruments SN65DSI86 bridge. > + > +Required properties: > +- compatible: Must be "ti,sn65dsi86" > +- reg: i2c address of the chip, 0x2d as per datasheet > +- enable-gpios: OF device-tree gpio specifications for bridge_en pin The datasheet only has one enable pin, why gpios? > + > +- vccio-supply: A 1.8V supply that powers up the digital IOs. > +- vcca-supply: A 1.2V supply that powers up the analog circuits. > + > +Optional properties: > + > +- irq-gpios: OF device-tree gpio specification for interrupt pin >From the last review, Rob said, 'Use "interrupts" property instead.' You didn't provide responses to prior review comments, so it's unclear whether you've intentionally or unintentionally ignored him :) Sean > + > +Required nodes: > + > +This device has two video ports. Their connections are modelled using the > +OF graph bindings specified in Documentation/devicetree/bindings/graph.txt. > + > +- Video port 0 for DSI input > +- Video port 1 for eDP output > + > +Example > +------- > + > +edp-bridge@2d { > + compatible = "ti,sn65dsi86"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x2d>; > + > + enable-gpios = <&msmgpio 33 GPIO_ACTIVE_HIGH>; > + > + vccio-supply = <&pm8916_l17>; > + vcca-supply = <&pm8916_l6>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + edp_bridge_in: endpoint { > + remote-endpoint = <&dsi_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + edp_bridge_out: endpoint { > + remote-endpoint = <&edp_panel_in>; > + }; > + }; > + }; > +} > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
On 2018-04-18 19:28, Sean Paul wrote: > On Wed, Apr 18, 2018 at 05:50:00PM +0530, Sandeep Panda wrote: >> Document the bindings used for the sn65dsi86 DSI to eDP bridge. >> > > Please add a changelog to your patches so reviewers know what has > changed > between patch versions. I will update the change log in the commit text of the patches. > >> Signed-off-by: Sandeep Panda <spanda@codeaurora.org> >> --- >> .../bindings/display/bridge/ti,sn65dsi86.txt | 60 >> ++++++++++++++++++++++ >> 1 file changed, 60 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt >> >> diff --git >> a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt >> b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt >> new file mode 100644 >> index 0000000..9e2612e >> --- /dev/null >> +++ >> b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt >> @@ -0,0 +1,60 @@ >> +SN65DSI86 DSI to eDP bridge chip >> +-------------------------------- >> + >> +This is the binding for Texas Instruments SN65DSI86 bridge. >> + >> +Required properties: >> +- compatible: Must be "ti,sn65dsi86" >> +- reg: i2c address of the chip, 0x2d as per datasheet >> +- enable-gpios: OF device-tree gpio specifications for bridge_en pin > > The datasheet only has one enable pin, why gpios? This is the convention followed by other bridge drivers also. https://www.kernel.org/doc/Documentation/devicetree/bindings/gpio/gpio.txt please the example mentioned here, Example of a node using GPIOs: node { enable-gpios = <&qe_pio_e 18 GPIO_ACTIVE_HIGH>; }; > >> + >> +- vccio-supply: A 1.8V supply that powers up the digital IOs. >> +- vcca-supply: A 1.2V supply that powers up the analog circuits. >> + >> +Optional properties: >> + >> +- irq-gpios: OF device-tree gpio specification for interrupt pin > > From the last review, Rob said, 'Use "interrupts" property instead.' > > You didn't provide responses to prior review comments, so it's unclear > whether > you've intentionally or unintentionally ignored him :) Sorry missed it completely while addressing other review comments. > > Sean > >> + >> +Required nodes: >> + >> +This device has two video ports. Their connections are modelled using >> the >> +OF graph bindings specified in >> Documentation/devicetree/bindings/graph.txt. >> + >> +- Video port 0 for DSI input >> +- Video port 1 for eDP output >> + >> +Example >> +------- >> + >> +edp-bridge@2d { >> + compatible = "ti,sn65dsi86"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <0x2d>; >> + >> + enable-gpios = <&msmgpio 33 GPIO_ACTIVE_HIGH>; >> + >> + vccio-supply = <&pm8916_l17>; >> + vcca-supply = <&pm8916_l6>; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + >> + edp_bridge_in: endpoint { >> + remote-endpoint = <&dsi_out>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + >> + edp_bridge_out: endpoint { >> + remote-endpoint = <&edp_panel_in>; >> + }; >> + }; >> + }; >> +} >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora >> Forum, >> a Linux Foundation Collaborative Project >> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt new file mode 100644 index 0000000..9e2612e --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt @@ -0,0 +1,60 @@ +SN65DSI86 DSI to eDP bridge chip +-------------------------------- + +This is the binding for Texas Instruments SN65DSI86 bridge. + +Required properties: +- compatible: Must be "ti,sn65dsi86" +- reg: i2c address of the chip, 0x2d as per datasheet +- enable-gpios: OF device-tree gpio specifications for bridge_en pin + +- vccio-supply: A 1.8V supply that powers up the digital IOs. +- vcca-supply: A 1.2V supply that powers up the analog circuits. + +Optional properties: + +- irq-gpios: OF device-tree gpio specification for interrupt pin + +Required nodes: + +This device has two video ports. Their connections are modelled using the +OF graph bindings specified in Documentation/devicetree/bindings/graph.txt. + +- Video port 0 for DSI input +- Video port 1 for eDP output + +Example +------- + +edp-bridge@2d { + compatible = "ti,sn65dsi86"; + #address-cells = <1>; + #size-cells = <0>; + reg = <0x2d>; + + enable-gpios = <&msmgpio 33 GPIO_ACTIVE_HIGH>; + + vccio-supply = <&pm8916_l17>; + vcca-supply = <&pm8916_l6>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + edp_bridge_in: endpoint { + remote-endpoint = <&dsi_out>; + }; + }; + + port@1 { + reg = <1>; + + edp_bridge_out: endpoint { + remote-endpoint = <&edp_panel_in>; + }; + }; + }; +}
Document the bindings used for the sn65dsi86 DSI to eDP bridge. Signed-off-by: Sandeep Panda <spanda@codeaurora.org> --- .../bindings/display/bridge/ti,sn65dsi86.txt | 60 ++++++++++++++++++++++ 1 file changed, 60 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt