| Message ID | 1523439386-1032-5-git-send-email-yoshihiro.shimoda.uh@renesas.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | soc: renesas: Add support for R-Car E3 | expand |
Hi Shimoda-san, Thanks for your patch! On Wed, Apr 11, 2018 at 11:36 AM, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > This patch adds definition of reset vector for the R8A77990 SoC. The description doesn't seem to match what the patch does? > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > [shimoda: rebase] > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> The actual patch contents are fine, so: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
On Wed, Apr 11, 2018 at 05:18:28PM +0200, Geert Uytterhoeven wrote: > Hi Shimoda-san, > > Thanks for your patch! > > On Wed, Apr 11, 2018 at 11:36 AM, Yoshihiro Shimoda > <yoshihiro.shimoda.uh@renesas.com> wrote: > > From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > > > This patch adds definition of reset vector for the R8A77990 SoC. > > The description doesn't seem to match what the patch does? How about this text, based on Sergei's test for the R8a77980? Add support for R-Car E3 (R8A77990) to the R-Car RST driver. This driver is needed for the clock driver to work. > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > [shimoda: rebase] > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > The actual patch contents are fine, so: > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Simon-san, > From: Simon Horman, Sent: Thursday, April 12, 2018 4:55 PM > > On Wed, Apr 11, 2018 at 05:18:28PM +0200, Geert Uytterhoeven wrote: > > Hi Shimoda-san, > > > > Thanks for your patch! > > > > On Wed, Apr 11, 2018 at 11:36 AM, Yoshihiro Shimoda > > <yoshihiro.shimoda.uh@renesas.com> wrote: > > > From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > > > > > This patch adds definition of reset vector for the R8A77990 SoC. > > > > The description doesn't seem to match what the patch does? > > How about this text, based on Sergei's test for the R8a77980? > > Add support for R-Car E3 (R8A77990) to the R-Car RST driver. > This driver is needed for the clock driver to work. It's good to me. So, should I submit v2 patch? Best regards, Yoshihiro Shimoda > > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > > [shimoda: rebase] > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > > The actual patch contents are fine, so: > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > Gr{oetje,eeting}s, > > > > Geert > > > > -- > > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > > > In personal conversations with technical people, I call myself a hacker. But > > when I'm talking to journalists I just say "programmer" or something like that. > > -- Linus Torvalds > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Apr 12, 2018 at 08:11:22AM +0000, Yoshihiro Shimoda wrote: > Hi Simon-san, > > > From: Simon Horman, Sent: Thursday, April 12, 2018 4:55 PM > > > > On Wed, Apr 11, 2018 at 05:18:28PM +0200, Geert Uytterhoeven wrote: > > > Hi Shimoda-san, > > > > > > Thanks for your patch! > > > > > > On Wed, Apr 11, 2018 at 11:36 AM, Yoshihiro Shimoda > > > <yoshihiro.shimoda.uh@renesas.com> wrote: > > > > From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > > > > > > > This patch adds definition of reset vector for the R8A77990 SoC. > > > > > > The description doesn't seem to match what the patch does? > > > > How about this text, based on Sergei's test for the R8a77980? > > > > Add support for R-Car E3 (R8A77990) to the R-Car RST driver. > > This driver is needed for the clock driver to work. > > It's good to me. So, should I submit v2 patch? No need, I have applied the patch with the changelog text above. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/reset/renesas,rst.txt b/Documentation/devicetree/bindings/reset/renesas,rst.txt index 7be61ef..67e83b0 100644 --- a/Documentation/devicetree/bindings/reset/renesas,rst.txt +++ b/Documentation/devicetree/bindings/reset/renesas,rst.txt @@ -30,6 +30,7 @@ Required properties: - "renesas,r8a77965-rst" (R-Car M3-N) - "renesas,r8a77970-rst" (R-Car V3M) - "renesas,r8a77980-rst" (R-Car V3H) + - "renesas,r8a77990-rst" (R-Car E3) - "renesas,r8a77995-rst" (R-Car D3) - reg: Address start and address range for the device. diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig index 36bec60..1d824cb 100644 --- a/drivers/soc/renesas/Kconfig +++ b/drivers/soc/renesas/Kconfig @@ -4,7 +4,8 @@ config SOC_RENESAS select SOC_BUS select RST_RCAR if ARCH_RCAR_GEN1 || ARCH_RCAR_GEN2 || \ ARCH_R8A7795 || ARCH_R8A7796 || ARCH_R8A77965 || \ - ARCH_R8A77970 || ARCH_R8A77980 || ARCH_R8A77995 + ARCH_R8A77970 || ARCH_R8A77980 || ARCH_R8A77990 || \ + ARCH_R8A77995 select SYSC_R8A7743 if ARCH_R8A7743 select SYSC_R8A7745 if ARCH_R8A7745 select SYSC_R8A77470 if ARCH_R8A77470 diff --git a/drivers/soc/renesas/rcar-rst.c b/drivers/soc/renesas/rcar-rst.c index 66d7dba..d9c1034 100644 --- a/drivers/soc/renesas/rcar-rst.c +++ b/drivers/soc/renesas/rcar-rst.c @@ -60,6 +60,7 @@ struct rst_config { { .compatible = "renesas,r8a77965-rst", .data = &rcar_rst_gen3 }, { .compatible = "renesas,r8a77970-rst", .data = &rcar_rst_gen3 }, { .compatible = "renesas,r8a77980-rst", .data = &rcar_rst_gen3 }, + { .compatible = "renesas,r8a77990-rst", .data = &rcar_rst_gen3 }, { .compatible = "renesas,r8a77995-rst", .data = &rcar_rst_gen3 }, { /* sentinel */ } };