| Message ID | 1523357590-3841-2-git-send-email-jacopo+renesas@jmondi.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | drm: Add Thine THC63LVD1024 LVDS decoder bridge | expand |
On Tue, Apr 10, 2018 at 12:53:09PM +0200, Jacopo Mondi wrote: > Document Thine THC63LVD1024 LVDS decoder device tree bindings. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > .../bindings/display/bridge/thine,thc63lvd1024.txt | 60 ++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt Reviewed-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Jacopo, Laurent, On 04/10/2018 01:53 PM, Jacopo Mondi wrote: > Document Thine THC63LVD1024 LVDS decoder device tree bindings. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> > --- > .../bindings/display/bridge/thine,thc63lvd1024.txt | 60 ++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > > diff --git a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > new file mode 100644 > index 0000000..0b23e70 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > @@ -0,0 +1,60 @@ > +Thine Electronics THC63LVD1024 LVDS decoder > +------------------------------------------- > + > +The THC63LVD1024 is a dual link LVDS receiver designed to convert LVDS streams > +to parallel data outputs. The chip supports single/dual input/output modes, > +handling up to two LVDS input streams and up to two digital CMOS/TTL outputs. > + > +Single or dual operation mode, output data mapping and DDR output modes are > +configured through input signals and the chip does not expose any control bus. > + > +Required properties: > +- compatible: Shall be "thine,thc63lvd1024" > +- vcc-supply: Power supply for TTL output, TTL CLOCKOUT signal, LVDS input, > + PPL and digital circuitry > + > +Optional properties: > +- powerdown-gpios: Power down GPIO signal, pin name "/PDWN". Active low Thank you for the change. I would suggest to rename 'pwdn-gpios' property of THC63LVDM83D as well, as far as I understand it is only described in DT bindings documentation, and the property is unused in the driver or board DTS files at the moment. > +- oe-gpios: Output enable GPIO signal, pin name "OE". Active high Okay :) -- With best wishes, Vladimir -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Jacopo, On 04/19/2018 12:44 PM, Vladimir Zapolskiy wrote: > Hi Jacopo, Laurent, > > On 04/10/2018 01:53 PM, Jacopo Mondi wrote: >> Document Thine THC63LVD1024 LVDS decoder device tree bindings. >> >> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> >> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> >> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> >> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> > >> --- >> .../bindings/display/bridge/thine,thc63lvd1024.txt | 60 ++++++++++++++++++++++ >> 1 file changed, 60 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt >> >> diff --git a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt >> new file mode 100644 >> index 0000000..0b23e70 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt >> @@ -0,0 +1,60 @@ >> +Thine Electronics THC63LVD1024 LVDS decoder >> +------------------------------------------- >> + >> +The THC63LVD1024 is a dual link LVDS receiver designed to convert LVDS streams >> +to parallel data outputs. The chip supports single/dual input/output modes, >> +handling up to two LVDS input streams and up to two digital CMOS/TTL outputs. >> + >> +Single or dual operation mode, output data mapping and DDR output modes are >> +configured through input signals and the chip does not expose any control bus. >> + >> +Required properties: >> +- compatible: Shall be "thine,thc63lvd1024" >> +- vcc-supply: Power supply for TTL output, TTL CLOCKOUT signal, LVDS input, >> + PPL and digital circuitry >> + >> +Optional properties: >> +- powerdown-gpios: Power down GPIO signal, pin name "/PDWN". Active low > sorry for a follow-up, I've just noticed it, could you please double check spelling PDWN vs PWDN? Thank you in advance. -- With best wishes, Vladimir -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Jacopo, On 04/19/2018 12:48 PM, Vladimir Zapolskiy wrote: > Hi Jacopo, > > On 04/19/2018 12:44 PM, Vladimir Zapolskiy wrote: >> Hi Jacopo, Laurent, >> >> On 04/10/2018 01:53 PM, Jacopo Mondi wrote: >>> Document Thine THC63LVD1024 LVDS decoder device tree bindings. >>> >>> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> >>> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> >>> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >> >> Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> >> >>> --- [snip] >>> +Optional properties: >>> +- powerdown-gpios: Power down GPIO signal, pin name "/PDWN". Active low >> > > sorry for a follow-up, I've just noticed it, could you please double check > spelling PDWN vs PWDN? Thank you in advance. > please ignore it, I did it myself and the datasheet describes pin as /PDWN, I won't exclude a typo in the datasheet though... -- With best wishes, Vladimir -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Apr 19, 2018 at 12:44:32PM +0300, Vladimir Zapolskiy wrote: Hi Vladimir, > Hi Jacopo, Laurent, > > On 04/10/2018 01:53 PM, Jacopo Mondi wrote: > > Document Thine THC63LVD1024 LVDS decoder device tree bindings. > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> > > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> > > > --- > > .../bindings/display/bridge/thine,thc63lvd1024.txt | 60 ++++++++++++++++++++++ > > 1 file changed, 60 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > > new file mode 100644 > > index 0000000..0b23e70 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > > @@ -0,0 +1,60 @@ > > +Thine Electronics THC63LVD1024 LVDS decoder > > +------------------------------------------- > > + > > +The THC63LVD1024 is a dual link LVDS receiver designed to convert LVDS streams > > +to parallel data outputs. The chip supports single/dual input/output modes, > > +handling up to two LVDS input streams and up to two digital CMOS/TTL outputs. > > + > > +Single or dual operation mode, output data mapping and DDR output modes are > > +configured through input signals and the chip does not expose any control bus. > > + > > +Required properties: > > +- compatible: Shall be "thine,thc63lvd1024" > > +- vcc-supply: Power supply for TTL output, TTL CLOCKOUT signal, LVDS input, > > + PPL and digital circuitry > > + > > +Optional properties: > > +- powerdown-gpios: Power down GPIO signal, pin name "/PDWN". Active low > > Thank you for the change. > > I would suggest to rename 'pwdn-gpios' property of THC63LVDM83D as well, > as far as I understand it is only described in DT bindings documentation, > and the property is unused in the driver or board DTS files at the moment. Thanks for the suggestion, I'll do that! > > > +- oe-gpios: Output enable GPIO signal, pin name "OE". Active high > > Okay :) Yeah, please see Rob's and Laurent's reply to v7, where I renamed this to 'enable'. Thanks j > > -- > With best wishes, > Vladimir
diff --git a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt new file mode 100644 index 0000000..0b23e70 --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt @@ -0,0 +1,60 @@ +Thine Electronics THC63LVD1024 LVDS decoder +------------------------------------------- + +The THC63LVD1024 is a dual link LVDS receiver designed to convert LVDS streams +to parallel data outputs. The chip supports single/dual input/output modes, +handling up to two LVDS input streams and up to two digital CMOS/TTL outputs. + +Single or dual operation mode, output data mapping and DDR output modes are +configured through input signals and the chip does not expose any control bus. + +Required properties: +- compatible: Shall be "thine,thc63lvd1024" +- vcc-supply: Power supply for TTL output, TTL CLOCKOUT signal, LVDS input, + PPL and digital circuitry + +Optional properties: +- powerdown-gpios: Power down GPIO signal, pin name "/PDWN". Active low +- oe-gpios: Output enable GPIO signal, pin name "OE". Active high + +The THC63LVD1024 video port connections are modeled according +to OF graph bindings specified by Documentation/devicetree/bindings/graph.txt + +Required video port nodes: +- port@0: First LVDS input port +- port@2: First digital CMOS/TTL parallel output + +Optional video port nodes: +- port@1: Second LVDS input port +- port@3: Second digital CMOS/TTL parallel output + +Example: +-------- + + thc63lvd1024: lvds-decoder { + compatible = "thine,thc63lvd1024"; + + vcc-supply = <®_lvds_vcc>; + powerdown-gpios = <&gpio4 15 GPIO_ACTIVE_LOW>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + lvds_dec_in_0: endpoint { + remote-endpoint = <&lvds_out>; + }; + }; + + port@2{ + reg = <2>; + + lvds_dec_out_2: endpoint { + remote-endpoint = <&adv7511_in>; + }; + }; + }; + };