| Message ID | 1511430935-29783-1-git-send-email-pankaj.bansal@nxp.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v2,1/4] Documentation : can : flexcan : Add big-endian property to device tree | expand |
On 11/23/2017 10:55 AM, Pankaj Bansal wrote: > The FlexCAN controller can be modelled as little or big endian depending > on SOC design. This device tree property identifies the controller > endianness and the driver reads/writes controller registers based on > that. > > This is optional property. i.e. if this property is not present in > device tree node then controller is assumed to be little endian. if this > property is present then controller is assumed to be big endian. > > Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com> > Reviewed-by: Poonam Aggrwal <poonam.aggrwal@nxp.com> Please document the default behaviour in the bindings if the big-endian property is missing. This and the other series have to be applied in the correct order, otherwise you break bisectability when removing the "fsl,p1010-flexcan" from the mx{25,35,53} devicetree before adding the compatible to the driver. Maybe merge these two series? Marc
On 11/23/2017 01:08 PM, Pankaj Bansal wrote: >> This and the other series have to be applied in the correct order, otherwise >> you break bisectability when removing the "fsl,p1010-flexcan" >> from the mx{25,35,53} devicetree before adding the compatible to the driver. >> Maybe merge these two series? >> > > Can we merge these 2 series ? one set of changes are in net/can > directory which is managed in can-next branch. Other set of changes > are in device tree which is managed in dt-next branch. I thought both > these branches are independently updated and then all these branches > are merged in linux-next. They are independently managed, but the changes are not independent. Marc
diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt index 56d6cc3..bb081ba 100644 --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt @@ -18,6 +18,8 @@ Optional properties: - xceiver-supply: Regulator that powers the CAN transceiver +- big-endian: This means the registers of FlexCAN controller are big endian + Example: can@1c000 {