From patchwork Fri Aug 18 11:54:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kiran Gunda X-Patchwork-Id: 803199 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=codeaurora.org header.i=@codeaurora.org header.b="EHnl0Yz9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="EHnl0Yz9"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xYhNN6V5Fz9t2M for ; Fri, 18 Aug 2017 21:55:16 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751007AbdHRLzP (ORCPT ); Fri, 18 Aug 2017 07:55:15 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:54124 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbdHRLzO (ORCPT ); Fri, 18 Aug 2017 07:55:14 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 98C9960287; Fri, 18 Aug 2017 11:55:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1503057313; bh=8ArPlotGLQgSCRsTNDJ7M7EbryOo9VfuL77odnpZ2b0=; h=From:To:Cc:Subject:Date:From; b=EHnl0Yz9NUD2WhzFq4gO1y3Zg7nhBaag1E3cHCndQDValsJ1Lc9h1e4AO25yXlmJ4 bvK/aL+/NCfWCI0vXSztB5Y3OBXvrFjM3h2VW+0melyIjM1dqiN2xj1mYK8+SrWjgn 4B6be4W1E0D78RsD/MFITGFSVvsDyI3r1hCfj+FM= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from kgunda-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kgunda@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id A099060274; Fri, 18 Aug 2017 11:55:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1503057313; bh=8ArPlotGLQgSCRsTNDJ7M7EbryOo9VfuL77odnpZ2b0=; h=From:To:Cc:Subject:Date:From; b=EHnl0Yz9NUD2WhzFq4gO1y3Zg7nhBaag1E3cHCndQDValsJ1Lc9h1e4AO25yXlmJ4 bvK/aL+/NCfWCI0vXSztB5Y3OBXvrFjM3h2VW+0melyIjM1dqiN2xj1mYK8+SrWjgn 4B6be4W1E0D78RsD/MFITGFSVvsDyI3r1hCfj+FM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A099060274 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kgunda@codeaurora.org From: Kiran Gunda To: gregkh@linuxfoundation.org, sboyd@codeaurora.org, Rob Herring , Mark Rutland , Kiran Gunda , Abhijeet Dharmapurikar , David Collins , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: shawnguo@kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org Subject: [PATCH] spmi: pmic-arb: Enforce the ownership check optionally Date: Fri, 18 Aug 2017 17:24:36 +0530 Message-Id: <1503057279-27318-1-git-send-email-kgunda@codeaurora.org> X-Mailer: git-send-email 1.9.1 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The peripheral ownership check is not necessary on single master platforms. Hence, enforce the peripheral ownership check optioanlly. Signed-off-by: Kiran Gunda Tested-by: Shawn Guo --- This patch depends on the below patch series. Please take this patch along with this series. [PATCH V2 00/12]: spmi: pmic-arb: Support for HW v5 and other fixes Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt | 6 ++++++ drivers/spmi/spmi-pmic-arb.c | 7 ++++++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt index e16b9b5..da708e8 100644 --- a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt +++ b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt @@ -42,6 +42,10 @@ Required properties: cell 4: interrupt flags indicating level-sense information, as defined in dt-bindings/interrupt-controller/irq.h +Optional properties: +- qcom,enforce-ownership : A boolean property. If defined the peripheral + ownership check is enforced. Otherwise the ownership + check is ignored. Example: spmi { @@ -62,4 +66,6 @@ Example: interrupt-controller; #interrupt-cells = <4>; + + qcom,enforce-ownership; }; diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index ca9bdd3..354c949 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -167,6 +167,7 @@ struct spmi_pmic_arb { u16 *ppid_to_apid; u16 last_apid; struct apid_data apid_data[PMIC_ARB_MAX_PERIPHS]; + bool enforce_ownership; }; /** @@ -707,7 +708,8 @@ static int qpnpint_irq_domain_dt_translate(struct irq_domain *d, } apid = rc; - if (pmic_arb->apid_data[apid].irq_ee != pmic_arb->ee) { + if (pmic_arb->enforce_ownership && + pmic_arb->apid_data[apid].irq_ee != pmic_arb->ee) { dev_err(&pmic_arb->spmic->dev, "failed to xlate sid = %#x, periph = %#x, irq = %u: ee=%u but owner=%u\n", intspec[0], intspec[1], intspec[2], pmic_arb->ee, pmic_arb->apid_data[apid].irq_ee); @@ -1236,6 +1238,9 @@ static int spmi_pmic_arb_probe(struct platform_device *pdev) } pmic_arb->ee = ee; + pmic_arb->enforce_ownership = + of_property_read_bool(pdev->dev.of_node, "qcom,enforce-ownership"); + mapping_table = devm_kcalloc(&ctrl->dev, PMIC_ARB_MAX_PERIPHS, sizeof(*mapping_table), GFP_KERNEL); if (!mapping_table) {