diff mbox

[RFC,3/3] dt-bindings: i2c: eeprom: document "start-offset" binding

Message ID 1498736351-9021-4-git-send-email-claudiu.beznea@microchip.com
State Changes Requested, archived
Headers show

Commit Message

Claudiu Beznea June 29, 2017, 11:39 a.m. UTC
Document "start-offset" binding that will be used by at24
EEPROM driver.

Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
 Documentation/devicetree/bindings/eeprom/eeprom.txt | 3 +++
 1 file changed, 3 insertions(+)

Comments

Rob Herring (Arm) July 6, 2017, 3:45 p.m. UTC | #1
On Thu, Jun 29, 2017 at 02:39:11PM +0300, Claudiu Beznea wrote:
> Document "start-offset" binding that will be used by at24
> EEPROM driver.

Why do we need this property?

Seems like this should be handled by defining regions of the EEPROM that 
you care about (or perhaps are reserved and don't want to touch). Just a 
single offset value is not very flexible. 

> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
>  Documentation/devicetree/bindings/eeprom/eeprom.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/eeprom/eeprom.txt b/Documentation/devicetree/bindings/eeprom/eeprom.txt
> index a50dc01..e0bec50 100644
> --- a/Documentation/devicetree/bindings/eeprom/eeprom.txt
> +++ b/Documentation/devicetree/bindings/eeprom/eeprom.txt
> @@ -35,10 +35,13 @@ Optional properties:
>  
>    - read-only: this parameterless property disables writes to the eeprom
>  
> +  - start-offset: offset in EEPROM to start reading from
> +
>  Example:
>  
>  eeprom@52 {
>  	compatible = "atmel,24c32";
>  	reg = <0x52>;
>  	pagesize = <32>;
> +	start-offset = /bits/ 8 <0xf8>;

The size of the property is part of the ABI. Unless you *never* need 
offset of more than 256, then this should be 32-bit.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/eeprom/eeprom.txt b/Documentation/devicetree/bindings/eeprom/eeprom.txt
index a50dc01..e0bec50 100644
--- a/Documentation/devicetree/bindings/eeprom/eeprom.txt
+++ b/Documentation/devicetree/bindings/eeprom/eeprom.txt
@@ -35,10 +35,13 @@  Optional properties:
 
   - read-only: this parameterless property disables writes to the eeprom
 
+  - start-offset: offset in EEPROM to start reading from
+
 Example:
 
 eeprom@52 {
 	compatible = "atmel,24c32";
 	reg = <0x52>;
 	pagesize = <32>;
+	start-offset = /bits/ 8 <0xf8>;
 };