| Message ID | 1475853614-22409-4-git-send-email-pantelis.antoniou@konsulko.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Fri, Oct 7, 2016 at 5:20 PM, Pantelis Antoniou <pantelis.antoniou@konsulko.com> wrote: > From: Georgi Vlaev <gvlaev@juniper.net> > > Add device tree bindings document for the GPIO driver of > Juniper's CBC FPGA. > > Signed-off-by: Georgi Vlaev <gvlaev@juniper.net> > [Ported from Juniper kernel] > Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com> > --- > .../devicetree/bindings/gpio/jnx,gpio-cbc.txt | 30 ++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/jnx,gpio-cbc.txt > > diff --git a/Documentation/devicetree/bindings/gpio/jnx,gpio-cbc.txt b/Documentation/devicetree/bindings/gpio/jnx,gpio-cbc.txt > new file mode 100644 > index 0000000..d205d0b > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/jnx,gpio-cbc.txt > @@ -0,0 +1,30 @@ > +Juniper CBC FPGA GPIO block > + > +Required properties: > + > +- compatible: > + Must be "jnx,cbc-gpio" > + > +Optional properties: > + > +- reg: > + Address and length of the register set for the device. This is optional since > + usually the parent MFD driver fills it in. > + > +- #gpio-cells: > + Should be <2>. The first cell is the pin number (within the controller's > + pin space), and the second is used for the following flags: > + bit[0]: direction (0 = out, 1 = in) > + bit[1]: init high > + bit[2]: active low Can't you just refer to the generic bindings? Apart from that it looks fine. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/gpio/jnx,gpio-cbc.txt b/Documentation/devicetree/bindings/gpio/jnx,gpio-cbc.txt new file mode 100644 index 0000000..d205d0b --- /dev/null +++ b/Documentation/devicetree/bindings/gpio/jnx,gpio-cbc.txt @@ -0,0 +1,30 @@ +Juniper CBC FPGA GPIO block + +Required properties: + +- compatible: + Must be "jnx,cbc-gpio" + +Optional properties: + +- reg: + Address and length of the register set for the device. This is optional since + usually the parent MFD driver fills it in. + +- #gpio-cells: + Should be <2>. The first cell is the pin number (within the controller's + pin space), and the second is used for the following flags: + bit[0]: direction (0 = out, 1 = in) + bit[1]: init high + bit[2]: active low + +- gpio-controller: + Specifies that the node is a GPIO controller. + +Example: + +gpio_cbc { + compatible = "jnx,gpio-cbc"; + #gpio-cells = <2>; + gpio-controller; +};