| Message ID | 1468700175-31836-1-git-send-email-hdegoede@redhat.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Sat, Jul 16, 2016 at 3:16 PM, Hans de Goede <hdegoede@redhat.com> wrote: > mmc/sdio is an enumerable bus, so usually the os can find out which > device is attached without needing a compatible. Usually, yes, but always, no. Having it doesn't hurt either, so this is a NAK for me. > > Sometimes it is desirable to have a mmc function node, without having > to make up an otherwise unused compatible for the node, so make > the compatible properties optional. > > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Maxime Ripard <maxime.ripard@free-electrons.com> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Jul 16, 2016 at 3:38 PM, Rob Herring <robh+dt@kernel.org> wrote: > On Sat, Jul 16, 2016 at 3:16 PM, Hans de Goede <hdegoede@redhat.com> wrote: >> mmc/sdio is an enumerable bus, so usually the os can find out which >> device is attached without needing a compatible. > > Usually, yes, but always, no. Having it doesn't hurt either, so this > is a NAK for me. Having now read the generic ethernet device binding thread, I think the reasoning is okay, but please put those reasons here. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt index ed23b9b..a96c338 100644 --- a/Documentation/devicetree/bindings/mmc/mmc.txt +++ b/Documentation/devicetree/bindings/mmc/mmc.txt @@ -98,11 +98,13 @@ Required host node properties when using function subnodes: - #size-cells: should be zero. Required function subnode properties: -- compatible: name of SDIO function following generic names recommended practice - reg: Must contain the SDIO function number of the function this subnode describes. A value of 0 denotes the memory SD function, values from 1 to 7 denote the SDIO functions. +Optional function subnode properties: +- compatible: name of SDIO function following generic names recommended practice + Examples --------
mmc/sdio is an enumerable bus, so usually the os can find out which device is attached without needing a compatible. Sometimes it is desirable to have a mmc function node, without having to make up an otherwise unused compatible for the node, so make the compatible properties optional. Cc: Arnd Bergmann <arnd@arndb.de> Cc: Maxime Ripard <maxime.ripard@free-electrons.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- Documentation/devicetree/bindings/mmc/mmc.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)