| Message ID | 1468549218-19215-2-git-send-email-apronin@chromium.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Thu, Jul 14, 2016 at 7:20 PM, Andrey Pronin <apronin@chromium.org> wrote: > Add TPM2.0-compatible interface to Cr50. Document its properties > in devicetree. > > Signed-off-by: Andrey Pronin <apronin@chromium.org> > --- > .../devicetree/bindings/security/tpm/cr50_spi.txt | 30 ++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 Documentation/devicetree/bindings/security/tpm/cr50_spi.txt > > diff --git a/Documentation/devicetree/bindings/security/tpm/cr50_spi.txt b/Documentation/devicetree/bindings/security/tpm/cr50_spi.txt > new file mode 100644 > index 0000000..1b05e51 > --- /dev/null > +++ b/Documentation/devicetree/bindings/security/tpm/cr50_spi.txt > @@ -0,0 +1,30 @@ > +* Cr50 Chip on SPI. > + > +TCG PTP FIFO Compliant Interface to Cr50 on SPI bus. > + > +Required properties: > +- compatible: Should be "google,cr50_spi". google,cr50, maybe ? The "_spi" seems redundant. Also, I agree with comments from others - the term cr50 really needs an explanation (Google thinks that it is a motor bike, a scanner, or a coffee roaster). Thanks, Guenter > +- spi-max-frequency: Maximum SPI frequency. > + > +Optional properties: > +- access-delay-msec: Required delay between subsequent transactions on SPI. > +- sleep-delay-msec: Time after the last SPI activity, after which the chip > + may go to sleep. > +- wake-start-delay-msec: Time after initiating wake up before the chip is > + ready to accept commands over SPI. > + > +Example: > + > +&spi0 { > + status = "okay"; > + > + cr50@0 { > + compatible = "google,cr50_spi"; > + reg = <0>; > + spi-max-frequency = <800000>; > + > + access-delay-msec = <2>; > + sleep-delay-msec = <1000>; > + wake-start-delay-msec = <60>; > + }; > +}; > -- > 2.6.6 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jul 14, 2016 at 09:05:53PM -0700, Guenter Roeck wrote: > On Thu, Jul 14, 2016 at 7:20 PM, Andrey Pronin <apronin@chromium.org> wrote: > > + > > +Required properties: > > +- compatible: Should be "google,cr50_spi". > > google,cr50, maybe ? The "_spi" seems redundant. > I believe "_spi" is warranted. It's the driver that handles the SPI interface for Cr50 specifically. But if the same firmware ever talks through a different interface (say, I2C), this driver will not be compatible. > Also, I agree with comments from others - the term cr50 really needs > an explanation (Google thinks that it is a motor bike, a scanner, or a > coffee roaster). > Yes, will add a better description of what it is. My original one was too brief and imprecise at the same time. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jul 15, 2016 at 10:31 AM, Andrey Pronin <apronin@chromium.org> wrote: > On Thu, Jul 14, 2016 at 09:05:53PM -0700, Guenter Roeck wrote: >> On Thu, Jul 14, 2016 at 7:20 PM, Andrey Pronin <apronin@chromium.org> wrote: >> > + >> > +Required properties: >> > +- compatible: Should be "google,cr50_spi". >> >> google,cr50, maybe ? The "_spi" seems redundant. >> > > I believe "_spi" is warranted. It's the driver that handles the SPI > interface for Cr50 specifically. > But if the same firmware ever talks through a different interface (say, > I2C), this driver will not be compatible. > I meant in the context of it being attached to a spi device, which implies that it is connected through a spi bus. Guenter >> Also, I agree with comments from others - the term cr50 really needs >> an explanation (Google thinks that it is a motor bike, a scanner, or a >> coffee roaster). >> > > Yes, will add a better description of what it is. My original one was > too brief and imprecise at the same time. > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jul 14, 2016 at 07:20:17PM -0700, Andrey Pronin wrote: > Add TPM2.0-compatible interface to Cr50. Document its properties > in devicetree. > > Signed-off-by: Andrey Pronin <apronin@chromium.org> > --- > .../devicetree/bindings/security/tpm/cr50_spi.txt | 30 ++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 Documentation/devicetree/bindings/security/tpm/cr50_spi.txt > > diff --git a/Documentation/devicetree/bindings/security/tpm/cr50_spi.txt b/Documentation/devicetree/bindings/security/tpm/cr50_spi.txt > new file mode 100644 > index 0000000..1b05e51 > --- /dev/null > +++ b/Documentation/devicetree/bindings/security/tpm/cr50_spi.txt > @@ -0,0 +1,30 @@ > +* Cr50 Chip on SPI. > + > +TCG PTP FIFO Compliant Interface to Cr50 on SPI bus. > + > +Required properties: > +- compatible: Should be "google,cr50_spi". I agree with dropping '_spi'. The interface is defined by the parent device. > +- spi-max-frequency: Maximum SPI frequency. > + > +Optional properties: > +- access-delay-msec: Required delay between subsequent transactions on SPI. There may be a standard property for this... > +- sleep-delay-msec: Time after the last SPI activity, after which the chip > + may go to sleep. > +- wake-start-delay-msec: Time after initiating wake up before the chip is > + ready to accept commands over SPI. Use the standard unit '-ms' instead of '-msec'. Do these times really vary much and need to be in DT? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/security/tpm/cr50_spi.txt b/Documentation/devicetree/bindings/security/tpm/cr50_spi.txt new file mode 100644 index 0000000..1b05e51 --- /dev/null +++ b/Documentation/devicetree/bindings/security/tpm/cr50_spi.txt @@ -0,0 +1,30 @@ +* Cr50 Chip on SPI. + +TCG PTP FIFO Compliant Interface to Cr50 on SPI bus. + +Required properties: +- compatible: Should be "google,cr50_spi". +- spi-max-frequency: Maximum SPI frequency. + +Optional properties: +- access-delay-msec: Required delay between subsequent transactions on SPI. +- sleep-delay-msec: Time after the last SPI activity, after which the chip + may go to sleep. +- wake-start-delay-msec: Time after initiating wake up before the chip is + ready to accept commands over SPI. + +Example: + +&spi0 { + status = "okay"; + + cr50@0 { + compatible = "google,cr50_spi"; + reg = <0>; + spi-max-frequency = <800000>; + + access-delay-msec = <2>; + sleep-delay-msec = <1000>; + wake-start-delay-msec = <60>; + }; +};
Add TPM2.0-compatible interface to Cr50. Document its properties in devicetree. Signed-off-by: Andrey Pronin <apronin@chromium.org> --- .../devicetree/bindings/security/tpm/cr50_spi.txt | 30 ++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 Documentation/devicetree/bindings/security/tpm/cr50_spi.txt