diff mbox

[2/4] dt/bindings: Add bindings for Micro Crystal rv8803

Message ID 1466492240-5528-2-git-send-email-dirk.behme@de.bosch.com
State Changes Requested, archived
Headers show

Commit Message

Dirk Behme June 21, 2016, 6:57 a.m. UTC
From: Oleksij Rempel <fixed-term.Oleksij.Rempel@de.bosch.com>

... and Epson RX8900 real time clock

Signed-off-by: Oleksij Rempel <fixed-term.Oleksij.Rempel@de.bosch.com>
Cc: devicetree@vger.kernel.org
---
 .../devicetree/bindings/rtc/epson,rx8900.txt        | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/rtc/epson,rx8900.txt

Comments

Rob Herring June 21, 2016, 9:48 p.m. UTC | #1
On Tue, Jun 21, 2016 at 08:57:18AM +0200, Dirk Behme wrote:
> From: Oleksij Rempel <fixed-term.Oleksij.Rempel@de.bosch.com>
> 
> ... and Epson RX8900 real time clock
> 
> Signed-off-by: Oleksij Rempel <fixed-term.Oleksij.Rempel@de.bosch.com>
> Cc: devicetree@vger.kernel.org
> ---
>  .../devicetree/bindings/rtc/epson,rx8900.txt        | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rtc/epson,rx8900.txt
> 
> diff --git a/Documentation/devicetree/bindings/rtc/epson,rx8900.txt b/Documentation/devicetree/bindings/rtc/epson,rx8900.txt
> new file mode 100644
> index 0000000..51959de
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/epson,rx8900.txt
> @@ -0,0 +1,21 @@
> +Real Time Clock driver for:
> +  - Epson RX8900
> +  - Micro Crystal rv8803
> +
> +Required properties:
> +- compatible: should be: "mc,rv8803" or "epson,rx8900"
> +- reg : the I2C address of the device for I2C
> +
> +Optional properties:
> +- epson,vdetoff : Disable Voltage Detector. Should be set if no
> +  backup battery is used.

set to no? Looks like a boolean to me.

How about epson,vdet-disable to be consistent.

> +- trickle-diode-disable : Disable internal trickle charger diode

boolean?

Needs a vendor prefix.

> +
> +Example:
> +
> +	rtc: rtc@32 {
> +		compatible = "epson,rx8900"
> +		reg = <0x32>;
> +		epson,vdetoff;
> +		trickle-diode-disable;
> +	};
> -- 
> 2.8.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/rtc/epson,rx8900.txt b/Documentation/devicetree/bindings/rtc/epson,rx8900.txt
new file mode 100644
index 0000000..51959de
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/epson,rx8900.txt
@@ -0,0 +1,21 @@ 
+Real Time Clock driver for:
+  - Epson RX8900
+  - Micro Crystal rv8803
+
+Required properties:
+- compatible: should be: "mc,rv8803" or "epson,rx8900"
+- reg : the I2C address of the device for I2C
+
+Optional properties:
+- epson,vdetoff : Disable Voltage Detector. Should be set if no
+  backup battery is used.
+- trickle-diode-disable : Disable internal trickle charger diode
+
+Example:
+
+	rtc: rtc@32 {
+		compatible = "epson,rx8900"
+		reg = <0x32>;
+		epson,vdetoff;
+		trickle-diode-disable;
+	};