| Message ID | 1458854943-17388-3-git-send-email-heiko@sntech.de |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Thu, Mar 24, 2016 at 10:29:03PM +0100, Heiko Stuebner wrote: > The emmc-phy occupies a contiguous set of 8 registers inside the general > register files, so the reg property should specify this. > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > --- > This is essential a counter argument for Shawn's move from reg to reg_offset > in "phy: rockchip-emmc: fix compile issue on arm64 platform" [0]. > With the move under the grf we now also are able to specify this stuff > cleanly using already present mechanisms. > > Also meant to v4.6-rc before the binding solidifies. > > > [0] https://lkml.org/lkml/2016/3/8/114 > > Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Friday 25 March 2016 02:59 AM, Heiko Stuebner wrote: > The emmc-phy occupies a contiguous set of 8 registers inside the general > register files, so the reg property should specify this. > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > --- > This is essential a counter argument for Shawn's move from reg to reg_offset > in "phy: rockchip-emmc: fix compile issue on arm64 platform" [0]. > With the move under the grf we now also are able to specify this stuff > cleanly using already present mechanisms. > > Also meant to v4.6-rc before the binding solidifies. > > > [0] https://lkml.org/lkml/2016/3/8/114 > > Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt > index 461e958..555cb0f 100644 > --- a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt > +++ b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt > @@ -4,7 +4,7 @@ Rockchip EMMC PHY > Required properties: > - compatible: rockchip,rk3399-emmc-phy > - #phy-cells: must be 0 > - - reg: PHY configure reg address offset in "general > + - reg: PHY register address offset and length in "general > register files" > > Example: > @@ -12,12 +12,14 @@ Example: > > grf: syscon@ff770000 { > compatible = "rockchip,rk3399-grf", "syscon", "simple-mfd"; > + #address-cells = <1>; > + #size-cells = <1>; This patch is not applying. Care to resend based on linux-phy fixes? Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Wednesday 13 April 2016 06:31 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Friday 25 March 2016 02:59 AM, Heiko Stuebner wrote: >> The emmc-phy occupies a contiguous set of 8 registers inside the general >> register files, so the reg property should specify this. >> >> Signed-off-by: Heiko Stuebner <heiko@sntech.de> >> --- >> This is essential a counter argument for Shawn's move from reg to reg_offset >> in "phy: rockchip-emmc: fix compile issue on arm64 platform" [0]. >> With the move under the grf we now also are able to specify this stuff >> cleanly using already present mechanisms. >> >> Also meant to v4.6-rc before the binding solidifies. >> >> >> [0] https://lkml.org/lkml/2016/3/8/114 >> >> Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt >> index 461e958..555cb0f 100644 >> --- a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt >> +++ b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt >> @@ -4,7 +4,7 @@ Rockchip EMMC PHY >> Required properties: >> - compatible: rockchip,rk3399-emmc-phy >> - #phy-cells: must be 0 >> - - reg: PHY configure reg address offset in "general >> + - reg: PHY register address offset and length in "general >> register files" >> >> Example: >> @@ -12,12 +12,14 @@ Example: >> >> grf: syscon@ff770000 { >> compatible = "rockchip,rk3399-grf", "syscon", "simple-mfd"; >> + #address-cells = <1>; >> + #size-cells = <1>; > > This patch is not applying. Care to resend based on linux-phy fixes? sorry for the noise. I have applied this to linux-phy fixes now. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt index 461e958..555cb0f 100644 --- a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt +++ b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt @@ -4,7 +4,7 @@ Rockchip EMMC PHY Required properties: - compatible: rockchip,rk3399-emmc-phy - #phy-cells: must be 0 - - reg: PHY configure reg address offset in "general + - reg: PHY register address offset and length in "general register files" Example: @@ -12,12 +12,14 @@ Example: grf: syscon@ff770000 { compatible = "rockchip,rk3399-grf", "syscon", "simple-mfd"; + #address-cells = <1>; + #size-cells = <1>; ... emmcphy: phy@f780 { compatible = "rockchip,rk3399-emmc-phy"; - reg = <0xf780>; + reg = <0xf780 0x20>; #phy-cells = <0>; }; };
The emmc-phy occupies a contiguous set of 8 registers inside the general register files, so the reg property should specify this. Signed-off-by: Heiko Stuebner <heiko@sntech.de> --- This is essential a counter argument for Shawn's move from reg to reg_offset in "phy: rockchip-emmc: fix compile issue on arm64 platform" [0]. With the move under the grf we now also are able to specify this stuff cleanly using already present mechanisms. Also meant to v4.6-rc before the binding solidifies. [0] https://lkml.org/lkml/2016/3/8/114 Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)