| Message ID | 1450209132-20185-1-git-send-email-tim.bird@sonymobile.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Tue 15 Dec 11:52 PST 2015, Tim Bird wrote: > Add the otg regulator provided by the charger block. > > Signed-off-by: Tim Bird <tim.bird@sonymobile.com> > --- > Changes since V3: > - change name of charger regulator to "otg-vbus" > --- > arch/arm/boot/dts/qcom-pm8941.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi > index b0d4439..d0ffca7 100644 > --- a/arch/arm/boot/dts/qcom-pm8941.dtsi > +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi > @@ -45,6 +45,10 @@ > "chg-gone", > "usb-valid", > "dc-valid"; > + > + usb_otg_in-supply = <&pm8941_5vs1>; Although this could be coming from some other supply I think it's perfectly fine that we define this on a platform level. > + > + chg_otg: otg-vbus { }; > }; > > pm8941_gpios: gpios@c000 { Reviewed-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue 15 Dec 11:52 PST 2015, Tim Bird wrote: > Add a regulator to control the OTG chargepath switch. This > is used by USB code to control VBUS direction - out for host mode > on the OTG port, and in for charging mode. > > Signed-off-by: Tim Bird <tim.bird@sonymobile.com> > --- > Changes since v3: > - changed DT node name to otg-vbus > - removed fixed-voltage setup from otg regulator rdesc > Changes since v1: > - changed name of supply to remove underscores > --- Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue 15 Dec 11:52 PST 2015, Tim Bird wrote: > Add a binding for the regulator which controls the OTG chargepath switch. > The OTG switch gets its power from pm8941_5vs1, and that should be > expressed as a usb_otg_in-supply property in the DT node for the > charger driver. The regulator name is "otg-vbus". > > Signed-off-by: Tim Bird <tim.bird@sonymobile.com> > --- > Changes since v3 > - switch supply name to have underscores instead of dashes > - (switched back to match the name used in data sheets) Thanks, now it matches the datasheet again. > - switch regulator node name to otg-vbus > Changes since v1 > - switch supply name to have dashes instead of underscores > - remove superfluous DT explanations in the otg node description > --- Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Dec 15, 2015 at 11:52:11AM -0800, Tim Bird wrote: > Add a regulator to control the OTG chargepath switch. This > is used by USB code to control VBUS direction - out for host mode > on the OTG port, and in for charging mode. > > Signed-off-by: Tim Bird <tim.bird@sonymobile.com> > --- > Changes since v3: > - changed DT node name to otg-vbus > - removed fixed-voltage setup from otg regulator rdesc > Changes since v1: > - changed name of supply to remove underscores > --- Reviewed-by: Andy Gross <andy.gross@linaro.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Dec 15, 2015 at 11:52:10AM -0800, Tim Bird wrote: > Add a binding for the regulator which controls the OTG chargepath switch. > The OTG switch gets its power from pm8941_5vs1, and that should be > expressed as a usb_otg_in-supply property in the DT node for the > charger driver. The regulator name is "otg-vbus". > > Signed-off-by: Tim Bird <tim.bird@sonymobile.com> > --- > Changes since v3 > - switch supply name to have underscores instead of dashes > - (switched back to match the name used in data sheets) > - switch regulator node name to otg-vbus > Changes since v1 > - switch supply name to have dashes instead of underscores > - remove superfluous DT explanations in the otg node description Reviewed-by: Andy Gross <andy.gross@linaro.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Tue, Dec 15, 2015 at 11:52:10AM -0800, Tim Bird wrote: > Add a binding for the regulator which controls the OTG chargepath switch. > The OTG switch gets its power from pm8941_5vs1, and that should be > expressed as a usb_otg_in-supply property in the DT node for the > charger driver. The regulator name is "otg-vbus". I would like to get an acked-by from either the regulator framework maintainers, or DT binding maintainers (or both ;)) on the binding. -- Sebastian
On Wed, Dec 16, 2015 at 12:13:50AM +0100, Sebastian Reichel wrote: > On Tue, Dec 15, 2015 at 11:52:10AM -0800, Tim Bird wrote: > > Add a binding for the regulator which controls the OTG chargepath switch. > > The OTG switch gets its power from pm8941_5vs1, and that should be > > expressed as a usb_otg_in-supply property in the DT node for the > > charger driver. The regulator name is "otg-vbus". > I would like to get an acked-by from either the regulator framework > maintainers, or DT binding maintainers (or both ;)) on the binding. Please submit any patches you want reviewing using the process in SubmittingPatches. If this is a regulator driver it should be in drivers/regulator though.
On Tue, Dec 15, 2015 at 11:52:10AM -0800, Tim Bird wrote: > Add a binding for the regulator which controls the OTG chargepath switch. > The OTG switch gets its power from pm8941_5vs1, and that should be > expressed as a usb_otg_in-supply property in the DT node for the > charger driver. The regulator name is "otg-vbus". > > Signed-off-by: Tim Bird <tim.bird@sonymobile.com> > --- > Changes since v3 > - switch supply name to have underscores instead of dashes > - (switched back to match the name used in data sheets) > - switch regulator node name to otg-vbus > Changes since v1 > - switch supply name to have dashes instead of underscores > - remove superfluous DT explanations in the otg node description > --- > .../devicetree/bindings/power_supply/qcom_smbb.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/power_supply/qcom_smbb.txt b/Documentation/devicetree/bindings/power_supply/qcom_smbb.txt index 65b88fa..06f8a5d 100644 --- a/Documentation/devicetree/bindings/power_supply/qcom_smbb.txt +++ b/Documentation/devicetree/bindings/power_supply/qcom_smbb.txt @@ -105,6 +105,22 @@ PROPERTIES regulation must be done externally to fully comply with the JEITA safety guidelines if this flag is set. +- usb_otg_in-supply: + Usage: optional + Value type: <phandle> + Description: Reference to the regulator supplying power to the USB_OTG_IN + pin. + +child nodes: +- otg-vbus: + Usage: optional + Description: This node defines a regulator used to control the direction + of VBUS voltage - specifically: whether to supply voltage + to VBUS for host mode operation of the OTG port, or allow + input voltage from external VBUS for charging. In the + hardware, the supply for this regulator comes from + usb_otg_in-supply. + EXAMPLE charger@1000 { compatible = "qcom,pm8941-charger"; @@ -128,4 +144,7 @@ charger@1000 { qcom,fast-charge-current-limit = <1000000>; qcom,dc-charge-current-limit = <1000000>; + usb_otg_in-supply = <&pm8941_5vs1>; + + otg-vbus {}; };
Add a binding for the regulator which controls the OTG chargepath switch. The OTG switch gets its power from pm8941_5vs1, and that should be expressed as a usb_otg_in-supply property in the DT node for the charger driver. The regulator name is "otg-vbus". Signed-off-by: Tim Bird <tim.bird@sonymobile.com> --- Changes since v3 - switch supply name to have underscores instead of dashes - (switched back to match the name used in data sheets) - switch regulator node name to otg-vbus Changes since v1 - switch supply name to have dashes instead of underscores - remove superfluous DT explanations in the otg node description --- .../devicetree/bindings/power_supply/qcom_smbb.txt | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)