diff mbox

[1/2] devicetree: mxsfb: add reset-active property

Message ID 1450200297-19243-1-git-send-email-mans@mansr.com
State Not Applicable, archived
Headers show

Commit Message

Måns Rullgård Dec. 15, 2015, 5:24 p.m. UTC
Some boards connect the LCD_RESET pin to a reset input on the
display panel.  On these boards, this pin must be set to the
proper level for the display to function.

This adds an optional "reset-active" property to the "display"
subnode such that devicetrees can specify the desired polarity
of the LCD_RESET pin.

Signed-off-by: Mans Rullgard <mans@mansr.com>
---
 Documentation/devicetree/bindings/display/mxsfb.txt | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Rob Herring (Arm) Dec. 20, 2015, 3:38 a.m. UTC | #1
On Tue, Dec 15, 2015 at 05:24:56PM +0000, Mans Rullgard wrote:
> Some boards connect the LCD_RESET pin to a reset input on the
> display panel.  On these boards, this pin must be set to the
> proper level for the display to function.
> 
> This adds an optional "reset-active" property to the "display"
> subnode such that devicetrees can specify the desired polarity
> of the LCD_RESET pin.
> 
> Signed-off-by: Mans Rullgard <mans@mansr.com>

Acked-by: Rob Herring <robh@kernel.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Måns Rullgård Jan. 11, 2016, 2:38 p.m. UTC | #2
Rob Herring <robh@kernel.org> writes:

> On Tue, Dec 15, 2015 at 05:24:56PM +0000, Mans Rullgard wrote:
>> Some boards connect the LCD_RESET pin to a reset input on the
>> display panel.  On these boards, this pin must be set to the
>> proper level for the display to function.
>> 
>> This adds an optional "reset-active" property to the "display"
>> subnode such that devicetrees can specify the desired polarity
>> of the LCD_RESET pin.
>> 
>> Signed-off-by: Mans Rullgard <mans@mansr.com>
>
> Acked-by: Rob Herring <robh@kernel.org>

What happened to this patch?
Rob Herring (Arm) Jan. 12, 2016, 12:01 a.m. UTC | #3
On Mon, Jan 11, 2016 at 8:38 AM, Måns Rullgård <mans@mansr.com> wrote:
> Rob Herring <robh@kernel.org> writes:
>
>> On Tue, Dec 15, 2015 at 05:24:56PM +0000, Mans Rullgard wrote:
>>> Some boards connect the LCD_RESET pin to a reset input on the
>>> display panel.  On these boards, this pin must be set to the
>>> proper level for the display to function.
>>>
>>> This adds an optional "reset-active" property to the "display"
>>> subnode such that devicetrees can specify the desired polarity
>>> of the LCD_RESET pin.
>>>
>>> Signed-off-by: Mans Rullgard <mans@mansr.com>
>>
>> Acked-by: Rob Herring <robh@kernel.org>
>
> What happened to this patch?

If I acked it, then I'm expecting the platform or subsystem maintainer
to pick up the series. I don't have patch #2 either, so I'm definitely
not picking up the series.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Måns Rullgård Jan. 12, 2016, 12:05 a.m. UTC | #4
Rob Herring <robh@kernel.org> writes:

> On Mon, Jan 11, 2016 at 8:38 AM, Måns Rullgård <mans@mansr.com> wrote:
>> Rob Herring <robh@kernel.org> writes:
>>
>>> On Tue, Dec 15, 2015 at 05:24:56PM +0000, Mans Rullgard wrote:
>>>> Some boards connect the LCD_RESET pin to a reset input on the
>>>> display panel.  On these boards, this pin must be set to the
>>>> proper level for the display to function.
>>>>
>>>> This adds an optional "reset-active" property to the "display"
>>>> subnode such that devicetrees can specify the desired polarity
>>>> of the LCD_RESET pin.
>>>>
>>>> Signed-off-by: Mans Rullgard <mans@mansr.com>
>>>
>>> Acked-by: Rob Herring <robh@kernel.org>
>>
>> What happened to this patch?
>
> If I acked it, then I'm expecting the platform or subsystem maintainer
> to pick up the series. I don't have patch #2 either, so I'm definitely
> not picking up the series.

Argh, get_maintainer.pl picking different people for different patches
again.  I really wish it would/could send all patches in a series to the
same recipients in cases like this.

Should I resend both to the combined set of people so everybody gets to
see everything?
Rob Herring (Arm) Jan. 12, 2016, 12:28 a.m. UTC | #5
On Mon, Jan 11, 2016 at 6:05 PM, Måns Rullgård <mans@mansr.com> wrote:
> Rob Herring <robh@kernel.org> writes:
>
>> On Mon, Jan 11, 2016 at 8:38 AM, Måns Rullgård <mans@mansr.com> wrote:
>>> Rob Herring <robh@kernel.org> writes:
>>>
>>>> On Tue, Dec 15, 2015 at 05:24:56PM +0000, Mans Rullgard wrote:
>>>>> Some boards connect the LCD_RESET pin to a reset input on the
>>>>> display panel.  On these boards, this pin must be set to the
>>>>> proper level for the display to function.
>>>>>
>>>>> This adds an optional "reset-active" property to the "display"
>>>>> subnode such that devicetrees can specify the desired polarity
>>>>> of the LCD_RESET pin.
>>>>>
>>>>> Signed-off-by: Mans Rullgard <mans@mansr.com>
>>>>
>>>> Acked-by: Rob Herring <robh@kernel.org>
>>>
>>> What happened to this patch?
>>
>> If I acked it, then I'm expecting the platform or subsystem maintainer
>> to pick up the series. I don't have patch #2 either, so I'm definitely
>> not picking up the series.
>
> Argh, get_maintainer.pl picking different people for different patches
> again.  I really wish it would/could send all patches in a series to the
> same recipients in cases like this.

Yeah, we really need some scripts around creating Cc list for series
gel_maintainers.pl really only works for a single commit. I imagine
everyone has some level of scripts around it.

> Should I resend both to the combined set of people so everybody gets to
> see everything?

Yes, as long as you are not resending daily, just resend. Send the
series TO who you think should merge it.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/display/mxsfb.txt b/Documentation/devicetree/bindings/display/mxsfb.txt
index 96ec517..cb7212a 100644
--- a/Documentation/devicetree/bindings/display/mxsfb.txt
+++ b/Documentation/devicetree/bindings/display/mxsfb.txt
@@ -13,6 +13,11 @@  Required properties:
 - bits-per-pixel : <16> for RGB565, <32> for RGB888/666.
 - bus-width : number of data lines.  Could be <8>, <16>, <18> or <24>.
 
+Optional properties:
+- reset-active : <0>: reset pin is active low
+                 <1>: reset pin is active high
+                 omitted: reset pin not used
+
 Required sub-node:
 - display-timings : Refer to binding doc display-timing.txt for details.