| Message ID | 1446545174-14193-6-git-send-email-vigneshr@ti.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Tue, Nov 03, 2015 at 03:36:14PM +0530, Vignesh R wrote: > Add qspi memory mapped region entries for AM43xx based SoCs. Also, > update the binding documents for the controller to document this change. > > Signed-off-by: Vignesh R <vigneshr@ti.com> Acked-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/spi/ti_qspi.txt | 5 +++-- > arch/arm/boot/dts/am4372.dtsi | 4 +++- > 2 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/spi/ti_qspi.txt b/Documentation/devicetree/bindings/spi/ti_qspi.txt > index f05dd631bef1..05488970060b 100644 > --- a/Documentation/devicetree/bindings/spi/ti_qspi.txt > +++ b/Documentation/devicetree/bindings/spi/ti_qspi.txt > @@ -17,9 +17,10 @@ Recommended properties: > > Example: > > +For am4372: > qspi: qspi@4b300000 { > - compatible = "ti,dra7xxx-qspi"; > - reg = <0x47900000 0x100>, <0x30000000 0x3ffffff>; > + compatible = "ti,am4372-qspi"; > + reg = <0x47900000 0x100>, <0x30000000 0x4000000>; > reg-names = "qspi_base", "qspi_mmap"; > #address-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi > index 0447c04a40cc..1b2c545f3f2c 100644 > --- a/arch/arm/boot/dts/am4372.dtsi > +++ b/arch/arm/boot/dts/am4372.dtsi > @@ -962,7 +962,9 @@ > > qspi: qspi@47900000 { > compatible = "ti,am4372-qspi"; > - reg = <0x47900000 0x100>; > + reg = <0x47900000 0x100>, > + <0x30000000 0x4000000>; > + reg-names = "qspi_base", "qspi_mmap"; > #address-cells = <1>; > #size-cells = <0>; > ti,hwmods = "qspi"; > -- > 2.6.2 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, Rob Herring <robh@kernel.org> writes: > On Tue, Nov 03, 2015 at 03:36:14PM +0530, Vignesh R wrote: >> Add qspi memory mapped region entries for AM43xx based SoCs. Also, >> update the binding documents for the controller to document this change. >> >> Signed-off-by: Vignesh R <vigneshr@ti.com> > > Acked-by: Rob Herring <robh@kernel.org> > >> --- >> Documentation/devicetree/bindings/spi/ti_qspi.txt | 5 +++-- >> arch/arm/boot/dts/am4372.dtsi | 4 +++- >> 2 files changed, 6 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/spi/ti_qspi.txt b/Documentation/devicetree/bindings/spi/ti_qspi.txt >> index f05dd631bef1..05488970060b 100644 >> --- a/Documentation/devicetree/bindings/spi/ti_qspi.txt >> +++ b/Documentation/devicetree/bindings/spi/ti_qspi.txt >> @@ -17,9 +17,10 @@ Recommended properties: >> >> Example: >> >> +For am4372: >> qspi: qspi@4b300000 { >> - compatible = "ti,dra7xxx-qspi"; >> - reg = <0x47900000 0x100>, <0x30000000 0x3ffffff>; >> + compatible = "ti,am4372-qspi"; >> + reg = <0x47900000 0x100>, <0x30000000 0x4000000>; >> reg-names = "qspi_base", "qspi_mmap"; >> #address-cells = <1>; >> #size-cells = <0>; and how does the user for this look like ? Don't you need to give this a proper 'ranges' binding ?
On 11/06/2015 10:44 AM, Felipe Balbi wrote: > > Hi, > > Rob Herring <robh@kernel.org> writes: >> On Tue, Nov 03, 2015 at 03:36:14PM +0530, Vignesh R wrote: >>> Add qspi memory mapped region entries for AM43xx based SoCs. Also, >>> update the binding documents for the controller to document this change. >>> >>> Signed-off-by: Vignesh R <vigneshr@ti.com> >> >> Acked-by: Rob Herring <robh@kernel.org> >> >>> --- >>> Documentation/devicetree/bindings/spi/ti_qspi.txt | 5 +++-- >>> arch/arm/boot/dts/am4372.dtsi | 4 +++- >>> 2 files changed, 6 insertions(+), 3 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/spi/ti_qspi.txt b/Documentation/devicetree/bindings/spi/ti_qspi.txt >>> index f05dd631bef1..05488970060b 100644 >>> --- a/Documentation/devicetree/bindings/spi/ti_qspi.txt >>> +++ b/Documentation/devicetree/bindings/spi/ti_qspi.txt >>> @@ -17,9 +17,10 @@ Recommended properties: >>> >>> Example: >>> >>> +For am4372: >>> qspi: qspi@4b300000 { >>> - compatible = "ti,dra7xxx-qspi"; >>> - reg = <0x47900000 0x100>, <0x30000000 0x3ffffff>; >>> + compatible = "ti,am4372-qspi"; >>> + reg = <0x47900000 0x100>, <0x30000000 0x4000000>; >>> reg-names = "qspi_base", "qspi_mmap"; >>> #address-cells = <1>; >>> #size-cells = <0>; > > and how does the user for this look like ? Don't you need to give this a > proper 'ranges' binding ? > There are no other users of qspi_mmap region except ti-qspi driver itself: In probe: res_mmap = platform_get_resource_byname(pdev, IORESOURCE_MEM, "qspi_mmap"); qspi->mmap_base = devm_ioremap_resource(&pdev->dev, res_mmap); and for reading from mmap region: memcpy_fromio(buf, qspi->mmap_base + from, len);
diff --git a/Documentation/devicetree/bindings/spi/ti_qspi.txt b/Documentation/devicetree/bindings/spi/ti_qspi.txt index f05dd631bef1..05488970060b 100644 --- a/Documentation/devicetree/bindings/spi/ti_qspi.txt +++ b/Documentation/devicetree/bindings/spi/ti_qspi.txt @@ -17,9 +17,10 @@ Recommended properties: Example: +For am4372: qspi: qspi@4b300000 { - compatible = "ti,dra7xxx-qspi"; - reg = <0x47900000 0x100>, <0x30000000 0x3ffffff>; + compatible = "ti,am4372-qspi"; + reg = <0x47900000 0x100>, <0x30000000 0x4000000>; reg-names = "qspi_base", "qspi_mmap"; #address-cells = <1>; #size-cells = <0>; diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi index 0447c04a40cc..1b2c545f3f2c 100644 --- a/arch/arm/boot/dts/am4372.dtsi +++ b/arch/arm/boot/dts/am4372.dtsi @@ -962,7 +962,9 @@ qspi: qspi@47900000 { compatible = "ti,am4372-qspi"; - reg = <0x47900000 0x100>; + reg = <0x47900000 0x100>, + <0x30000000 0x4000000>; + reg-names = "qspi_base", "qspi_mmap"; #address-cells = <1>; #size-cells = <0>; ti,hwmods = "qspi";
Add qspi memory mapped region entries for AM43xx based SoCs. Also, update the binding documents for the controller to document this change. Signed-off-by: Vignesh R <vigneshr@ti.com> --- Documentation/devicetree/bindings/spi/ti_qspi.txt | 5 +++-- arch/arm/boot/dts/am4372.dtsi | 4 +++- 2 files changed, 6 insertions(+), 3 deletions(-)