| Message ID | 1444057643-29672-1-git-send-email-javier@osg.samsung.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Mon, Oct 5, 2015 at 10:07 AM, Javier Martinez Canillas <javier@osg.samsung.com> wrote: > The max77802 regulator driver defines the supply name for each regulator > so these can be described in DT but is not mentioned in the binding doc. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > > .../devicetree/bindings/regulator/max77802.txt | 23 +++++++++++++++++++++- > 1 file changed, 22 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/regulator/max77802.txt b/Documentation/devicetree/bindings/regulator/max77802.txt > index 79e5476444f7..b466689c47ea 100644 > --- a/Documentation/devicetree/bindings/regulator/max77802.txt > +++ b/Documentation/devicetree/bindings/regulator/max77802.txt > @@ -8,7 +8,26 @@ regulators that can be controlled over I2C. > > Following properties should be present in main device node of the MFD chip. > > -Optional node: regulators is still a node, so you should have 2 sections. > +Optional properties: > +- inb1-supply: The input supply for BUCK1 > +- inb2-supply: The input supply for BUCK2 > +- inb3-supply: The input supply for BUCK3 > +- inb4-supply: The input supply for BUCK4 > +- inb5-supply: The input supply for BUCK5 > +- inb6-supply: The input supply for BUCK6 > +- inb7-supply: The input supply for BUCK7 > +- inb8-supply: The input supply for BUCK8 > +- inb9-supply: The input supply for BUCK9 > +- inb10-supply: The input supply for BUCK10 > +- inl1-supply: The input supply for LDO8 and LDO15 > +- inl2-supply: The input supply for LDO17, LDO27, LDO30 and LDO35 > +- inl3-supply: The input supply for LDO3, LDO5, LDO6 and LDO7 > +- inl4-supply: The input supply for LDO10, LDO11, LDO13 and LDO14 > +- inl5-supply: The input supply for LDO9 and LDO19 > +- inl6-supply: The input supply for LDO4, LDO21, LDO24 and LDO33 > +- inl7-supply: The input supply for LDO18, LDO20, LDO28 and LDO29 > +- inl9-supply: The input supply for LDO12, LDO23, LDO25, LDO26, LDO32 and LDO34 > +- inl10-supply: The input supply for LDO1 and LDO2 > - regulators : The regulators of max77802 have to be instantiated > under subnode named "regulators" using the following format. > > @@ -58,6 +77,8 @@ Example: > #address-cells = <1>; > #size-cells = <0>; > > + inb1-supply = <&parent_reg>; > + > regulators { > ldo1_reg: LDO1 { > regulator-name = "vdd_1v0"; > -- > 2.4.3 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Rob, Thanks for your feedback. On 10/05/2015 06:15 PM, Rob Herring wrote: > On Mon, Oct 5, 2015 at 10:07 AM, Javier Martinez Canillas > <javier@osg.samsung.com> wrote: >> The max77802 regulator driver defines the supply name for each regulator >> so these can be described in DT but is not mentioned in the binding doc. >> >> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> >> >> --- >> >> .../devicetree/bindings/regulator/max77802.txt | 23 +++++++++++++++++++++- >> 1 file changed, 22 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/regulator/max77802.txt b/Documentation/devicetree/bindings/regulator/max77802.txt >> index 79e5476444f7..b466689c47ea 100644 >> --- a/Documentation/devicetree/bindings/regulator/max77802.txt >> +++ b/Documentation/devicetree/bindings/regulator/max77802.txt >> @@ -8,7 +8,26 @@ regulators that can be controlled over I2C. >> >> Following properties should be present in main device node of the MFD chip. >> >> -Optional node: > > regulators is still a node, so you should have 2 sections. > You are right, I included both because I saw other DT bindings doing this but agree the correct approach is to have two separate sections. Mark already applied this patch though so I can't send a v2 but I'll post an incremental patch on top of his topic/max77802 branch: https://git.kernel.org/cgit/linux/kernel/git/broonie/regulator.git/log/?h=topic/max77802 Best regards,
diff --git a/Documentation/devicetree/bindings/regulator/max77802.txt b/Documentation/devicetree/bindings/regulator/max77802.txt index 79e5476444f7..b466689c47ea 100644 --- a/Documentation/devicetree/bindings/regulator/max77802.txt +++ b/Documentation/devicetree/bindings/regulator/max77802.txt @@ -8,7 +8,26 @@ regulators that can be controlled over I2C. Following properties should be present in main device node of the MFD chip. -Optional node: +Optional properties: +- inb1-supply: The input supply for BUCK1 +- inb2-supply: The input supply for BUCK2 +- inb3-supply: The input supply for BUCK3 +- inb4-supply: The input supply for BUCK4 +- inb5-supply: The input supply for BUCK5 +- inb6-supply: The input supply for BUCK6 +- inb7-supply: The input supply for BUCK7 +- inb8-supply: The input supply for BUCK8 +- inb9-supply: The input supply for BUCK9 +- inb10-supply: The input supply for BUCK10 +- inl1-supply: The input supply for LDO8 and LDO15 +- inl2-supply: The input supply for LDO17, LDO27, LDO30 and LDO35 +- inl3-supply: The input supply for LDO3, LDO5, LDO6 and LDO7 +- inl4-supply: The input supply for LDO10, LDO11, LDO13 and LDO14 +- inl5-supply: The input supply for LDO9 and LDO19 +- inl6-supply: The input supply for LDO4, LDO21, LDO24 and LDO33 +- inl7-supply: The input supply for LDO18, LDO20, LDO28 and LDO29 +- inl9-supply: The input supply for LDO12, LDO23, LDO25, LDO26, LDO32 and LDO34 +- inl10-supply: The input supply for LDO1 and LDO2 - regulators : The regulators of max77802 have to be instantiated under subnode named "regulators" using the following format. @@ -58,6 +77,8 @@ Example: #address-cells = <1>; #size-cells = <0>; + inb1-supply = <&parent_reg>; + regulators { ldo1_reg: LDO1 { regulator-name = "vdd_1v0";
The max77802 regulator driver defines the supply name for each regulator so these can be described in DT but is not mentioned in the binding doc. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- .../devicetree/bindings/regulator/max77802.txt | 23 +++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-)