diff mbox

[2/2] dt-bindings: Add new boards to bcm4708 DT bindings

Message ID 1443824564-17291-2-git-send-email-jonmason@broadcom.com
State Superseded, archived
Headers show

Commit Message

Jon Mason Oct. 2, 2015, 10:22 p.m. UTC
Add the 4708, 4709, and 953012k SVKs to the the documentation for the
Broadcom Northstar device tree bindings.

Signed-off-by: Jon Mason <jonmason@broadcom.com>
---
 Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Hauke Mehrtens Oct. 10, 2015, 2:42 p.m. UTC | #1
On 10/03/2015 12:22 AM, Jon Mason wrote:
> Add the 4708, 4709, and 953012k SVKs to the the documentation for the
> Broadcom Northstar device tree bindings.
> 
> Signed-off-by: Jon Mason <jonmason@broadcom.com>
> ---
>  Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
> index 6b0f49f..bdf4c06 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt

What should be documented in this file? This is more a question to the
guys more familiar with arm in Linux. Currently the Linux kernel only
supports brcm,bcm4708 and all goes back to that one.

> @@ -5,4 +5,11 @@ Boards with the BCM4708 SoC shall have the following properties:
>  
>  Required root node property:
>  
> +bcm94709
>  compatible = "brcm,bcm4708";
> +
> +bcm94709
> +compatible = "brcm,bcm4709", "brcm,bcm4708";
> +
> +bcm953012k
> +compatible = "brcm,bcm5301k", "brcm,bcm4708";
> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Scott Branden Oct. 13, 2015, 4:58 p.m. UTC | #2
Hi Jon,

One question below.

On 15-10-10 07:42 AM, Hauke Mehrtens wrote:
> On 10/03/2015 12:22 AM, Jon Mason wrote:
>> Add the 4708, 4709, and 953012k SVKs to the the documentation for the
>> Broadcom Northstar device tree bindings.
>>
>> Signed-off-by: Jon Mason <jonmason@broadcom.com>
>> ---
>>   Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
>> index 6b0f49f..bdf4c06 100644
>> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
>> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
>
> What should be documented in this file? This is more a question to the
> guys more familiar with arm in Linux. Currently the Linux kernel only
> supports brcm,bcm4708 and all goes back to that one.
>
>> @@ -5,4 +5,11 @@ Boards with the BCM4708 SoC shall have the following properties:
>>
>>   Required root node property:
>>
>> +bcm94709
>>   compatible = "brcm,bcm4708";
>> +
>> +bcm94709
>> +compatible = "brcm,bcm4709", "brcm,bcm4708";
>> +
>> +bcm953012k
>> +compatible = "brcm,bcm5301k", "brcm,bcm4708";

Why are you adding a "k" on the string here?  bcm5301k is not an SoC 
part number?
>>
>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jon Mason Oct. 13, 2015, 9:40 p.m. UTC | #3
On Sat, Oct 10, 2015 at 04:42:04PM +0200, Hauke Mehrtens wrote:
> On 10/03/2015 12:22 AM, Jon Mason wrote:
> > Add the 4708, 4709, and 953012k SVKs to the the documentation for the
> > Broadcom Northstar device tree bindings.
> > 
> > Signed-off-by: Jon Mason <jonmason@broadcom.com>
> > ---
> >  Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
> > index 6b0f49f..bdf4c06 100644
> > --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
> > +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
> 
> What should be documented in this file? This is more a question to the
> guys more familiar with arm in Linux. Currently the Linux kernel only
> supports brcm,bcm4708 and all goes back to that one.

I was under the impression that all boards should be added to these
files.  We have been doing so for Cygnus and NSP.

Thanks,
Jon

> 
> > @@ -5,4 +5,11 @@ Boards with the BCM4708 SoC shall have the following properties:
> >  
> >  Required root node property:
> >  
> > +bcm94709
> >  compatible = "brcm,bcm4708";
> > +
> > +bcm94709
> > +compatible = "brcm,bcm4709", "brcm,bcm4708";
> > +
> > +bcm953012k
> > +compatible = "brcm,bcm5301k", "brcm,bcm4708";
> > 
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Florian Fainelli Oct. 13, 2015, 10:37 p.m. UTC | #4
On 13/10/15 14:40, Jon Mason wrote:
> On Sat, Oct 10, 2015 at 04:42:04PM +0200, Hauke Mehrtens wrote:
>> On 10/03/2015 12:22 AM, Jon Mason wrote:
>>> Add the 4708, 4709, and 953012k SVKs to the the documentation for the
>>> Broadcom Northstar device tree bindings.
>>>
>>> Signed-off-by: Jon Mason <jonmason@broadcom.com>
>>> ---
>>>  Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
>>> index 6b0f49f..bdf4c06 100644
>>> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
>>> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
>>
>> What should be documented in this file? This is more a question to the
>> guys more familiar with arm in Linux. Currently the Linux kernel only
>> supports brcm,bcm4708 and all goes back to that one.
> 
> I was under the impression that all boards should be added to these
> files.  We have been doing so for Cygnus and NSP.

Tracking exactly which boards are supported by the brcm,bcm4708
compatible string might be tedious, I tend to agree with just listing
the supported SoCs, and leaving the specific board compatibles to the
individual DTS files instead.

> 
> Thanks,
> Jon
> 
>>
>>> @@ -5,4 +5,11 @@ Boards with the BCM4708 SoC shall have the following properties:
>>>  
>>>  Required root node property:
>>>  
>>> +bcm94709
>>>  compatible = "brcm,bcm4708";
>>> +
>>> +bcm94709
>>> +compatible = "brcm,bcm4709", "brcm,bcm4708";
>>> +
>>> +bcm953012k
>>> +compatible = "brcm,bcm5301k", "brcm,bcm4708";
>>>
>>
Jon Mason Oct. 14, 2015, 3:34 p.m. UTC | #5
On Tue, Oct 13, 2015 at 03:37:49PM -0700, Florian Fainelli wrote:
> On 13/10/15 14:40, Jon Mason wrote:
> > On Sat, Oct 10, 2015 at 04:42:04PM +0200, Hauke Mehrtens wrote:
> >> On 10/03/2015 12:22 AM, Jon Mason wrote:
> >>> Add the 4708, 4709, and 953012k SVKs to the the documentation for the
> >>> Broadcom Northstar device tree bindings.
> >>>
> >>> Signed-off-by: Jon Mason <jonmason@broadcom.com>
> >>> ---
> >>>  Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt | 7 +++++++
> >>>  1 file changed, 7 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
> >>> index 6b0f49f..bdf4c06 100644
> >>> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
> >>> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
> >>
> >> What should be documented in this file? This is more a question to the
> >> guys more familiar with arm in Linux. Currently the Linux kernel only
> >> supports brcm,bcm4708 and all goes back to that one.
> > 
> > I was under the impression that all boards should be added to these
> > files.  We have been doing so for Cygnus and NSP.
> 
> Tracking exactly which boards are supported by the brcm,bcm4708
> compatible string might be tedious, I tend to agree with just listing
> the supported SoCs, and leaving the specific board compatibles to the
> individual DTS files instead.

Ok, I'll simply add entries for NS and 4709 to this.

Thanks,
Jon 

> 
> > 
> > Thanks,
> > Jon
> > 
> >>
> >>> @@ -5,4 +5,11 @@ Boards with the BCM4708 SoC shall have the following properties:
> >>>  
> >>>  Required root node property:
> >>>  
> >>> +bcm94709
> >>>  compatible = "brcm,bcm4708";
> >>> +
> >>> +bcm94709
> >>> +compatible = "brcm,bcm4709", "brcm,bcm4708";
> >>> +
> >>> +bcm953012k
> >>> +compatible = "brcm,bcm5301k", "brcm,bcm4708";
> >>>
> >>
> 
> 
> -- 
> Florian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Scott Branden Oct. 14, 2015, 7:44 p.m. UTC | #6
Hi Jon,

Yes, please only add SoC part number compatible strings, not board 
compatible strings.

On 15-10-14 08:34 AM, Jon Mason wrote:
> On Tue, Oct 13, 2015 at 03:37:49PM -0700, Florian Fainelli wrote:
>> On 13/10/15 14:40, Jon Mason wrote:
>>> On Sat, Oct 10, 2015 at 04:42:04PM +0200, Hauke Mehrtens wrote:
>>>> On 10/03/2015 12:22 AM, Jon Mason wrote:
>>>>> Add the 4708, 4709, and 953012k SVKs to the the documentation for the
>>>>> Broadcom Northstar device tree bindings.
>>>>>
>>>>> Signed-off-by: Jon Mason <jonmason@broadcom.com>
>>>>> ---
>>>>>   Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt | 7 +++++++
>>>>>   1 file changed, 7 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
>>>>> index 6b0f49f..bdf4c06 100644
>>>>> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
>>>>> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
>>>>
>>>> What should be documented in this file? This is more a question to the
>>>> guys more familiar with arm in Linux. Currently the Linux kernel only
>>>> supports brcm,bcm4708 and all goes back to that one.
>>>
>>> I was under the impression that all boards should be added to these
>>> files.  We have been doing so for Cygnus and NSP.
>>
>> Tracking exactly which boards are supported by the brcm,bcm4708
>> compatible string might be tedious, I tend to agree with just listing
>> the supported SoCs, and leaving the specific board compatibles to the
>> individual DTS files instead.
>
> Ok, I'll simply add entries for NS and 4709 to this.
Good - we have only been adding SoC compatible strings for Cygnus and 
NSP - not board compatibles.

>
> Thanks,
> Jon
>
>>
>>>
>>> Thanks,
>>> Jon
>>>
>>>>
>>>>> @@ -5,4 +5,11 @@ Boards with the BCM4708 SoC shall have the following properties:
>>>>>
>>>>>   Required root node property:
>>>>>
>>>>> +bcm94709
>>>>>   compatible = "brcm,bcm4708";
>>>>> +
>>>>> +bcm94709
>>>>> +compatible = "brcm,bcm4709", "brcm,bcm4708";
>>>>> +
>>>>> +bcm953012k
>>>>> +compatible = "brcm,bcm5301k", "brcm,bcm4708";
>>>>>
>>>>
>>
>>
>> --
>> Florian

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
index 6b0f49f..bdf4c06 100644
--- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
+++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
@@ -5,4 +5,11 @@  Boards with the BCM4708 SoC shall have the following properties:
 
 Required root node property:
 
+bcm94709
 compatible = "brcm,bcm4708";
+
+bcm94709
+compatible = "brcm,bcm4709", "brcm,bcm4708";
+
+bcm953012k
+compatible = "brcm,bcm5301k", "brcm,bcm4708";