diff mbox

Documentation: arm: Fix typo in the idle-states bindings examples

Message ID 1443106436-542-1-git-send-email-lorenzo.pieralisi@arm.com
State Accepted, archived
Commit a13f18f59d2646754cda3662a9e215ff43e7a7d5
Headers show

Commit Message

Lorenzo Pieralisi Sept. 24, 2015, 2:53 p.m. UTC
The idle-states bindings mandate that the entry-method string
in the idle-states node must be "psci" for ARM v8 64-bit systems,
but the examples in the bindings report a wrong entry-method string.
Owing to this typo, some dts in the kernel wrongly defined the
entry-method property, since they likely cut and pasted the example
definition without paying attention to the bindings definitions.

This patch fixes the typo in the DT idle states bindings examples and
respective dts in the kernel so that the bindings and related dts
files are made compliant.

Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Howard Chen <howard.chen@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Heiko Stuebner <heiko@sntech.de>
---
 Documentation/devicetree/bindings/arm/idle-states.txt | 2 +-
 arch/arm64/boot/dts/mediatek/mt8173.dtsi              | 2 +-
 arch/arm64/boot/dts/rockchip/rk3368.dtsi              | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

Rob Herring Sept. 25, 2015, 6:32 p.m. UTC | #1
On Thu, Sep 24, 2015 at 9:53 AM, Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
> The idle-states bindings mandate that the entry-method string
> in the idle-states node must be "psci" for ARM v8 64-bit systems,
> but the examples in the bindings report a wrong entry-method string.
> Owing to this typo, some dts in the kernel wrongly defined the
> entry-method property, since they likely cut and pasted the example
> definition without paying attention to the bindings definitions.
>
> This patch fixes the typo in the DT idle states bindings examples and
> respective dts in the kernel so that the bindings and related dts
> files are made compliant.
>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Howard Chen <howard.chen@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Heiko Stuebner <heiko@sntech.de>

Applied. Thanks.

Rob

> ---
>  Documentation/devicetree/bindings/arm/idle-states.txt | 2 +-
>  arch/arm64/boot/dts/mediatek/mt8173.dtsi              | 2 +-
>  arch/arm64/boot/dts/rockchip/rk3368.dtsi              | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/idle-states.txt b/Documentation/devicetree/bindings/arm/idle-states.txt
> index a8274ea..b8e41c1 100644
> --- a/Documentation/devicetree/bindings/arm/idle-states.txt
> +++ b/Documentation/devicetree/bindings/arm/idle-states.txt
> @@ -497,7 +497,7 @@ cpus {
>         };
>
>         idle-states {
> -               entry-method = "arm,psci";
> +               entry-method = "psci";
>
>                 CPU_RETENTION_0_0: cpu-retention-0-0 {
>                         compatible = "arm,idle-state";
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index d18ee42..06a1564 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -81,7 +81,7 @@
>                 };
>
>                 idle-states {
> -                       entry-method = "arm,psci";
> +                       entry-method = "psci";
>
>                         CPU_SLEEP_0: cpu-sleep-0 {
>                                 compatible = "arm,idle-state";
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> index a712bea..cc093a4 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> @@ -106,7 +106,7 @@
>                 };
>
>                 idle-states {
> -                       entry-method = "arm,psci";
> +                       entry-method = "psci";
>
>                         cpu_sleep: cpu-sleep-0 {
>                                 compatible = "arm,idle-state";
> --
> 2.5.1
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/arm/idle-states.txt b/Documentation/devicetree/bindings/arm/idle-states.txt
index a8274ea..b8e41c1 100644
--- a/Documentation/devicetree/bindings/arm/idle-states.txt
+++ b/Documentation/devicetree/bindings/arm/idle-states.txt
@@ -497,7 +497,7 @@  cpus {
 	};
 
 	idle-states {
-		entry-method = "arm,psci";
+		entry-method = "psci";
 
 		CPU_RETENTION_0_0: cpu-retention-0-0 {
 			compatible = "arm,idle-state";
diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
index d18ee42..06a1564 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
@@ -81,7 +81,7 @@ 
 		};
 
 		idle-states {
-			entry-method = "arm,psci";
+			entry-method = "psci";
 
 			CPU_SLEEP_0: cpu-sleep-0 {
 				compatible = "arm,idle-state";
diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
index a712bea..cc093a4 100644
--- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
@@ -106,7 +106,7 @@ 
 		};
 
 		idle-states {
-			entry-method = "arm,psci";
+			entry-method = "psci";
 
 			cpu_sleep: cpu-sleep-0 {
 				compatible = "arm,idle-state";