| Message ID | 1442840245-7982-1-git-send-email-javier@osg.samsung.com |
|---|---|
| State | Accepted, archived |
| Commit | e7ae65ced7dd71aa3dc29bda7a94ac82d9ea7751 |
| Headers | show |
On Mon, Sep 21, 2015 at 7:57 AM, Javier Martinez Canillas <javier@osg.samsung.com> wrote: > The gpiolib supports parsing DT properties of the form <name>-gpio but it > was only added for compatibility with older DT bindings that got it wrong > and should not be used in newer bindings. > > The commit that added support for this was: > > dd34c37aa3e8 ("gpio: of: Allow -gpio suffix for property names") > > but didn't update the documentation to explain this so it's been a source > of confusion. So let's make this clear in the GPIO DT binding doc. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Applied. Thanks. Rob > > --- > > Changes in v2: > - Explain that <name>-gpio is deprecated instead of saying that is > supported. Suggested by Alexandre Courbot. > > Documentation/devicetree/bindings/gpio/gpio.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt b/Documentation/devicetree/bindings/gpio/gpio.txt > index 5788d5cf1252..82d40e2505f6 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio.txt > +++ b/Documentation/devicetree/bindings/gpio/gpio.txt > @@ -16,7 +16,9 @@ properties, each containing a 'gpio-list': > GPIO properties should be named "[<name>-]gpios", with <name> being the purpose > of this GPIO for the device. While a non-existent <name> is considered valid > for compatibility reasons (resolving to the "gpios" property), it is not allowed > -for new bindings. > +for new bindings. Also, GPIO properties named "[<name>-]gpio" are valid and old > +bindings use it, but are only supported for compatibility reasons and should not > +be used for newer bindings since it has been deprecated. > > GPIO properties can contain one or more GPIO phandles, but only in exceptional > cases should they contain more than one. If your device uses several GPIOs with > -- > 2.4.3 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt b/Documentation/devicetree/bindings/gpio/gpio.txt index 5788d5cf1252..82d40e2505f6 100644 --- a/Documentation/devicetree/bindings/gpio/gpio.txt +++ b/Documentation/devicetree/bindings/gpio/gpio.txt @@ -16,7 +16,9 @@ properties, each containing a 'gpio-list': GPIO properties should be named "[<name>-]gpios", with <name> being the purpose of this GPIO for the device. While a non-existent <name> is considered valid for compatibility reasons (resolving to the "gpios" property), it is not allowed -for new bindings. +for new bindings. Also, GPIO properties named "[<name>-]gpio" are valid and old +bindings use it, but are only supported for compatibility reasons and should not +be used for newer bindings since it has been deprecated. GPIO properties can contain one or more GPIO phandles, but only in exceptional cases should they contain more than one. If your device uses several GPIOs with
The gpiolib supports parsing DT properties of the form <name>-gpio but it was only added for compatibility with older DT bindings that got it wrong and should not be used in newer bindings. The commit that added support for this was: dd34c37aa3e8 ("gpio: of: Allow -gpio suffix for property names") but didn't update the documentation to explain this so it's been a source of confusion. So let's make this clear in the GPIO DT binding doc. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- Changes in v2: - Explain that <name>-gpio is deprecated instead of saying that is supported. Suggested by Alexandre Courbot. Documentation/devicetree/bindings/gpio/gpio.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)