diff mbox

[1/2] dt-bindings: drm/bridge: Add IT6151 bridge chip driver bindings.

Message ID 1426054733-54378-1-git-send-email-ck.hu@mediatek.com
State New, archived
Headers show

Commit Message

CK Hu March 11, 2015, 6:18 a.m. UTC
Add devicetree bindings for IT6151 MIPI to eDP bridge chip driver.

Signed-off-by: CK Hu <ck.hu@mediatek.com>
Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
---
 Documentation/devicetree/bindings/drm/bridge/it6151.txt | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/drm/bridge/it6151.txt

Comments

Paul Bolle March 12, 2015, 9 a.m. UTC | #1
Just a few nits, I'm afraid.

On Wed, 2015-03-11 at 14:18 +0800, CK Hu wrote:
>  drivers/gpu/drm/bridge/Kconfig  |  10 +
>  drivers/gpu/drm/bridge/Makefile |   1 +

I applied 1/2 and 2/2 on top of next-20150312 to check a trivial issue.
The chunks for these two files needed context changes to git this patch
applied.

>  drivers/gpu/drm/bridge/it6151.c | 601 ++++++++++++++++++++++++++++++++++++++++
>  include/drm/bridge/it6151.h     |  34 +++
>  4 files changed, 646 insertions(+)
>  create mode 100644 drivers/gpu/drm/bridge/it6151.c
>  create mode 100644 include/drm/bridge/it6151.h

> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index f38bbcd..2b3a78e 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -11,3 +11,13 @@ config DRM_PTN3460
>  	select DRM_PANEL
>  	---help---
>  	  ptn3460 eDP-LVDS bridge chip driver.
> +
> +config DRM_IT6151
> +	bool "Enable IT6151FN : MIPI to eDP Converter"
> +	depends on DRM
> +	select DRM_KMS_HELPER
> +	help
> +	  Choose this option if you have IT6151 for display
> +	  The IT6151 is a high-performance and low-power
> +	  MIPI to eDP converter
> +

(This empty line makes git am whine: "new blank line at EOF.".)

> --- /dev/null
> +++ b/drivers/gpu/drm/bridge/it6151.c

> +#include <linux/module.h>

This file can only be built-in. So I couldn't help but notice this
include. And if I remove it
    make drivers/gpu/drm/bridge/it6151.o

still runs without warning or errors. Unless I've missed something
non-obvious I'd say it is not needed.

> +

(Empty line at end of file.)

> --- /dev/null
> +++ b/include/drm/bridge/it6151.h

> +

(Another empty line at end of file.)


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Heiko Stübner March 12, 2015, 10:24 a.m. UTC | #2
Am Donnerstag, 12. März 2015, 10:00:47 schrieb Paul Bolle:
> > --- /dev/null
> > +++ b/drivers/gpu/drm/bridge/it6151.c
> > 
> > +#include <linux/module.h>
> 
> This file can only be built-in. So I couldn't help but notice this
> include. And if I remove it
>     make drivers/gpu/drm/bridge/it6151.o
> 
> still runs without warning or errors. Unless I've missed something
> non-obvious I'd say it is not needed.

I think the more interesting question would be, why can it only be built in 
:-) .

The drm/bridge series from Ajay Kumar [0] made it into 4.0-rc that enables 
drm-bridges to be regular platform/i2c devices, see [1] for example.

So I think any new bridge driver should use this approach and can thus also be 
build as module.


Heiko


[0] http://www.spinics.net/lists/linux-samsung-soc/msg41403.html
[1] http://www.spinics.net/lists/linux-samsung-soc/msg41406.html

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Matthias Brugger March 12, 2015, 10:35 a.m. UTC | #3
2015-03-11 7:18 GMT+01:00 CK Hu <ck.hu@mediatek.com>:
> Add devicetree bindings for IT6151 MIPI to eDP bridge chip driver.
>
> Signed-off-by: CK Hu <ck.hu@mediatek.com>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>

Please use scripts/get_maintainer.pl for all people to which send the
next version of the patch set.

Thanks,
Matthias

> ---
>  Documentation/devicetree/bindings/drm/bridge/it6151.txt | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/drm/bridge/it6151.txt
>
> diff --git a/Documentation/devicetree/bindings/drm/bridge/it6151.txt b/Documentation/devicetree/bindings/drm/bridge/it6151.txt
> new file mode 100644
> index 0000000..ad0ad60
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/drm/bridge/it6151.txt
> @@ -0,0 +1,15 @@
> +it6151 bridge bindings
> +
> +Required properties:
> +       - compatible: "ite,it6151"
> +       - reg: i2c address of the bridge's dp tx.
> +       - rxreg: i2c address of the bridge's mipi rx.
> +       - reset-gpio: OF device-tree gpio specification
> +
> +Example:
> +       ite6151: edp-bridge@5c {
> +               compatible = "ite,it6151";
> +               reg = <0x5c>;
> +               rxreg = <0x6c>;
> +               reset-gpio = <&pio 94 GPIO_ACTIVE_HIGH>;
> +       };
> --
> 1.8.1.1.dirty
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/drm/bridge/it6151.txt b/Documentation/devicetree/bindings/drm/bridge/it6151.txt
new file mode 100644
index 0000000..ad0ad60
--- /dev/null
+++ b/Documentation/devicetree/bindings/drm/bridge/it6151.txt
@@ -0,0 +1,15 @@ 
+it6151 bridge bindings
+
+Required properties:
+	- compatible: "ite,it6151"
+	- reg: i2c address of the bridge's dp tx.
+	- rxreg: i2c address of the bridge's mipi rx.
+	- reset-gpio: OF device-tree gpio specification
+
+Example:
+	ite6151: edp-bridge@5c {
+		compatible = "ite,it6151";
+		reg = <0x5c>;
+		rxreg = <0x6c>;
+		reset-gpio = <&pio 94 GPIO_ACTIVE_HIGH>;
+	};