| Message ID | 1425329684-23968-5-git-send-email-eric@anholt.net |
|---|---|
| State | Needs Review / ACK, archived |
| Headers | show |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 1 errors, 0 warnings, 0 lines checked |
| robh/patch-applied | success |
On 03/02/2015 01:54 PM, Eric Anholt wrote: > I was tempted to have the mailbox power channel support just be in the > 2835 mailbox driver itself, but mbox_request_channel() wants its > device to have the "mboxes" node, and that appears to be only intended > for mailbox clients, not controllers. > diff --git a/Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox-power.txt b/Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox-power.txt > +Broadcom BCM2835 VideoCore mailbox power channel IPC > + > +Required properties: > + > +- compatible : Should be "brcm,bcm2835-mbox-power" > +- mboxes: Single-entry list which specifies which mailbox controller > + and channel is the power channel. > + > +Example: > + > +mailbox-power { > + compatible = "brcm,bcm2835-mbox-power"; > + mboxes = <&mailbox 0> > +}; I think the driver for this device should provide its services to other drivers using some standard in-kernel API (power domains, regulators?), which in turn would presumably have some subsystem-level DT binding. So, I would expect this DT node to implement the server-side of that binding, and probably have a property like "#power-domain-cells = <1>", and the client nodes to "consume" this service via a property like "power-domain = <&mbox_power N>" where N is the ID of the client's power domain within the firmware protocol. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox-power.txt b/Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox-power.txt new file mode 100644 index 0000000..83446ce --- /dev/null +++ b/Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox-power.txt @@ -0,0 +1,14 @@ +Broadcom BCM2835 VideoCore mailbox power channel IPC + +Required properties: + +- compatible : Should be "brcm,bcm2835-mbox-power" +- mboxes: Single-entry list which specifies which mailbox controller + and channel is the power channel. + +Example: + +mailbox-power { + compatible = "brcm,bcm2835-mbox-power"; + mboxes = <&mailbox 0> +};
I was tempted to have the mailbox power channel support just be in the 2835 mailbox driver itself, but mbox_request_channel() wants its device to have the "mboxes" node, and that appears to be only intended for mailbox clients, not controllers. Signed-off-by: Eric Anholt <eric@anholt.net> --- .../bindings/mailbox/brcm,bcm2835-mbox-power.txt | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox-power.txt