Message ID | 1421620945-25502-1-git-send-email-paul.burton@imgtec.com |
---|---|
State | Needs Review / ACK, archived |
Headers | show |
Context | Check | Description |
---|---|---|
robh/checkpatch | warning | total: 1 errors, 0 warnings, 0 lines checked |
robh/patch-applied | success |
On 1/19/2015 1:42 AM, Paul Burton wrote: > Add binding documentation for the Ingenic jz4780 interrupt controller. > Signed-off-by: Paul Burton <paul.burton@imgtec.com> > Cc: Lars-Peter Clausen <lars@metafoo.de> > Cc: devicetree@vger.kernel.org > --- > .../interrupt-controller/ingenic,jz4780-intc.txt | 24 ++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/ingenic,jz4780-intc.txt > diff --git a/Documentation/devicetree/bindings/interrupt-controller/ingenic,jz4780-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/ingenic,jz4780-intc.txt > new file mode 100644 > index 0000000..c6164d9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/ingenic,jz4780-intc.txt > @@ -0,0 +1,24 @@ > +Ingenic jz4780 SoC Interrupt Controller > + > +Required properties: > + > +- compatible : should be "ingenic,jz4780-intc" > +- reg : Specifies base physical address and size of the registers. > +- interrupt-controller : Identifies the node as an interrupt controller > +- #interrupt-cells : Specifies the number of cells needed to encode an > + interrupt source. The value shall be 1. > +- interrupt-parent: phandle of the CPU interrupt controller. This is never a required prop, it can be inherited from an upper level node. > +- interrupts - Specifies the CPU interrupt the controller is connected to. > + > +Example: > + > +intc: intc@10001000 { Again, should be "interrupt-controller@10001000". WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/18/2015 11:42 PM, Paul Burton wrote: [...] > +Ingenic jz4780 SoC Interrupt Controller > + > +Required properties: > + > +- compatible : should be "ingenic,jz4780-intc" I don't think we need a second binding specification. Just add the compatibility string to the existing jz4740-intc specification. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/interrupt-controller/ingenic,jz4780-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/ingenic,jz4780-intc.txt new file mode 100644 index 0000000..c6164d9 --- /dev/null +++ b/Documentation/devicetree/bindings/interrupt-controller/ingenic,jz4780-intc.txt @@ -0,0 +1,24 @@ +Ingenic jz4780 SoC Interrupt Controller + +Required properties: + +- compatible : should be "ingenic,jz4780-intc" +- reg : Specifies base physical address and size of the registers. +- interrupt-controller : Identifies the node as an interrupt controller +- #interrupt-cells : Specifies the number of cells needed to encode an + interrupt source. The value shall be 1. +- interrupt-parent: phandle of the CPU interrupt controller. +- interrupts - Specifies the CPU interrupt the controller is connected to. + +Example: + +intc: intc@10001000 { + compatible = "ingenic,jz4780-intc"; + reg = <0x10001000 0x50>; + + interrupt-controller; + #interrupt-cells = <1>; + + interrupt-parent = <&cpuintc>; + interrupts = <2>; +};
Add binding documentation for the Ingenic jz4780 interrupt controller. Signed-off-by: Paul Burton <paul.burton@imgtec.com> Cc: Lars-Peter Clausen <lars@metafoo.de> Cc: devicetree@vger.kernel.org --- .../interrupt-controller/ingenic,jz4780-intc.txt | 24 ++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/ingenic,jz4780-intc.txt