Message ID | 1417565531-4507-8-git-send-email-stefan@agner.ch |
---|---|
State | Needs Review / ACK, archived |
Headers | show |
Context | Check | Description |
---|---|---|
robh/checkpatch | warning | total: 1 errors, 0 warnings, 0 lines checked |
robh/patch-applied | success |
On Wednesday 03 December 2014 01:12:06 Stefan Agner wrote: > +Freescale Vybrid Miscellaneous System Control Module > + > +The MSCM IP contains Access Control and TrustZone Security hardware, > +CPU Configuration registers and Interrupt Router control. > + > +Required properties: > +- compatible : "fsl,vf610-mscm" > +- reg : the register range of the MSCM module > + > +Example: > + mscm: mscm@40001000 { > + compatible = "fsl,vf610-mscm"; > + reg = <0x40001000 0x1000>; > + }; This sounds like one of those generic system controller devices. Should this be marked as syscon an accessed through syscon_regmap_lookup_by_phandle()? If you only eve have one driver touching these registers, that won't be necessary of course. arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2014-12-03 11:52, Arnd Bergmann wrote: > On Wednesday 03 December 2014 01:12:06 Stefan Agner wrote: >> +Freescale Vybrid Miscellaneous System Control Module >> + >> +The MSCM IP contains Access Control and TrustZone Security hardware, >> +CPU Configuration registers and Interrupt Router control. >> + >> +Required properties: >> +- compatible : "fsl,vf610-mscm" >> +- reg : the register range of the MSCM module >> + >> +Example: >> + mscm: mscm@40001000 { >> + compatible = "fsl,vf610-mscm"; >> + reg = <0x40001000 0x1000>; >> + }; > > This sounds like one of those generic system controller devices. > Should this be marked as syscon an accessed through > syscon_regmap_lookup_by_phandle()? > > If you only eve have one driver touching these registers, that > won't be necessary of course. > So far, in upstream code the module is not used at all (other than in U-Boot setting up the interrupt router in a static manner). I think it is not that "miscellaneous" as it sounds, it mainly controls and provides information regarding the dual-core stuff, for instance provide interrupt flags for the CPU-to-CPU interrupts or exports CPU information (beside the interrupt routing thing). I don't know (yet) if and how we want export support for that interrupt. We would certainly need it to support some message based framework (Freescale used it for their out-of-tree MCC (multi-core communication) stuff, probably we would need it to implement rpmsg support...). -- Stefan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,vf610-mscm.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,vf610-mscm.txt new file mode 100644 index 0000000..31c58cc --- /dev/null +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,vf610-mscm.txt @@ -0,0 +1,14 @@ +Freescale Vybrid Miscellaneous System Control Module + +The MSCM IP contains Access Control and TrustZone Security hardware, +CPU Configuration registers and Interrupt Router control. + +Required properties: +- compatible : "fsl,vf610-mscm" +- reg : the register range of the MSCM module + +Example: + mscm: mscm@40001000 { + compatible = "fsl,vf610-mscm"; + reg = <0x40001000 0x1000>; + };
Add documentation for Miscellaneous System Control Module found in Freescale Vybrid SoCs. Signed-off-by: Stefan Agner <stefan@agner.ch> --- .../devicetree/bindings/arm/freescale/fsl,vf610-mscm.txt | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/freescale/fsl,vf610-mscm.txt