diff mbox

[v2] PCI: add missing DT binding for linux,pci-domain property

Message ID 1415287400-30426-1-git-send-email-l.stach@pengutronix.de
State New, archived
Headers show

Commit Message

Lucas Stach Nov. 6, 2014, 3:23 p.m. UTC
This property was added by 41e5c0f81d3e
(of/pci: Add pci_get_new_domain_nr() and of_get_pci_domain_nr())
without the required binding documentation. As this property
will be supported by a number of host bridge drivers going forward,
add it to the common PCI binding doc.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
This is a non-critical fix, but may still qualify for 3.18-rc as
the property was added in this release cycle.

v2:
- emphasize that the property must be present and unique systemwide
  if used
---
 Documentation/devicetree/bindings/pci/pci.txt | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Liviu Dudau Nov. 6, 2014, 3:40 p.m. UTC | #1
On Thu, Nov 06, 2014 at 03:23:20PM +0000, Lucas Stach wrote:
> This property was added by 41e5c0f81d3e
> (of/pci: Add pci_get_new_domain_nr() and of_get_pci_domain_nr())
> without the required binding documentation. As this property
> will be supported by a number of host bridge drivers going forward,
> add it to the common PCI binding doc.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> This is a non-critical fix, but may still qualify for 3.18-rc as
> the property was added in this release cycle.
> 
> v2:
> - emphasize that the property must be present and unique systemwide
>   if used
> ---
>  Documentation/devicetree/bindings/pci/pci.txt | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/pci.txt b/Documentation/devicetree/bindings/pci/pci.txt
> index 41aeed38926d..68c364e2f5e5 100644
> --- a/Documentation/devicetree/bindings/pci/pci.txt
> +++ b/Documentation/devicetree/bindings/pci/pci.txt
> @@ -7,3 +7,14 @@ And for the interrupt mapping part:
>  
>  Open Firmware Recommended Practice: Interrupt Mapping
>  http://www.openfirmware.org/1275/practice/imap/imap0_9d.pdf
> +
> +Additionally to the properties specified in the above standards a host bridge
> +driver implementation may support the following properties:
> +
> +- linux,pci-domain:
> +   If present this property assigns a fixed PCI domain number to a host bridge,
> +   otherwise an unstable (across boots) unique number will be assigned.
> +   It is required to either not set this property at all or set it for all
> +   host bridges in the system, otherwise potentially conflicting domain numbers
> +   may be assigned to root buses behind different host bridges. The domain
> +   number for each host bridge in the system must be unique.
> -- 
> 2.1.1
> 
> 

Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>

Liviu
Rob Herring Nov. 6, 2014, 7:49 p.m. UTC | #2
On Thu, Nov 6, 2014 at 9:23 AM, Lucas Stach <l.stach@pengutronix.de> wrote:
> This property was added by 41e5c0f81d3e
> (of/pci: Add pci_get_new_domain_nr() and of_get_pci_domain_nr())
> without the required binding documentation. As this property
> will be supported by a number of host bridge drivers going forward,
> add it to the common PCI binding doc.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> This is a non-critical fix, but may still qualify for 3.18-rc as
> the property was added in this release cycle.

Agreed.

Acked-by: Rob Herring <robh@kernel.org>

>
> v2:
> - emphasize that the property must be present and unique systemwide
>   if used
> ---
>  Documentation/devicetree/bindings/pci/pci.txt | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/pci.txt b/Documentation/devicetree/bindings/pci/pci.txt
> index 41aeed38926d..68c364e2f5e5 100644
> --- a/Documentation/devicetree/bindings/pci/pci.txt
> +++ b/Documentation/devicetree/bindings/pci/pci.txt
> @@ -7,3 +7,14 @@ And for the interrupt mapping part:
>
>  Open Firmware Recommended Practice: Interrupt Mapping
>  http://www.openfirmware.org/1275/practice/imap/imap0_9d.pdf
> +
> +Additionally to the properties specified in the above standards a host bridge
> +driver implementation may support the following properties:
> +
> +- linux,pci-domain:
> +   If present this property assigns a fixed PCI domain number to a host bridge,
> +   otherwise an unstable (across boots) unique number will be assigned.
> +   It is required to either not set this property at all or set it for all
> +   host bridges in the system, otherwise potentially conflicting domain numbers
> +   may be assigned to root buses behind different host bridges. The domain
> +   number for each host bridge in the system must be unique.
> --
> 2.1.1
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Lucas Stach Nov. 10, 2014, 2:58 p.m. UTC | #3
Am Donnerstag, den 06.11.2014, 13:49 -0600 schrieb Rob Herring:
> On Thu, Nov 6, 2014 at 9:23 AM, Lucas Stach <l.stach@pengutronix.de> wrote:
> > This property was added by 41e5c0f81d3e
> > (of/pci: Add pci_get_new_domain_nr() and of_get_pci_domain_nr())
> > without the required binding documentation. As this property
> > will be supported by a number of host bridge drivers going forward,
> > add it to the common PCI binding doc.
> >
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> > This is a non-critical fix, but may still qualify for 3.18-rc as
> > the property was added in this release cycle.
> 
> Agreed.
> 
> Acked-by: Rob Herring <robh@kernel.org>
> 

So how should we proceed here? Are you going to pick it up or should
Bjorn route this through the PCI tree?

> >
> > v2:
> > - emphasize that the property must be present and unique systemwide
> >   if used
> > ---
> >  Documentation/devicetree/bindings/pci/pci.txt | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/pci.txt b/Documentation/devicetree/bindings/pci/pci.txt
> > index 41aeed38926d..68c364e2f5e5 100644
> > --- a/Documentation/devicetree/bindings/pci/pci.txt
> > +++ b/Documentation/devicetree/bindings/pci/pci.txt
> > @@ -7,3 +7,14 @@ And for the interrupt mapping part:
> >
> >  Open Firmware Recommended Practice: Interrupt Mapping
> >  http://www.openfirmware.org/1275/practice/imap/imap0_9d.pdf
> > +
> > +Additionally to the properties specified in the above standards a host bridge
> > +driver implementation may support the following properties:
> > +
> > +- linux,pci-domain:
> > +   If present this property assigns a fixed PCI domain number to a host bridge,
> > +   otherwise an unstable (across boots) unique number will be assigned.
> > +   It is required to either not set this property at all or set it for all
> > +   host bridges in the system, otherwise potentially conflicting domain numbers
> > +   may be assigned to root buses behind different host bridges. The domain
> > +   number for each host bridge in the system must be unique.
> > --
> > 2.1.1
> >
Rob Herring Nov. 13, 2014, 4:04 p.m. UTC | #4
On Mon, Nov 10, 2014 at 8:58 AM, Lucas Stach <l.stach@pengutronix.de> wrote:
> Am Donnerstag, den 06.11.2014, 13:49 -0600 schrieb Rob Herring:
>> On Thu, Nov 6, 2014 at 9:23 AM, Lucas Stach <l.stach@pengutronix.de> wrote:
>> > This property was added by 41e5c0f81d3e
>> > (of/pci: Add pci_get_new_domain_nr() and of_get_pci_domain_nr())
>> > without the required binding documentation. As this property
>> > will be supported by a number of host bridge drivers going forward,
>> > add it to the common PCI binding doc.
>> >
>> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
>> > ---
>> > This is a non-critical fix, but may still qualify for 3.18-rc as
>> > the property was added in this release cycle.
>>
>> Agreed.
>>
>> Acked-by: Rob Herring <robh@kernel.org>
>>
>
> So how should we proceed here? Are you going to pick it up or should
> Bjorn route this through the PCI tree?

I believe Bjorn said he would pick this up since he merged the rest.

Rob

>
>> >
>> > v2:
>> > - emphasize that the property must be present and unique systemwide
>> >   if used
>> > ---
>> >  Documentation/devicetree/bindings/pci/pci.txt | 11 +++++++++++
>> >  1 file changed, 11 insertions(+)
>> >
>> > diff --git a/Documentation/devicetree/bindings/pci/pci.txt b/Documentation/devicetree/bindings/pci/pci.txt
>> > index 41aeed38926d..68c364e2f5e5 100644
>> > --- a/Documentation/devicetree/bindings/pci/pci.txt
>> > +++ b/Documentation/devicetree/bindings/pci/pci.txt
>> > @@ -7,3 +7,14 @@ And for the interrupt mapping part:
>> >
>> >  Open Firmware Recommended Practice: Interrupt Mapping
>> >  http://www.openfirmware.org/1275/practice/imap/imap0_9d.pdf
>> > +
>> > +Additionally to the properties specified in the above standards a host bridge
>> > +driver implementation may support the following properties:
>> > +
>> > +- linux,pci-domain:
>> > +   If present this property assigns a fixed PCI domain number to a host bridge,
>> > +   otherwise an unstable (across boots) unique number will be assigned.
>> > +   It is required to either not set this property at all or set it for all
>> > +   host bridges in the system, otherwise potentially conflicting domain numbers
>> > +   may be assigned to root buses behind different host bridges. The domain
>> > +   number for each host bridge in the system must be unique.
>> > --
>> > 2.1.1
>> >
>
> --
> Pengutronix e.K.             | Lucas Stach                 |
> Industrial Linux Solutions   | http://www.pengutronix.de/  |
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Bjorn Helgaas Nov. 13, 2014, 5:09 p.m. UTC | #5
On Thu, Nov 06, 2014 at 04:23:20PM +0100, Lucas Stach wrote:
> This property was added by 41e5c0f81d3e
> (of/pci: Add pci_get_new_domain_nr() and of_get_pci_domain_nr())
> without the required binding documentation. As this property
> will be supported by a number of host bridge drivers going forward,
> add it to the common PCI binding doc.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

Applied with acks from Liviu and Rob to for-linus for v3.18, thanks a lot
for working this out!

> ---
> This is a non-critical fix, but may still qualify for 3.18-rc as
> the property was added in this release cycle.
> 
> v2:
> - emphasize that the property must be present and unique systemwide
>   if used
> ---
>  Documentation/devicetree/bindings/pci/pci.txt | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/pci.txt b/Documentation/devicetree/bindings/pci/pci.txt
> index 41aeed38926d..68c364e2f5e5 100644
> --- a/Documentation/devicetree/bindings/pci/pci.txt
> +++ b/Documentation/devicetree/bindings/pci/pci.txt
> @@ -7,3 +7,14 @@ And for the interrupt mapping part:
>  
>  Open Firmware Recommended Practice: Interrupt Mapping
>  http://www.openfirmware.org/1275/practice/imap/imap0_9d.pdf
> +
> +Additionally to the properties specified in the above standards a host bridge
> +driver implementation may support the following properties:
> +
> +- linux,pci-domain:
> +   If present this property assigns a fixed PCI domain number to a host bridge,
> +   otherwise an unstable (across boots) unique number will be assigned.
> +   It is required to either not set this property at all or set it for all
> +   host bridges in the system, otherwise potentially conflicting domain numbers
> +   may be assigned to root buses behind different host bridges. The domain
> +   number for each host bridge in the system must be unique.
> -- 
> 2.1.1
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Bjorn Helgaas Nov. 13, 2014, 5:34 p.m. UTC | #6
On Thu, Nov 13, 2014 at 10:09:21AM -0700, Bjorn Helgaas wrote:
> On Thu, Nov 06, 2014 at 04:23:20PM +0100, Lucas Stach wrote:
> > This property was added by 41e5c0f81d3e
> > (of/pci: Add pci_get_new_domain_nr() and of_get_pci_domain_nr())
> > without the required binding documentation. As this property
> > will be supported by a number of host bridge drivers going forward,
> > add it to the common PCI binding doc.
> > 
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> 
> Applied with acks from Liviu and Rob to for-linus for v3.18, thanks a lot
> for working this out!

Arnd, I just noticed your concern about this being linux-only.  Are you
happy with this one?  If not, I can drop this.

> > ---
> > This is a non-critical fix, but may still qualify for 3.18-rc as
> > the property was added in this release cycle.
> > 
> > v2:
> > - emphasize that the property must be present and unique systemwide
> >   if used
> > ---
> >  Documentation/devicetree/bindings/pci/pci.txt | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/pci/pci.txt b/Documentation/devicetree/bindings/pci/pci.txt
> > index 41aeed38926d..68c364e2f5e5 100644
> > --- a/Documentation/devicetree/bindings/pci/pci.txt
> > +++ b/Documentation/devicetree/bindings/pci/pci.txt
> > @@ -7,3 +7,14 @@ And for the interrupt mapping part:
> >  
> >  Open Firmware Recommended Practice: Interrupt Mapping
> >  http://www.openfirmware.org/1275/practice/imap/imap0_9d.pdf
> > +
> > +Additionally to the properties specified in the above standards a host bridge
> > +driver implementation may support the following properties:
> > +
> > +- linux,pci-domain:
> > +   If present this property assigns a fixed PCI domain number to a host bridge,
> > +   otherwise an unstable (across boots) unique number will be assigned.
> > +   It is required to either not set this property at all or set it for all
> > +   host bridges in the system, otherwise potentially conflicting domain numbers
> > +   may be assigned to root buses behind different host bridges. The domain
> > +   number for each host bridge in the system must be unique.
> > -- 
> > 2.1.1
> > 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Arnd Bergmann Nov. 13, 2014, 6:16 p.m. UTC | #7
On Thursday 13 November 2014 10:34:04 Bjorn Helgaas wrote:
> On Thu, Nov 13, 2014 at 10:09:21AM -0700, Bjorn Helgaas wrote:
> > On Thu, Nov 06, 2014 at 04:23:20PM +0100, Lucas Stach wrote:
> > > This property was added by 41e5c0f81d3e
> > > (of/pci: Add pci_get_new_domain_nr() and of_get_pci_domain_nr())
> > > without the required binding documentation. As this property
> > > will be supported by a number of host bridge drivers going forward,
> > > add it to the common PCI binding doc.
> > > 
> > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > 
> > Applied with acks from Liviu and Rob to for-linus for v3.18, thanks a lot
> > for working this out!
> 
> Arnd, I just noticed your concern about this being linux-only.  Are you
> happy with this one?  If not, I can drop this.

If everyone else is happy with it, please keep it. We have to make
progress here eventually.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/pci/pci.txt b/Documentation/devicetree/bindings/pci/pci.txt
index 41aeed38926d..68c364e2f5e5 100644
--- a/Documentation/devicetree/bindings/pci/pci.txt
+++ b/Documentation/devicetree/bindings/pci/pci.txt
@@ -7,3 +7,14 @@  And for the interrupt mapping part:
 
 Open Firmware Recommended Practice: Interrupt Mapping
 http://www.openfirmware.org/1275/practice/imap/imap0_9d.pdf
+
+Additionally to the properties specified in the above standards a host bridge
+driver implementation may support the following properties:
+
+- linux,pci-domain:
+   If present this property assigns a fixed PCI domain number to a host bridge,
+   otherwise an unstable (across boots) unique number will be assigned.
+   It is required to either not set this property at all or set it for all
+   host bridges in the system, otherwise potentially conflicting domain numbers
+   may be assigned to root buses behind different host bridges. The domain
+   number for each host bridge in the system must be unique.