| Message ID | 1414427215-14380-2-git-send-email-romain.perier@gmail.com |
|---|---|
| State | Needs Review / ACK, archived |
| Headers | show |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 1 errors, 2 warnings, 0 lines checked |
| robh/patch-applied | success |
On Mon, Oct 27, 2014 at 04:26:47PM +0000, Romain Perier wrote: > This simply renames the previous documentation to something more generic and adds > updates according to last changes. > > Signed-off-by: Romain Perier <romain.perier@gmail.com> > --- > .../devicetree/bindings/power/power-controller.txt | 18 ++++++++++++++++++ > Documentation/devicetree/bindings/power/poweroff.txt | 18 ------------------ > 2 files changed, 18 insertions(+), 18 deletions(-) > create mode 100644 Documentation/devicetree/bindings/power/power-controller.txt > delete mode 100644 Documentation/devicetree/bindings/power/poweroff.txt > > diff --git a/Documentation/devicetree/bindings/power/power-controller.txt b/Documentation/devicetree/bindings/power/power-controller.txt > new file mode 100644 > index 0000000..e0a1abe > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/power-controller.txt > @@ -0,0 +1,18 @@ > +* Generic system power control capability > + > +Power-management integrated circuits or miscellaneous harware components are > +sometimes able to control the system power. The device driver associated to these > +components might needs to define this capability, which tells to the kernel > +how to switch off the system. The corresponding driver must have the standard > +property "system-power-controller" in its device node. This property marks the device as > +able to controller the system-power. In order to test if this property is found > +programmatically, use the helper function "of_is_system_power_controller" from > +of.h . > + > +Example: > + > +act8846: act8846@5 { > + compatible = "active-semi,act8846"; > + status = "okay"; > + system-power-controller; > +} there is no mention here that system-power-controller superseeds poweroff-source and deprecates that.
On Mon, Oct 27, 2014 at 11:39:18AM -0500, Felipe Balbi wrote: > On Mon, Oct 27, 2014 at 04:26:47PM +0000, Romain Perier wrote: > > +act8846: act8846@5 { > > + compatible = "active-semi,act8846"; > > + status = "okay"; > > + system-power-controller; > > +} > there is no mention here that system-power-controller superseeds > poweroff-source and deprecates that. Given that poweroff-source hasn't made it into a released kernel yet we can probably just kill it off completely can't we?
On Mon, Oct 27, 2014 at 05:26:36PM +0000, Mark Brown wrote: > On Mon, Oct 27, 2014 at 11:39:18AM -0500, Felipe Balbi wrote: > > On Mon, Oct 27, 2014 at 04:26:47PM +0000, Romain Perier wrote: > > > > +act8846: act8846@5 { > > > + compatible = "active-semi,act8846"; > > > + status = "okay"; > > > + system-power-controller; > > > +} > > > there is no mention here that system-power-controller superseeds > > poweroff-source and deprecates that. > > Given that poweroff-source hasn't made it into a released kernel yet we > can probably just kill it off completely can't we? please do, then we will never have that commit in Linus' tree to give us nightmares.
On Mon, Oct 27, 2014 at 12:30:25PM -0500, Felipe Balbi wrote: > On Mon, Oct 27, 2014 at 05:26:36PM +0000, Mark Brown wrote: > > Given that poweroff-source hasn't made it into a released kernel yet we > > can probably just kill it off completely can't we? > please do, then we will never have that commit in Linus' tree to give us > nightmares. Well, the commit isn't a particularly big deal (and got cross-merged into another tree already) - if it's convenient to rebase it out we probably should but it's also not the end of the world either so long as it doesn't appear in a release. Worst case people adopt it based on the list discussions and we check for two properties which also isn't that bad.
If this is possible, that's probably better to drop all these patches (including poweroff-source) from "next", in this way it will be possible to re-do things properly from scratch (with the new name). If you have a look at linux-next the property "poweroff-source" is already used by tps910 AND act8865, I don't like that (it is not used yet by dts files). I mean, I don't really want to support "vendor,system-power-controller", "system-power-controller" and "poweroff-source" from "of_has_system_power_source" and do a lot of unclean commits in order to don't break compatibility. Just keep things simple. What do you think ? 2014-10-27 18:57 GMT+01:00 Mark Brown <broonie@kernel.org>: > On Mon, Oct 27, 2014 at 12:30:25PM -0500, Felipe Balbi wrote: >> On Mon, Oct 27, 2014 at 05:26:36PM +0000, Mark Brown wrote: > >> > Given that poweroff-source hasn't made it into a released kernel yet we >> > can probably just kill it off completely can't we? > >> please do, then we will never have that commit in Linus' tree to give us >> nightmares. > > Well, the commit isn't a particularly big deal (and got cross-merged > into another tree already) - if it's convenient to rebase it out we > probably should but it's also not the end of the world either so long as > it doesn't appear in a release. Worst case people adopt it based on the > list discussions and we check for two properties which also isn't that > bad. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/power/power-controller.txt b/Documentation/devicetree/bindings/power/power-controller.txt new file mode 100644 index 0000000..e0a1abe --- /dev/null +++ b/Documentation/devicetree/bindings/power/power-controller.txt @@ -0,0 +1,18 @@ +* Generic system power control capability + +Power-management integrated circuits or miscellaneous harware components are +sometimes able to control the system power. The device driver associated to these +components might needs to define this capability, which tells to the kernel +how to switch off the system. The corresponding driver must have the standard +property "system-power-controller" in its device node. This property marks the device as +able to controller the system-power. In order to test if this property is found +programmatically, use the helper function "of_is_system_power_controller" from +of.h . + +Example: + +act8846: act8846@5 { + compatible = "active-semi,act8846"; + status = "okay"; + system-power-controller; +} diff --git a/Documentation/devicetree/bindings/power/poweroff.txt b/Documentation/devicetree/bindings/power/poweroff.txt deleted file mode 100644 index 845868b..0000000 --- a/Documentation/devicetree/bindings/power/poweroff.txt +++ /dev/null @@ -1,18 +0,0 @@ -* Generic Poweroff capability - -Power-management integrated circuits or miscellaneous harware components are -sometimes able to control the system power. The device driver associated to these -components might needs to define poweroff capability, which tells to the kernel -how to switch off the system. The corresponding driver must have the standard -property "poweroff-source" in its device node. This property marks the device as -able to shutdown the system. In order to test if this property is found -programmatically, use the helper function "of_system_has_poweroff_source" from -of.h . - -Example: - -act8846: act8846@5 { - compatible = "active-semi,act8846"; - status = "okay"; - poweroff-source; -}
This simply renames the previous documentation to something more generic and adds updates according to last changes. Signed-off-by: Romain Perier <romain.perier@gmail.com> --- .../devicetree/bindings/power/power-controller.txt | 18 ++++++++++++++++++ Documentation/devicetree/bindings/power/poweroff.txt | 18 ------------------ 2 files changed, 18 insertions(+), 18 deletions(-) create mode 100644 Documentation/devicetree/bindings/power/power-controller.txt delete mode 100644 Documentation/devicetree/bindings/power/poweroff.txt