| Message ID | 1413996311-4287-3-git-send-email-hdegoede@redhat.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Wed, 22 Oct 2014 18:45:08 +0200 , Hans de Goede <hdegoede@redhat.com> wrote: > A simple-framebuffer node represents a framebuffer setup by the firmware / > bootloader. Such a framebuffer may have a number of clocks in use, add a > property to communicate this to the OS. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > Reviewed-by: Mike Turquette <mturquette@linaro.org> > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> > Reviewed-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > -- > Changes in v2: > -Added Reviewed-by: Mike Turquette <mturquette@linaro.org> > Changes in v3: > -Updated description to make clear simplefb deals with more then just memory > --- > Documentation/devicetree/bindings/video/simple-framebuffer.txt | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/video/simple-framebuffer.txt b/Documentation/devicetree/bindings/video/simple-framebuffer.txt > index 70c26f3..172ad5f 100644 > --- a/Documentation/devicetree/bindings/video/simple-framebuffer.txt > +++ b/Documentation/devicetree/bindings/video/simple-framebuffer.txt > @@ -1,8 +1,8 @@ > Simple Framebuffer > > -A simple frame-buffer describes a raw memory region that may be rendered to, > -with the assumption that the display hardware has already been set up to scan > -out from that buffer. > +A simple frame-buffer describes a frame-buffer setup by firmware or > +the bootloader, with the assumption that the display hardware has already > +been set up to scan out from the memory pointed to by the reg property. > > Required properties: > - compatible: "simple-framebuffer" > @@ -14,6 +14,9 @@ Required properties: > - r5g6b5 (16-bit pixels, d[15:11]=r, d[10:5]=g, d[4:0]=b). > - a8b8g8r8 (32-bit pixels, d[31:24]=a, d[23:16]=b, d[15:8]=g, d[7:0]=r). > > +Optional properties: > +- clocks : List of clocks used by the framebuffer Please change to the following: - clocks : List of clocks used by the framebuffer. Clocks listed here are expected to already be configured correctly. The OS must ensure these clocks are not modified or disabled while the simple framebuffer remains active. g. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[Replying on-list and with original ccs] On Wed, Nov 12, 2014 at 2:50 PM, Hans de Goede <hdegoede@redhat.com> wrote: > Hi, > > On 11/11/2014 10:42 PM, Grant Likely wrote: >> - clocks : List of clocks used by the framebuffer. Clocks listed here >> are expected to already be configured correctly. The OS must >> ensure these clocks are not modified or disabled while the >> simple framebuffer remains active. > > Updated in my local tree, where I've also added proper commit messages > to the 2 patches missing them. Shall I send a v5 of the set, and may I > add your Acked-by to this patch when sending v5? For this whole series, please add my Acked-by. Acked-by: Grant Likely <grant.likely@linaro.org> I'm okay with the bindings, and I'm okay with adding the clock dependency to a simplefb node. I'm happy with the conversation we had today on IRC, and I'm expecting to see a binding that covers expected firmware/OS behaviour and association with the real hardware posted to the list shortly. g. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 11/12/2014 03:56 PM, Grant Likely wrote: > [Replying on-list and with original ccs] > > On Wed, Nov 12, 2014 at 2:50 PM, Hans de Goede <hdegoede@redhat.com> wrote: >> Hi, >> >> On 11/11/2014 10:42 PM, Grant Likely wrote: >>> - clocks : List of clocks used by the framebuffer. Clocks listed here >>> are expected to already be configured correctly. The OS must >>> ensure these clocks are not modified or disabled while the >>> simple framebuffer remains active. >> >> Updated in my local tree, where I've also added proper commit messages >> to the 2 patches missing them. Shall I send a v5 of the set, and may I >> add your Acked-by to this patch when sending v5? > > For this whole series, please add my Acked-by. > > Acked-by: Grant Likely <grant.likely@linaro.org> Thanks, given the above update to the bindings text, and also some updated commit messages, I'll post a v5 with all these added soon. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Nov 12, 2014 at 10:38 AM, Grant Likely <grant.likely@linaro.org> wrote: > Rob, seeing as we disagree on patch #5, do you have time to discuss this > evening, or tomorrow? Yes, either is fine. Rob > > g. > > On 12 Nov 2014 14:56, "Grant Likely" <grant.likely@linaro.org> wrote: >> >> [Replying on-list and with original ccs] >> >> On Wed, Nov 12, 2014 at 2:50 PM, Hans de Goede <hdegoede@redhat.com> >> wrote: >> > Hi, >> > >> > On 11/11/2014 10:42 PM, Grant Likely wrote: >> >> - clocks : List of clocks used by the framebuffer. Clocks listed here >> >> are expected to already be configured correctly. The OS must >> >> ensure these clocks are not modified or disabled while the >> >> simple framebuffer remains active. >> > >> > Updated in my local tree, where I've also added proper commit messages >> > to the 2 patches missing them. Shall I send a v5 of the set, and may I >> > add your Acked-by to this patch when sending v5? >> >> For this whole series, please add my Acked-by. >> >> Acked-by: Grant Likely <grant.likely@linaro.org> >> >> I'm okay with the bindings, and I'm okay with adding the clock >> dependency to a simplefb node. I'm happy with the conversation we had >> today on IRC, and I'm expecting to see a binding that covers expected >> firmware/OS behaviour and association with the real hardware posted to >> the list shortly. >> >> g. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/video/simple-framebuffer.txt b/Documentation/devicetree/bindings/video/simple-framebuffer.txt index 70c26f3..172ad5f 100644 --- a/Documentation/devicetree/bindings/video/simple-framebuffer.txt +++ b/Documentation/devicetree/bindings/video/simple-framebuffer.txt @@ -1,8 +1,8 @@ Simple Framebuffer -A simple frame-buffer describes a raw memory region that may be rendered to, -with the assumption that the display hardware has already been set up to scan -out from that buffer. +A simple frame-buffer describes a frame-buffer setup by firmware or +the bootloader, with the assumption that the display hardware has already +been set up to scan out from the memory pointed to by the reg property. Required properties: - compatible: "simple-framebuffer" @@ -14,6 +14,9 @@ Required properties: - r5g6b5 (16-bit pixels, d[15:11]=r, d[10:5]=g, d[4:0]=b). - a8b8g8r8 (32-bit pixels, d[31:24]=a, d[23:16]=b, d[15:8]=g, d[7:0]=r). +Optional properties: +- clocks : List of clocks used by the framebuffer + Example: framebuffer {