| Message ID | 1403806546-31122-13-git-send-email-javier.martinez@collabora.co.uk |
|---|---|
| State | Superseded, archived |
| Headers | show |
Am 26.06.2014 20:15, schrieb Javier Martinez Canillas: > Add Device Tree binding documentation for the clocks > outputs in the Maxim 77802 Power Management IC. > > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > --- > > Changes since v4: None > > Changes since v3: > - Don't use the same clock driver name in clock-names since it's a consumer > concept and most probably will be different. Suggested by Doug Anderson. > > Changes since v2: > - Split the DT binding documentation in a separate patch. > > .../devicetree/bindings/clock/maxim,max77802.txt | 42 ++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/maxim,max77802.txt > > diff --git a/Documentation/devicetree/bindings/clock/maxim,max77802.txt b/Documentation/devicetree/bindings/clock/maxim,max77802.txt > new file mode 100644 > index 0000000..26bc4f7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/maxim,max77802.txt > @@ -0,0 +1,42 @@ > +Binding for Maxim MAX77802 32k clock generator block > + > +This is a part of device tree bindings of MAX77802 multi-function device. > +More information can be found in bindings/mfd/max77802.txt file. > + > +The MAX77802 contains two 32.768khz clock outputs that can be controlled > +(gated/ungated) over I2C. > + > +Following properties should be presend in main device node of the MFD chip. "present" Regards, Andreas
Hello Andres, Thanks a lot for your feedback. On 06/27/2014 09:52 AM, Andreas Färber wrote: > Am 26.06.2014 20:15, schrieb Javier Martinez Canillas: >> Add Device Tree binding documentation for the clocks >> outputs in the Maxim 77802 Power Management IC. >> >> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> >> --- >> >> Changes since v4: None >> >> Changes since v3: >> - Don't use the same clock driver name in clock-names since it's a consumer >> concept and most probably will be different. Suggested by Doug Anderson. >> >> Changes since v2: >> - Split the DT binding documentation in a separate patch. >> >> .../devicetree/bindings/clock/maxim,max77802.txt | 42 ++++++++++++++++++++++ >> 1 file changed, 42 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/maxim,max77802.txt >> >> diff --git a/Documentation/devicetree/bindings/clock/maxim,max77802.txt b/Documentation/devicetree/bindings/clock/maxim,max77802.txt >> new file mode 100644 >> index 0000000..26bc4f7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/maxim,max77802.txt >> @@ -0,0 +1,42 @@ >> +Binding for Maxim MAX77802 32k clock generator block >> + >> +This is a part of device tree bindings of MAX77802 multi-function device. >> +More information can be found in bindings/mfd/max77802.txt file. >> + >> +The MAX77802 contains two 32.768khz clock outputs that can be controlled >> +(gated/ungated) over I2C. >> + >> +Following properties should be presend in main device node of the MFD chip. > > "present" > Right, it's a typo. I'll wait for further feedback and will fix both issues you pointed out in the next version of the series. > Regards, > Andreas > Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/clock/maxim,max77802.txt b/Documentation/devicetree/bindings/clock/maxim,max77802.txt new file mode 100644 index 0000000..26bc4f7 --- /dev/null +++ b/Documentation/devicetree/bindings/clock/maxim,max77802.txt @@ -0,0 +1,42 @@ +Binding for Maxim MAX77802 32k clock generator block + +This is a part of device tree bindings of MAX77802 multi-function device. +More information can be found in bindings/mfd/max77802.txt file. + +The MAX77802 contains two 32.768khz clock outputs that can be controlled +(gated/ungated) over I2C. + +Following properties should be presend in main device node of the MFD chip. + +Required properties: + +- #clock-cells: from common clock binding; shall be set to 1. + +Each clock is assigned an identifier and client nodes can use this identifier +to specify the clock which they consume. Following indices are allowed: + - 0: 32khz_ap clock, + - 1: 32khz_cp clock. + +Clocks are defined as preprocessor macros in dt-bindings/clock/maxim,max77802.h +header and can be used in device tree sources. + +Example: Node of the MFD chip + + max77802: max77802@09 { + compatible = "maxim,max77802"; + interrupt-parent = <&wakeup_eint>; + interrupts = <26 0>; + reg = <0x09>; + #clock-cells = <1>; + + /* ... */ + }; + +Example: Clock consumer node + + foo@0 { + compatible = "bar,foo"; + /* ... */ + clock-names = "my-clock"; + clocks = <&max77802 MAX77802_CLK_32K_AP>; + };
Add Device Tree binding documentation for the clocks outputs in the Maxim 77802 Power Management IC. Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- Changes since v4: None Changes since v3: - Don't use the same clock driver name in clock-names since it's a consumer concept and most probably will be different. Suggested by Doug Anderson. Changes since v2: - Split the DT binding documentation in a separate patch. .../devicetree/bindings/clock/maxim,max77802.txt | 42 ++++++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/maxim,max77802.txt