| Message ID | 1389238094-19386-5-git-send-email-shaik.ameer@samsung.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
Hi, On Thursday, January 09, 2014 08:58:14 AM Shaik Ameer Basha wrote: > This patch adds the DT binding documentation for the > Exynos5420/5410 based SCALER device driver. > > Signed-off-by: Shaik Ameer Basha <shaik.ameer@samsung.com> > Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > .../devicetree/bindings/media/exynos5-scaler.txt | 22 ++++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/exynos5-scaler.txt > > diff --git a/Documentation/devicetree/bindings/media/exynos5-scaler.txt b/Documentation/devicetree/bindings/media/exynos5-scaler.txt > new file mode 100644 > index 0000000..9328e7d > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/exynos5-scaler.txt > @@ -0,0 +1,22 @@ > +* Samsung Exynos5 SCALER device > + > +SCALER is used for scaling, blending, color fill and color space > +conversion on EXYNOS[5420/5410] SoCs. > + > +Required properties: > +- compatible: should be "samsung,exynos5420-scaler" or > + "samsung,exynos5410-scaler" > +- reg: should contain SCALER physical address location and length > +- interrupts: should contain SCALER interrupt number > +- clocks: should contain the SCALER clock specifier, from the > + common clock bindings > +- clock-names: should be "scaler" > + > +Example: > + scaler_0: scaler@12800000 { > + compatible = "samsung,exynos5420-scaler"; > + reg = <0x12800000 0x1000>; > + interrupts = <0 220 0>; > + clocks = <&clock 381>; > + clock-names = "scaler"; > + }; Your patchset adds support for EXYNOS5 SCALER but doesn't add any real users of it yet. Could you please explain why? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Bartlomiej, Thanks for the review. Yes you are right. I didn't add the users for this driver. Once the driver gets merged, I will send more patches with the users. Already this driver merge is pending on DT maintainers ack and I don't want to complex it more by adding DT patches :) Definitely, I will send the users patches once the driver gets merged. And I will address all your comments in next version of patch series. Regards, Shaik Ameer Basha On Thu, Jan 9, 2014 at 6:20 PM, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote: > > Hi, > > On Thursday, January 09, 2014 08:58:14 AM Shaik Ameer Basha wrote: >> This patch adds the DT binding documentation for the >> Exynos5420/5410 based SCALER device driver. >> >> Signed-off-by: Shaik Ameer Basha <shaik.ameer@samsung.com> >> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> >> --- >> .../devicetree/bindings/media/exynos5-scaler.txt | 22 ++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/exynos5-scaler.txt >> >> diff --git a/Documentation/devicetree/bindings/media/exynos5-scaler.txt b/Documentation/devicetree/bindings/media/exynos5-scaler.txt >> new file mode 100644 >> index 0000000..9328e7d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/exynos5-scaler.txt >> @@ -0,0 +1,22 @@ >> +* Samsung Exynos5 SCALER device >> + >> +SCALER is used for scaling, blending, color fill and color space >> +conversion on EXYNOS[5420/5410] SoCs. >> + >> +Required properties: >> +- compatible: should be "samsung,exynos5420-scaler" or >> + "samsung,exynos5410-scaler" >> +- reg: should contain SCALER physical address location and length >> +- interrupts: should contain SCALER interrupt number >> +- clocks: should contain the SCALER clock specifier, from the >> + common clock bindings >> +- clock-names: should be "scaler" >> + >> +Example: >> + scaler_0: scaler@12800000 { >> + compatible = "samsung,exynos5420-scaler"; >> + reg = <0x12800000 0x1000>; >> + interrupts = <0 220 0>; >> + clocks = <&clock 381>; >> + clock-names = "scaler"; >> + }; > > Your patchset adds support for EXYNOS5 SCALER but doesn't add any real > users of it yet. Could you please explain why? > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Shaik, On 09.01.2014 04:28, Shaik Ameer Basha wrote: > This patch adds the DT binding documentation for the > Exynos5420/5410 based SCALER device driver. > > Signed-off-by: Shaik Ameer Basha <shaik.ameer@samsung.com> > Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > .../devicetree/bindings/media/exynos5-scaler.txt | 22 ++++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/exynos5-scaler.txt > > diff --git a/Documentation/devicetree/bindings/media/exynos5-scaler.txt b/Documentation/devicetree/bindings/media/exynos5-scaler.txt > new file mode 100644 > index 0000000..9328e7d > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/exynos5-scaler.txt > @@ -0,0 +1,22 @@ > +* Samsung Exynos5 SCALER device > + > +SCALER is used for scaling, blending, color fill and color space > +conversion on EXYNOS[5420/5410] SoCs. > + > +Required properties: > +- compatible: should be "samsung,exynos5420-scaler" or > + "samsung,exynos5410-scaler" > +- reg: should contain SCALER physical address location and length > +- interrupts: should contain SCALER interrupt number s/number/specifier/ > +- clocks: should contain the SCALER clock specifier, from the > + common clock bindings s/specifier/phandle and specifier pair for each clock listed in clock-names property/ s/from/according to/ > +- clock-names: should be "scaler" should contain exactly one entry: - "scaler" - IP bus clock. Also this patch should be first in the series to let the driver added in further patches use already present bindings. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Tomasz, Thanks for the review. Will consider all your comments in the next version of patch series. Regards, Shaik Ameer Basha On Sat, Jan 25, 2014 at 1:09 AM, Tomasz Figa <t.figa@samsung.com> wrote: > Hi Shaik, > > > On 09.01.2014 04:28, Shaik Ameer Basha wrote: >> >> This patch adds the DT binding documentation for the >> Exynos5420/5410 based SCALER device driver. >> >> Signed-off-by: Shaik Ameer Basha <shaik.ameer@samsung.com> >> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> >> --- >> .../devicetree/bindings/media/exynos5-scaler.txt | 22 >> ++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/media/exynos5-scaler.txt >> >> diff --git a/Documentation/devicetree/bindings/media/exynos5-scaler.txt >> b/Documentation/devicetree/bindings/media/exynos5-scaler.txt >> new file mode 100644 >> index 0000000..9328e7d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/exynos5-scaler.txt >> @@ -0,0 +1,22 @@ >> +* Samsung Exynos5 SCALER device >> + >> +SCALER is used for scaling, blending, color fill and color space >> +conversion on EXYNOS[5420/5410] SoCs. >> + >> +Required properties: >> +- compatible: should be "samsung,exynos5420-scaler" or >> + "samsung,exynos5410-scaler" >> +- reg: should contain SCALER physical address location and length >> +- interrupts: should contain SCALER interrupt number > > > s/number/specifier/ > > >> +- clocks: should contain the SCALER clock specifier, from the >> + common clock bindings > > > s/specifier/phandle and specifier pair for each clock listed in clock-names > property/ > > s/from/according to/ > > >> +- clock-names: should be "scaler" > > > should contain exactly one entry: > - "scaler" - IP bus clock. > > Also this patch should be first in the series to let the driver added in > further patches use already present bindings. > > Best regards, > Tomasz > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/media/exynos5-scaler.txt b/Documentation/devicetree/bindings/media/exynos5-scaler.txt new file mode 100644 index 0000000..9328e7d --- /dev/null +++ b/Documentation/devicetree/bindings/media/exynos5-scaler.txt @@ -0,0 +1,22 @@ +* Samsung Exynos5 SCALER device + +SCALER is used for scaling, blending, color fill and color space +conversion on EXYNOS[5420/5410] SoCs. + +Required properties: +- compatible: should be "samsung,exynos5420-scaler" or + "samsung,exynos5410-scaler" +- reg: should contain SCALER physical address location and length +- interrupts: should contain SCALER interrupt number +- clocks: should contain the SCALER clock specifier, from the + common clock bindings +- clock-names: should be "scaler" + +Example: + scaler_0: scaler@12800000 { + compatible = "samsung,exynos5420-scaler"; + reg = <0x12800000 0x1000>; + interrupts = <0 220 0>; + clocks = <&clock 381>; + clock-names = "scaler"; + };