| Message ID | 0bfdc811c2b3da3aa1cde2feef278a86503e3804.1523934640.git.baolin.wang@linaro.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [1/2] dt-bindings: input: Add Add Spreadtrum SC27xx vibrator documentation | expand |
Hi Xiaotong, On Tue, Apr 17, 2018 at 11:18:24AM +0800, Baolin Wang wrote: > From: Xiaotong Lu <xiaotong.lu@spreadtrum.com> [snip] > +static int sc27xx_vibra_probe(struct platform_device *pdev) > +{ > + struct device_node *node = pdev->dev.of_node; > + struct vibra_info *info; > + int ret; > + > + info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL); > + if (!info) > + return -ENOMEM; > + > + info->regmap = dev_get_regmap(pdev->dev.parent, NULL); > + if (!info->regmap) { > + dev_err(&pdev->dev, "failed to get vibrator regmap.\n"); > + return -ENODEV; > + } > + > + ret = of_property_read_u32(node, "reg", &info->base); > + if (ret) { > + dev_err(&pdev->dev, "failed to get vibrator base address.\n"); > + return ret; > + } > + > + info->input_dev = devm_input_allocate_device(&pdev->dev); > + if (!info->input_dev) { > + dev_err(&pdev->dev, "failed to allocate input device.\n"); > + return -ENOMEM; > + } > + > + info->input_dev->name = "sc27xx:vibrator"; > + info->input_dev->id.version = 0; > + info->input_dev->dev.parent = pdev->dev.parent; > + info->input_dev->close = sc27xx_vibra_close; > + > + input_set_drvdata(info->input_dev, info); > + input_set_capability(info->input_dev, EV_FF, FF_RUMBLE); > + INIT_WORK(&info->play_work, sc27xx_vibra_play_work); > + info->enabled = false; > + > + ret = input_ff_create_memless(info->input_dev, NULL, sc27xx_vibra_play); > + if (ret) { > + dev_err(&pdev->dev, "failed to register vibrator to FF.\n"); > + return ret; > + } > + > + ret = input_register_device(info->input_dev); > + if (ret) { > + dev_err(&pdev->dev, "failed to register input device.\n"); > + input_ff_destroy(info->input_dev); I'm not sure how the input_ff is freed for managed devices. Either you don't have to destroy it here, or you also need to destroy it in a release() function. > + return ret; > + } > + > + ret = sc27xx_vibra_hw_init(info); > + if (ret) { > + dev_err(&pdev->dev, "failed to initialize the vibrator.\n"); > + input_ff_destroy(info->input_dev); > + input_unregister_device(info->input_dev); No need to unregister managed input devices. > + return ret; > + } Cheers, Marcus Folkesson -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Marcus, On 17 April 2018 at 15:25, Marcus Folkesson <marcus.folkesson@gmail.com> wrote: > Hi Xiaotong, > > On Tue, Apr 17, 2018 at 11:18:24AM +0800, Baolin Wang wrote: >> From: Xiaotong Lu <xiaotong.lu@spreadtrum.com> > > [snip] > >> +static int sc27xx_vibra_probe(struct platform_device *pdev) >> +{ >> + struct device_node *node = pdev->dev.of_node; >> + struct vibra_info *info; >> + int ret; >> + >> + info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL); >> + if (!info) >> + return -ENOMEM; >> + >> + info->regmap = dev_get_regmap(pdev->dev.parent, NULL); >> + if (!info->regmap) { >> + dev_err(&pdev->dev, "failed to get vibrator regmap.\n"); >> + return -ENODEV; >> + } >> + >> + ret = of_property_read_u32(node, "reg", &info->base); >> + if (ret) { >> + dev_err(&pdev->dev, "failed to get vibrator base address.\n"); >> + return ret; >> + } >> + >> + info->input_dev = devm_input_allocate_device(&pdev->dev); >> + if (!info->input_dev) { >> + dev_err(&pdev->dev, "failed to allocate input device.\n"); >> + return -ENOMEM; >> + } >> + >> + info->input_dev->name = "sc27xx:vibrator"; >> + info->input_dev->id.version = 0; >> + info->input_dev->dev.parent = pdev->dev.parent; >> + info->input_dev->close = sc27xx_vibra_close; >> + >> + input_set_drvdata(info->input_dev, info); >> + input_set_capability(info->input_dev, EV_FF, FF_RUMBLE); >> + INIT_WORK(&info->play_work, sc27xx_vibra_play_work); >> + info->enabled = false; >> + >> + ret = input_ff_create_memless(info->input_dev, NULL, sc27xx_vibra_play); >> + if (ret) { >> + dev_err(&pdev->dev, "failed to register vibrator to FF.\n"); >> + return ret; >> + } >> + >> + ret = input_register_device(info->input_dev); >> + if (ret) { >> + dev_err(&pdev->dev, "failed to register input device.\n"); >> + input_ff_destroy(info->input_dev); > > I'm not sure how the input_ff is freed for managed devices. > > Either you don't have to destroy it here, or you also need to destroy it > in a release() function. I checked again, we do not need to destroy it manually. Will remove in next version. > >> + return ret; >> + } >> + >> + ret = sc27xx_vibra_hw_init(info); >> + if (ret) { >> + dev_err(&pdev->dev, "failed to initialize the vibrator.\n"); >> + input_ff_destroy(info->input_dev); >> + input_unregister_device(info->input_dev); > > No need to unregister managed input devices. You are correct. Will remove these in next version. Thanks for your comments.
diff --git a/Documentation/devicetree/bindings/input/sprd,sc27xx-vibra.txt b/Documentation/devicetree/bindings/input/sprd,sc27xx-vibra.txt new file mode 100644 index 0000000..92ead29 --- /dev/null +++ b/Documentation/devicetree/bindings/input/sprd,sc27xx-vibra.txt @@ -0,0 +1,12 @@ +Spreadtrum SC27xx PMIC Vibrator + +Required properties: +- compatible: should be "sprd,sc27xx-vibrator". +- reg: address of vibrator control register. + +Example : + +vibrator@eb4 { + compatible = "sprd,sc27xx-vibrator"; + reg = <0xeb4>; +};