mbox series

[v4,0/3] Enable IPQ9574 TSENS support

Message ID cover.1684920389.git.quic_varada@quicinc.com
Headers show
Series Enable IPQ9574 TSENS support | expand

Message

Varadarajan Narayanan May 24, 2023, 9:36 a.m. UTC 
This patch set enables tsens in IPQ9574

Depends on
	https://lore.kernel.org/linux-arm-msm/20230406061314.10916-1-quic_devipriy@quicinc.com/
[v4]:
	Drop the sm6375-tsens and qcm2290-tsens related bindings
	fix as it is already posted

	Remove unnecessary changes from previous version

[v3]:
	Fix make DT_CHECKER_FLAGS=-m dt_binding_check and make dtbs_check errors

[v2]:
	Drop the driver change (https://lore.kernel.org/lkml/b45d33d38a334aabbd52c83b0d6028af1f4c74c8.1682682753.git.quic_varada@quicinc.com/)
	since the tsens device is compatible with 8074's tsens
	and use 8074's compatible itself

	Rename clusterX nodes as cpussX

[v1]:
	Fix DT node names

[v0]:
	Initial patch introducing TSENS support

Praveenkumar I (1):
  dt-bindings: thermal: tsens: Add ipq9574 compatible

Varadarajan Narayanan (2):
  arm64: dts: qcom: ipq9574: add tsens node
  arm64: dts: qcom: ipq9574: add thermal zone nodes

 .../devicetree/bindings/thermal/qcom-tsens.yaml    |  11 +-
 arch/arm64/boot/dts/qcom/ipq9574.dtsi              | 217 +++++++++++++++++++++
 2 files changed, 226 insertions(+), 2 deletions(-)

Comments

Bjorn Andersson May 26, 2023, 7:30 p.m. UTC | #1 
On Wed, May 24, 2023 at 03:06:10PM +0530, Varadarajan Narayanan wrote:
> IPQ9574 has a tsens v2.3.1 peripheral which monitors temperatures
> around the various subsystems on the die.
> 
> Co-developed-by: Praveenkumar I <quic_ipkumar@quicinc.com>
> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
> [v2]:
> 	Add "qcom,ipq8074-tsens" as fallback compatible
> ---
>  arch/arm64/boot/dts/qcom/ipq9574.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> index 0ab5556..15c9447 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> @@ -958,6 +958,15 @@
>  			status = "disabled";
>  		};
>  
> +		tsens: thermal-sensor@4a9000 {
> +			compatible = "qcom,ipq9574-tsens", "qcom,ipq8074-tsens";
> +			reg = <0x4a9000 0x1000>, /* TM */

Please pad addresses to 8 digits, and sort nodes by address.

Regards,
Bjorn

> +			      <0x4a8000 0x1000>; /* SROT */
> +			interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-names = "combined";
> +			#qcom,sensors = <16>;
> +			#thermal-sensor-cells = <1>;
> +		};
>  	};
>  
>  	timer {
> -- 
> 2.7.4
>
Bjorn Andersson June 13, 2023, 11:48 p.m. UTC | #2 
On Wed, 24 May 2023 15:06:08 +0530, Varadarajan Narayanan wrote:
> This patch set enables tsens in IPQ9574
> 
> Depends on
> 	https://lore.kernel.org/linux-arm-msm/20230406061314.10916-1-quic_devipriy@quicinc.com/
> [v4]:
> 	Drop the sm6375-tsens and qcm2290-tsens related bindings
> 	fix as it is already posted
> 
> [...]

Applied, thanks!

[2/3] arm64: dts: qcom: ipq9574: add tsens node
      commit: 2e0580e10e919b544d7be1b2b8fc48fc7dff1322
[3/3] arm64: dts: qcom: ipq9574: add thermal zone nodes
      commit: 581dcbe60b6390c633f318a29db41d1df642e6d8

Best regards,