| Message ID | 20250516180147.10416-1-linux@fw-web.de |
|---|---|
| Headers | show |
| Series | further mt7988 devicetree work | expand |
Sorry, resent it by accident while sending v2 of my dts series. regards Frank
On Fri, 16 May 2025 20:08:47 +0200 Frank Wunderlich wrote: > Sorry, resent it by accident while sending v2 of my dts series. > regards Frank Unfortunately patchwork thought this is patch 1 of the series instead of the bindings patch :( Let's wait for binding reviews and maybe you could repost patches 1-3 for net-next without the dts ones?
On Fri, 16 May 2025 20:01:30 +0200, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > This series continues mt7988 devicetree work > > - Add SPI with BPI-R4 nand to reach eMMC > - Add thermal protection (fan+cooling-points) > - Extend cpu frequency scaling with CCI > - Basic network-support (ethernet controller + builtin switch + SFP Cages) > > [...] Applied to v6.15-next/dts64, thanks! [04/14] arm64: dts: mediatek: mt7988: add spi controllers commit: 21e0977b4c074c393205b601509574820e534122 [05/14] arm64: dts: mediatek: mt7988: move uart0 and spi1 pins to soc dtsi commit: 35818d5038e8003745f31d8a535dea245483b61a [06/14] arm64: dts: mediatek: mt7988: add cci node commit: 05c81fe3a6aab2a9df7a067b035ef7f269b66e24 [07/14] arm64: dts: mediatek: mt7988: add phy calibration efuse subnodes commit: 22ebf43c4eef099beffc510ec0b2a2549668d8e5 [10/14] arm64: dts: mediatek: mt7988a-bpi-r4: Add fan and coolingmaps commit: 1b8747157f8eda93545163f0401d9493780026fe [11/14] arm64: dts: mediatek: mt7988a-bpi-r4: configure spi-nodes commit: 91c09be53d9a66cc93e998d8c3252dc4ef469ae9 [12/14] arm64: dts: mediatek: mt7988a-bpi-r4: add proc-supply for cci commit: 2bb566a7f04bc775120d016a232d6b69005f3c97 Cheers, Angelo
Il 16/05/25 20:01, Frank Wunderlich ha scritto: > From: Frank Wunderlich <frank-w@public-files.de> > > Add cci devicetree node for cpu frequency scaling. > > Signed-off-by: Daniel Golle <daniel@makrotopia.org> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > --- > arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 33 +++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi > index ab6fc09940b8..64466acb0e71 100644 > --- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi > @@ -12,6 +12,35 @@ / { > #address-cells = <2>; > #size-cells = <2>; > > + cci: cci { > + compatible = "mediatek,mt8183-cci"; While you can keep the mediatek,mt8183-cci fallback, this needs its own compatible as "mediatek,mt7988-cci", therefore, I had to drop this patch from the ones that I picked. Please add the new compatible both here and in the binding. Cheers, Angelo > + clocks = <&mcusys CLK_MCU_BUS_DIV_SEL>, > + <&topckgen CLK_TOP_XTAL>; > + clock-names = "cci", "intermediate"; > + operating-points-v2 = <&cci_opp>; > + }; > + > + cci_opp: opp-table-cci { > + compatible = "operating-points-v2"; > + opp-shared; > + opp-480000000 { > + opp-hz = /bits/ 64 <480000000>; > + opp-microvolt = <850000>; > + }; > + opp-660000000 { > + opp-hz = /bits/ 64 <660000000>; > + opp-microvolt = <850000>; > + }; > + opp-900000000 { > + opp-hz = /bits/ 64 <900000000>; > + opp-microvolt = <850000>; > + }; > + opp-1080000000 { > + opp-hz = /bits/ 64 <1080000000>; > + opp-microvolt = <900000>; > + }; > + }; > + > cpus { > #address-cells = <1>; > #size-cells = <0>; > @@ -25,6 +54,7 @@ cpu0: cpu@0 { > <&topckgen CLK_TOP_XTAL>; > clock-names = "cpu", "intermediate"; > operating-points-v2 = <&cluster0_opp>; > + mediatek,cci = <&cci>; > }; > > cpu1: cpu@1 { > @@ -36,6 +66,7 @@ cpu1: cpu@1 { > <&topckgen CLK_TOP_XTAL>; > clock-names = "cpu", "intermediate"; > operating-points-v2 = <&cluster0_opp>; > + mediatek,cci = <&cci>; > }; > > cpu2: cpu@2 { > @@ -47,6 +78,7 @@ cpu2: cpu@2 { > <&topckgen CLK_TOP_XTAL>; > clock-names = "cpu", "intermediate"; > operating-points-v2 = <&cluster0_opp>; > + mediatek,cci = <&cci>; > }; > > cpu3: cpu@3 { > @@ -58,6 +90,7 @@ cpu3: cpu@3 { > <&topckgen CLK_TOP_XTAL>; > clock-names = "cpu", "intermediate"; > operating-points-v2 = <&cluster0_opp>; > + mediatek,cci = <&cci>; > }; > > cluster0_opp: opp-table-0 {
Am 20. Mai 2025 13:27:23 MESZ schrieb AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>: >Il 16/05/25 20:01, Frank Wunderlich ha scritto: >> From: Frank Wunderlich <frank-w@public-files.de> >> >> Add cci devicetree node for cpu frequency scaling. >> >> Signed-off-by: Daniel Golle <daniel@makrotopia.org> >> Signed-off-by: Frank Wunderlich <frank-w@public-files.de> >> --- >> arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 33 +++++++++++++++++++++++ >> 1 file changed, 33 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi >> index ab6fc09940b8..64466acb0e71 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi >> @@ -12,6 +12,35 @@ / { >> #address-cells = <2>; >> #size-cells = <2>; >> + cci: cci { >> + compatible = "mediatek,mt8183-cci"; > >While you can keep the mediatek,mt8183-cci fallback, this needs its own compatible >as "mediatek,mt7988-cci", therefore, I had to drop this patch from the ones that I >picked. > >Please add the new compatible both here and in the binding. Ok,but you have to drop last one too (add proc-supply) else there are build-errors. >Cheers, >Angelo > regards Frank
Il 20/05/25 13:53, Frank Wunderlich ha scritto: > Am 20. Mai 2025 13:27:23 MESZ schrieb AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>: >> Il 16/05/25 20:01, Frank Wunderlich ha scritto: >>> From: Frank Wunderlich <frank-w@public-files.de> >>> >>> Add cci devicetree node for cpu frequency scaling. >>> >>> Signed-off-by: Daniel Golle <daniel@makrotopia.org> >>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de> >>> --- >>> arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 33 +++++++++++++++++++++++ >>> 1 file changed, 33 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi >>> index ab6fc09940b8..64466acb0e71 100644 >>> --- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi >>> +++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi >>> @@ -12,6 +12,35 @@ / { >>> #address-cells = <2>; >>> #size-cells = <2>; >>> + cci: cci { >>> + compatible = "mediatek,mt8183-cci"; >> >> While you can keep the mediatek,mt8183-cci fallback, this needs its own compatible >> as "mediatek,mt7988-cci", therefore, I had to drop this patch from the ones that I >> picked. >> >> Please add the new compatible both here and in the binding. > > Ok,but you have to drop last one too (add proc-supply) else there are build-errors. > Many many thanks for the reminder, but yes, I already dropped that one too ;-) >> Cheers, >> Angelo >> > > > regards Frank
Am 2025-05-20 13:27, schrieb AngeloGioacchino Del Regno: > Il 16/05/25 20:01, Frank Wunderlich ha scritto: >> From: Frank Wunderlich <frank-w@public-files.de> >> >> Add cci devicetree node for cpu frequency scaling. >> --- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi >> @@ -12,6 +12,35 @@ / { >> #address-cells = <2>; >> #size-cells = <2>; >> + cci: cci { >> + compatible = "mediatek,mt8183-cci"; > > While you can keep the mediatek,mt8183-cci fallback, this needs its own > compatible > as "mediatek,mt7988-cci", therefore, I had to drop this patch from the > ones that I > picked. > > Please add the new compatible both here and in the binding. Hi, should i add the binding with 2 const (like the bpi-r4-2g5 compatible) or first as enum to allow easier addition of further SoC bindings with same fallback? currently i changed binding like this (2nd variant): properties: compatible: oneOf: - items: - enum: - mediatek,mt8183-cci - mediatek,mt8186-cci - items: - enum: - mediatek,mt7988-cci - const: mediatek,mt8183-cci but noticed that these boards are missing the required proc-supply: DTC [C] arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dtb arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dtb: cci: 'proc-supply' is a required property from schema $id: http://devicetree.org/schemas/interconnect/mediatek,cci.yaml# DTC [C] arch/arm64/boot/dts/mediatek/mt8186-evb.dtb arch/arm64/boot/dts/mediatek/mt8186-evb.dtb: cci: 'proc-supply' is a required property from schema $id: http://devicetree.org/schemas/interconnect/mediatek,cci.yaml# the others are clean so far. But because i do not have these boards i cannot fix this without anyone telling me the proc-supply for them. In mt7988a.dtsi i can put both compatible on 1 line as there are only 75 chars, or should i add linebreak here for better readability? > Cheers, > Angelo regards Frank
From: Frank Wunderlich <frank-w@public-files.de> This series continues mt7988 devicetree work - Add SPI with BPI-R4 nand to reach eMMC - Add thermal protection (fan+cooling-points) - Extend cpu frequency scaling with CCI - Basic network-support (ethernet controller + builtin switch + SFP Cages) depencies (i hope this list is complete and latest patches/series linked): "Add Bananapi R4 variants and add xsphy" (reviewed, partially applied): https://patchwork.kernel.org/project/linux-mediatek/list/?series=955733 "net: phy: mediatek: do not require syscon compatible for pio property": https://patchwork.kernel.org/project/netdevbpf/patch/20250510174933.154589-1-linux@fw-web.de/ for phy led function (RFC not yet reviewed, resent without RFC) for 2.5g phy function (currently disabled): - net: ethernet: mtk_eth_soc: add support for MT7988 internal 2.5G PHY (already merged to 6.15-net-next) - net: phy: mediatek: add driver for built-in 2.5G ethernet PHY on MT7988 https://patchwork.kernel.org/project/netdevbpf/patch/20250516102327.2014531-3-SkyLake.Huang@mediatek.com/ (v4) for SFP-Function (macs currently disabled): PCS clearance which is a 1.5 year discussion currently ongoing e.g. something like this (one of): * https://patchwork.kernel.org/project/netdevbpf/patch/20250511201250.3789083-4-ansuelsmth@gmail.com/ (v4) * https://patchwork.kernel.org/project/netdevbpf/patch/20250512161013.731955-4-sean.anderson@linux.dev/ (v4) * https://patchwork.kernel.org/project/netdevbpf/patch/ba4e359584a6b3bc4b3470822c42186d5b0856f9.1721910728.git.daniel@makrotopia.org/ full usxgmii driver: https://patchwork.kernel.org/project/netdevbpf/patch/07845ec900ba41ff992875dce12c622277592c32.1702352117.git.daniel@makrotopia.org/ first PCS-discussion is here: https://patchwork.kernel.org/project/netdevbpf/patch/8aa905080bdb6760875d62cb3b2b41258837f80e.1702352117.git.daniel@makrotopia.org/ and then dts nodes for sgmiisys+usxgmii when above depencies are solved the mac1/2 can be enabled and 2.5G phy/SFP slots will work. changes: v2: - change reg to list of items in eth binding - changed mt7530 binding: - unevaluatedProperties=false - mediatek,pio subproperty - from patternProperty to property - board specific properties like led function and labels moved to bpi-r4 dtsi Frank Wunderlich (14): dt-bindings: net: mediatek,net: update for mt7988 dt-bindings: net: dsa: mediatek,mt7530: add dsa-port definition for mt7988 dt-bindings: net: dsa: mediatek,mt7530: add internal mdio bus arm64: dts: mediatek: mt7988: add spi controllers arm64: dts: mediatek: mt7988: move uart0 and spi1 pins to soc dtsi arm64: dts: mediatek: mt7988: add cci node arm64: dts: mediatek: mt7988: add phy calibration efuse subnodes arm64: dts: mediatek: mt7988: add basic ethernet-nodes arm64: dts: mediatek: mt7988: add switch node arm64: dts: mediatek: mt7988a-bpi-r4: Add fan and coolingmaps arm64: dts: mediatek: mt7988a-bpi-r4: configure spi-nodes arm64: dts: mediatek: mt7988a-bpi-r4: add proc-supply for cci arm64: dts: mediatek: mt7988a-bpi-r4: add sfp cages and link to gmac arm64: dts: mediatek: mt7988a-bpi-r4: configure switch phys and leds .../bindings/net/dsa/mediatek,mt7530.yaml | 24 +- .../devicetree/bindings/net/mediatek,net.yaml | 10 +- .../mediatek/mt7988a-bananapi-bpi-r4-2g5.dts | 11 + .../dts/mediatek/mt7988a-bananapi-bpi-r4.dts | 18 + .../dts/mediatek/mt7988a-bananapi-bpi-r4.dtsi | 158 ++++++- arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 389 +++++++++++++++++- 6 files changed, 590 insertions(+), 20 deletions(-)