| Message ID | 20250513150234.2331221-1-heiko@sntech.de |
|---|---|
| Headers | show |
| Series | Add two board-families from Theobroma-Systems | expand |
Hi Heiko, On 5/13/25 5:02 PM, Heiko Stuebner wrote: [...] > + rk809: pmic@20 { > + compatible = "rockchip,rk809"; > + reg = <0x20>; > + #clock-cells = <0>; > + clock-output-names = "xin32k"; > + interrupt-parent = <&gpio0>; > + interrupts = <RK_PA7 IRQ_TYPE_LEVEL_LOW>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pmic_int>; > + wakeup-source; > + system-power-controller; Please order the properties alphabetically, system-power-controller is not where it should be. [...] > + panel { > + dsp_rst: dsp-rst { > + rockchip,pins = > + <0 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>; > + }; > + I would actually have a pull down here to hold the display in reset until the driver is probed and goes through the reset procedure? With the two above done: Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> Thanks! Quentin
Hi Heiko, On 5/13/25 5:02 PM, Heiko Stuebner wrote: [...] > + rk809: pmic@20 { > + compatible = "rockchip,rk809"; > + reg = <0x20>; > + #clock-cells = <0>; > + clock-output-names = "xin32k"; > + interrupt-parent = <&gpio0>; > + interrupts = <RK_PA7 IRQ_TYPE_LEVEL_LOW>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pmic_int>; > + wakeup-source; > + system-power-controller; > + Please order alphabetically here. [...] > +&pinctrl { > + camera { > + accel_int: accel-int { > + rockchip,pins = <2 RK_PB4 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + The accelerometer is not in the camera module like some of our other products, but on the PCBA directly, so I would put it in a different section in the pinctrl node. Can you have it this way too: rockchip,pins = <2 RK_PB4 RK_FUNC_GPIO &pcfg_pull_none>; so it is consistent with the other ones? [...] > + panel { > + dsp_rst: dsp-rst { > + rockchip,pins = > + <0 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>; Same remark as for Cobra, I assume we want a pull down here, to keep in reset until the driver probe drives the pin to orchestrate the reset? With all the above changed: Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> Thanks! Quentin
On Tue, May 13, 2025 at 05:02:32PM +0200, Heiko Stuebner wrote: > From: Heiko Stuebner <heiko.stuebner@cherry.de> > > Cobra are Touchscreen devices built around the PX30 SoC using > a variety of display options. > > The devices feature an EMMC, network port, usb host + OTG ports and > a 720x1280 display with a touchscreen. > > Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de> > --- > arch/arm64/boot/dts/rockchip/Makefile | 4 + > .../rockchip/px30-cobra-ltk050h3146w-a2.dts | 39 ++ > .../dts/rockchip/px30-cobra-ltk050h3146w.dts | 39 ++ > .../dts/rockchip/px30-cobra-ltk050h3148w.dts | 39 ++ > .../dts/rockchip/px30-cobra-ltk500hd1829.dts | 73 +++ > arch/arm64/boot/dts/rockchip/px30-cobra.dtsi | 566 ++++++++++++++++++ > 6 files changed, 760 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w-a2.dts > create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w.dts > create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3148w.dts > create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk500hd1829.dts > create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra.dtsi > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > index 3e8771ef69ba..8151e8bb1cd3 100644 > --- a/arch/arm64/boot/dts/rockchip/Makefile > +++ b/arch/arm64/boot/dts/rockchip/Makefile > @@ -1,4 +1,8 @@ > # SPDX-License-Identifier: GPL-2.0 > +dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-cobra-ltk050h3146w-a2.dtb > +dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-cobra-ltk050h3146w.dtb > +dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-cobra-ltk050h3148w.dtb > +dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-cobra-ltk500hd1829.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-evb.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-engicam-px30-core-ctouch2.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-engicam-px30-core-ctouch2-of10.dtb > diff --git a/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w-a2.dts b/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w-a2.dts > new file mode 100644 > index 000000000000..1d26164be7b8 > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w-a2.dts > @@ -0,0 +1,39 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2025 Cherry Embedded Solutions GmbH > + */ > + > +/dts-v1/; > +#include "px30-cobra.dtsi" > + > +/ { > + model = "Theobroma Systems Cobra with LTK050H3146W-A2 Display"; > + compatible = "tsd,px30-cobra-ltk050h3146w-a2", "tsd,px30-cobra", "rockchip,px30"; > +}; > + > +&dsi { > + status = "okay"; > + > + panel@0 { > + compatible = "leadtek,ltk050h3146w-a2"; > + reg = <0>; > + backlight = <&backlight>; > + iovcc-supply = <&vcc_1v8>; > + pinctrl-names = "default"; > + pinctrl-0 = <&dsp_rst>; > + reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>; > + vci-supply = <&vcc_2v8>; > + > + port { 'port' is not allowed by this binding. > + mipi_in_panel: endpoint { > + remote-endpoint = <&mipi_out_panel>; > + }; > + }; > + }; > +}; > + > +&dsi_out { > + mipi_out_panel: endpoint { > + remote-endpoint = <&mipi_in_panel>; > + }; > +}; > diff --git a/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w.dts b/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w.dts > new file mode 100644 > index 000000000000..82c6acdb4fae > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w.dts > @@ -0,0 +1,39 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2025 Cherry Embedded Solutions GmbH > + */ > + > +/dts-v1/; > +#include "px30-cobra.dtsi" > + > +/ { > + model = "Theobroma Systems Cobra with LTK050H3146W Display"; > + compatible = "tsd,px30-cobra-ltk050h3146w", "tsd,px30-cobra", "rockchip,px30"; > +}; > + > +&dsi { > + status = "okay"; > + > + panel@0 { > + compatible = "leadtek,ltk050h3146w"; > + reg = <0>; > + backlight = <&backlight>; > + iovcc-supply = <&vcc_1v8>; > + pinctrl-names = "default"; > + pinctrl-0 = <&dsp_rst>; > + reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>; > + vci-supply = <&vcc_2v8>; > + > + port { > + mipi_in_panel: endpoint { > + remote-endpoint = <&mipi_out_panel>; > + }; > + }; > + }; > +}; > + > +&dsi_out { > + mipi_out_panel: endpoint { > + remote-endpoint = <&mipi_in_panel>; > + }; > +}; > diff --git a/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3148w.dts b/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3148w.dts > new file mode 100644 > index 000000000000..94449132df38 > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3148w.dts > @@ -0,0 +1,39 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2025 Cherry Embedded Solutions GmbH > + */ > + > +/dts-v1/; > +#include "px30-cobra.dtsi" > + > +/ { > + model = "Theobroma Systems Cobra with ltk050h3148w Display"; > + compatible = "tsd,px30-cobra-ltk050h3148w", "tsd,px30-cobra", "rockchip,px30"; > +}; > + > +&dsi { > + status = "okay"; > + > + panel@0 { > + compatible = "leadtek,ltk050h3148w"; > + reg = <0>; > + backlight = <&backlight>; > + iovcc-supply = <&vcc_1v8>; > + pinctrl-names = "default"; > + pinctrl-0 = <&dsp_rst>; > + reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>; > + vci-supply = <&vcc_2v8>; > + > + port { > + mipi_in_panel: endpoint { > + remote-endpoint = <&mipi_out_panel>; > + }; > + }; > + }; > +}; > + > +&dsi_out { > + mipi_out_panel: endpoint { > + remote-endpoint = <&mipi_in_panel>; > + }; > +}; > diff --git a/arch/arm64/boot/dts/rockchip/px30-cobra-ltk500hd1829.dts b/arch/arm64/boot/dts/rockchip/px30-cobra-ltk500hd1829.dts > new file mode 100644 > index 000000000000..d7b639e7ccab > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/px30-cobra-ltk500hd1829.dts > @@ -0,0 +1,73 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2025 Cherry Embedded Solutions GmbH > + */ > + > +/dts-v1/; > +#include "px30-cobra.dtsi" > + > +/ { > + model = "Theobroma Systems Cobra prototype with LTK500HD1829 Display"; > + compatible = "tsd,px30-cobra-ltk500hd1829", "tsd,px30-cobra", "rockchip,px30"; > + > + aliases { > + mmc1 = &sdmmc; > + }; > +}; > + > +&dsi { > + status = "okay"; > + > + panel@0 { > + compatible = "leadtek,ltk500hd1829"; > + reg = <0>; > + backlight = <&backlight>; > + iovcc-supply = <&vcc_1v8>; > + pinctrl-names = "default"; > + pinctrl-0 = <&dsp_rst>; > + reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>; > + vcc-supply = <&vcc_2v8>; > + > + port { > + mipi_in_panel: endpoint { > + remote-endpoint = <&mipi_out_panel>; > + }; > + }; > + }; > +}; > + > +&dsi_out { > + mipi_out_panel: endpoint { > + remote-endpoint = <&mipi_in_panel>; > + }; > +}; > + > +&pinctrl { > + pinctrl-names = "default"; > + pinctrl-0 = <&cobra_pin_hog>, <&cobra_proto_hog>; > + > + hog { > + cobra_proto_hog: cobra-proto-hog { > + rockchip,pins = > + /* STUSB4500 open drain outout POWER_OK2, needs pull-up */ > + <3 RK_PB1 RK_FUNC_GPIO &pcfg_pull_up>, > + /* STUSB4500 open drain outout POWER_OK3, needs pull-up */ > + <3 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>; > + }; > + }; > +}; > + > +&sdmmc { > + bus-width = <4>; > + broken-cd; > + cap-sd-highspeed; > + pinctrl-names = "default"; > + pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>; > + sd-uhs-sdr12; > + sd-uhs-sdr25; > + sd-uhs-sdr50; > + sd-uhs-sdr104; > + vmmc-supply = <&vccio_sd>; > + vqmmc-supply = <&vccio_sd>; > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/rockchip/px30-cobra.dtsi b/arch/arm64/boot/dts/rockchip/px30-cobra.dtsi > new file mode 100644 > index 000000000000..77626f0d0a06 > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/px30-cobra.dtsi > @@ -0,0 +1,566 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2025 Cherry Embedded Solutions GmbH > + */ > + > +/dts-v1/; > +#include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/input/input.h> > +#include <dt-bindings/leds/common.h> > +#include <dt-bindings/pinctrl/rockchip.h> > +#include "px30.dtsi" > + > +/ { > + aliases { > + ethernet0 = &gmac; > + mmc0 = &emmc; > + }; > + > + chosen { > + stdout-path = "serial5:115200n8"; > + }; > + > + backlight: backlight { > + compatible = "pwm-backlight"; > + power-supply = <&vcc5v0_sys>; > + pwms = <&pwm0 0 25000 0>; > + }; > + > + beeper { > + compatible = "pwm-beeper"; > + pwms = <&pwm1 0 1000 0>; > + }; > + > + emmc_pwrseq: emmc-pwrseq { > + compatible = "mmc-pwrseq-emmc"; > + pinctrl-0 = <&emmc_reset>; > + pinctrl-names = "default"; > + reset-gpios = <&gpio1 RK_PB3 GPIO_ACTIVE_HIGH>; > + }; > + > + gpio-leds { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&heartbeat_led_pin>; > + > + /* > + * LED14 on the PCB. Typically NOT populated. > + */ > + led-0 { > + color = <LED_COLOR_ID_BLUE>; > + gpios = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>; > + label = "heartbeat"; > + linux,default-trigger = "heartbeat"; > + }; > + }; > + > + pwm-leds { > + compatible = "pwm-leds"; > + > + ring_red: led-0 { > + color = <LED_COLOR_ID_RED>; > + default-state = "off"; > + label = "ring_red"; > + pwms = <&pwm5 0 1000000 0>; > + max-brightness = <255>; > + }; > + > + ring_green: led-1 { > + color = <LED_COLOR_ID_GREEN>; > + default-state = "off"; > + label = "ring_green"; > + pwms = <&pwm6 0 1000000 0>; > + max-brightness = <255>; > + }; > + > + ring_blue: led-2 { > + color = <LED_COLOR_ID_BLUE>; > + default-state = "off"; > + label = "ring_blue"; > + pwms = <&pwm7 0 1000000 0>; > + max-brightness = <255>; > + }; > + }; > + > + /* also named 5V_Q7 in schematics */ > + vcc5v0_sys: regulator-vccsys { > + compatible = "regulator-fixed"; > + regulator-name = "vcc5v0_sys"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + }; > +}; > + > +&cpu0 { > + cpu-supply = <&vdd_arm>; > +}; > + > +&cpu1 { > + cpu-supply = <&vdd_arm>; > +}; > + > +&cpu2 { > + cpu-supply = <&vdd_arm>; > +}; > + > +&cpu3 { > + cpu-supply = <&vdd_arm>; > +}; > + > +&display_subsystem { > + status = "okay"; > +}; > + > +&dsi_dphy { > + status = "okay"; > +}; > + > +&emmc { > + bus-width = <8>; > + cap-mmc-highspeed; > + /* > + * For hs200 support, U-Boot would have to set the RK809 DCDC4 > + * rail to 1.8V from the default of 3.0V. It doesn't do that on > + * devices out in the field, so disable hs200. > + * mmc-hs200-1_8v; > + */ > + mmc-pwrseq = <&emmc_pwrseq>; > + non-removable; > + vmmc-supply = <&vcc_3v3>; > + vqmmc-supply = <&vcc_emmc>; > + status = "okay"; > +}; > + > +&gmac { > + clock_in_out = "output"; > + phy-handle = <&dp83825>; > + phy-supply = <&vcc_3v3>; > + status = "okay"; > +}; > + > +&gpu { > + mali-supply = <&vdd_log>; > + status = "okay"; > +}; > + > +/* I2C0 = PMIC, STUSB4500, RTC */ > +&i2c0 { > + status = "okay"; > + > + rk809: pmic@20 { > + compatible = "rockchip,rk809"; > + reg = <0x20>; > + #clock-cells = <0>; > + clock-output-names = "xin32k"; > + interrupt-parent = <&gpio0>; > + interrupts = <RK_PA7 IRQ_TYPE_LEVEL_LOW>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pmic_int>; > + wakeup-source; > + system-power-controller; > + > + vcc1-supply = <&vcc5v0_sys>; > + vcc2-supply = <&vcc5v0_sys>; > + vcc3-supply = <&vcc5v0_sys>; > + vcc4-supply = <&vcc5v0_sys>; > + vcc5-supply = <&vcc_3v3>; > + vcc6-supply = <&vcc_3v3>; > + vcc7-supply = <&vcc_3v3>; > + vcc9-supply = <&vcc5v0_sys>; > + > + regulators { > + vdd_log: DCDC_REG1 { > + regulator-name = "vdd_log"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <950000>; > + regulator-max-microvolt = <1350000>; > + regulator-ramp-delay = <6001>; > + > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-suspend-microvolt = <950000>; > + }; > + }; > + > + vdd_arm: DCDC_REG2 { > + regulator-name = "vdd_arm"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <950000>; > + regulator-max-microvolt = <1350000>; > + regulator-ramp-delay = <6001>; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + regulator-suspend-microvolt = <950000>; > + }; > + }; > + > + vcc_ddr: DCDC_REG3 { > + regulator-name = "vcc_ddr"; > + regulator-always-on; > + regulator-boot-on; > + > + regulator-state-mem { > + regulator-on-in-suspend; > + }; > + }; > + > + vcc_3v0_1v8: vcc_emmc: DCDC_REG4 { > + regulator-name = "vcc_3v0_1v8"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3000000>; > + > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-suspend-microvolt = <3000000>; > + }; > + }; > + > + vcc_3v3: DCDC_REG5 { > + regulator-name = "vcc_3v3"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-suspend-microvolt = <3300000>; > + }; > + }; > + > + vcc_1v8: LDO_REG2 { > + regulator-name = "vcc_1v8"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-suspend-microvolt = <1800000>; > + }; > + }; > + > + vcc_1v0: LDO_REG3 { > + regulator-name = "vcc_1v0"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1000000>; > + > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-suspend-microvolt = <1000000>; > + }; > + }; > + > + vcc_2v8: LDO_REG4 { > + regulator-name = "vcc_2v8"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2800000>; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + regulator-suspend-microvolt = <2800000>; > + }; > + }; > + > + /* > + * vccio_sd also supplies the vmmc supply on prototypes > + * with sd-slots, so needs to stay single voltage for > + * those. Production models don't have sd-slots anymore > + * and only supply vccio2 from this regulator. > + */ > + vccio_sd: LDO_REG5 { > + regulator-name = "vccio_sd"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3000000>; > + > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-suspend-microvolt = <3000000>; > + }; > + }; > + > + /* vcc_sdio also supplies the pull-up resistors for i2c1 */ > + vcc_sdio: LDO_REG6 { > + regulator-name = "vcc_sdio"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3000000>; > + > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-suspend-microvolt = <3300000>; > + }; > + }; > + > + vcc_lcd: LDO_REG7 { > + regulator-name = "vcc_lcd"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1000000>; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + regulator-suspend-microvolt = <1000000>; > + }; > + }; > + > + vcc_1v8_lcd: LDO_REG8 { > + regulator-name = "vcc_1v8_lcd"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-suspend-microvolt = <1800000>; > + }; > + }; > + > + vcca_1v8: LDO_REG9 { > + regulator-name = "vcca_1v8"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + regulator-suspend-microvolt = <1800000>; > + }; > + }; > + }; > + }; > +}; > + > +&i2c1 { > + clock-frequency = <100000>; > + status = "okay"; > +}; > + > +&i2c2 { > + clock-frequency = <100000>; > + i2c-scl-falling-time-ns = <50>; > + i2c-scl-rising-time-ns = <300>; > + status = "okay"; > + > + touchscreen@14 { > + compatible = "goodix,gt911"; > + reg = <0x14>; > + AVDD28-supply = <&vcc_2v8>; > + interrupt-parent = <&gpio0>; > + interrupts = <RK_PA1 IRQ_TYPE_LEVEL_LOW>; > + irq-gpios = <&gpio0 RK_PA1 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&tch_int &tch_rst>; > + reset-gpios = <&gpio0 RK_PB5 GPIO_ACTIVE_HIGH>; > + touchscreen-inverted-x; > + VDDIO-supply = <&vcc_3v3>; > + }; > +}; > + > +/* > + * Enable pull-ups to prevent floating pins when the touch > + * panel is not connected. > + */ > +&i2c2_xfer { > + rockchip,pins = > + <2 RK_PB7 2 &pcfg_pull_up>, > + <2 RK_PC0 2 &pcfg_pull_up>; > +}; > + > +&io_domains { > + vccio1-supply = <&vcc_sdio>; > + vccio2-supply = <&vccio_sd>; > + vccio3-supply = <&vcc_3v3>; > + vccio4-supply = <&vcc_3v3>; > + vccio5-supply = <&vcc_1v8>; > + vccio6-supply = <&vcc_emmc>; > + status = "okay"; > +}; > + > +&mdio { > + dp83825: ethernet-phy@0 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <0x0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&phy_rst>; > + reset-assert-us = <50000>; > + reset-deassert-us = <50000>; > + reset-gpios = <&gpio2 RK_PB6 GPIO_ACTIVE_LOW>; > + }; > +}; > + > +&pinctrl { > + pinctrl-names = "default"; > + pinctrl-0 = <&cobra_pin_hog>; > + > + hog { > + cobra_pin_hog: cobra-pin-hog { > + rockchip,pins = > + /* USB_HUB2_RESET */ > + <0 RK_PA5 RK_FUNC_GPIO &pcfg_output_high>, > + /* USB_HUB1_RESET */ > + <0 RK_PB4 RK_FUNC_GPIO &pcfg_output_high>, > + /* The default pull-down can keep the IC in reset. */ > + <3 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>; > + /* USB-A 5V enable */ > + <3 RK_PC0 RK_FUNC_GPIO &pcfg_output_high>, > + /* USB-A data enable */ > + <3 RK_PD3 RK_FUNC_GPIO &pcfg_output_high>, > + }; > + }; > + > + emmc { > + emmc_reset: emmc-reset { > + rockchip,pins = > + <1 RK_PB3 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + }; > + > + ethernet { > + phy_rst: phy-rst { > + rockchip,pins = > + <2 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + }; > + > + leds { > + heartbeat_led_pin: heartbeat-led-pin { > + rockchip,pins = > + <0 RK_PA0 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + }; > + > + panel { > + dsp_rst: dsp-rst { > + rockchip,pins = > + <0 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>; > + }; > + > + tch_int: tch-int { > + rockchip,pins = > + <0 RK_PA1 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + > + tch_rst: tch-rst { > + rockchip,pins = > + <0 RK_PB5 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + }; > + > + pmic { > + pmic_int: pmic-int { > + rockchip,pins = > + <0 RK_PA7 RK_FUNC_GPIO &pcfg_pull_up>; > + }; > + }; > +}; > + > +&pmu_io_domains { > + pmuio1-supply = <&vcc_3v3>; > + pmuio2-supply = <&vcc_3v3>; > + status = "okay"; > +}; > + > +&pwm0 { > + status = "okay"; > +}; > + > +&pwm1 { > + status = "okay"; > +}; > + > +&pwm5 { > + status = "okay"; > +}; > + > +&pwm6 { > + status = "okay"; > +}; > + > +&pwm7 { > + status = "okay"; > +}; > + > +&saradc { > + vref-supply = <&vcc_1v8>; > + status = "okay"; > +}; > + > +&tsadc { > + status = "okay"; > +}; > + > +&u2phy { > + status = "okay"; > +}; > + > +&u2phy_host { > + status = "okay"; > +}; > + > +&u2phy_otg { > + status = "okay"; > +}; > + > +&uart1 { > + /delete-property/ dmas; > + /delete-property/ dma-names; > + pinctrl-names = "default"; > + pinctrl-0 = <&uart1_xfer>; > + status = "okay"; > +}; > + > +&uart5 { > + pinctrl-0 = <&uart5_xfer>; > + status = "okay"; > +}; > + > +&usb20_otg { > + status = "okay"; > +}; > + > +&usb_host0_ehci { > + status = "okay"; > +}; > + > +&usb_host0_ohci { > + status = "okay"; > +}; > + > +&vopb { > + status = "okay"; > +}; > + > +&vopb_mmu { > + status = "okay"; > +}; > + > +&vopl { > + status = "disabled"; > +}; > + > +&vopl_mmu { > + status = "disabled"; > +}; > + > +&wdt { > + status = "okay"; > +}; > -- > 2.47.2 >
Am Mittwoch, 14. Mai 2025, 15:39:51 Mitteleuropäische Sommerzeit schrieb Rob Herring: > On Tue, May 13, 2025 at 05:02:32PM +0200, Heiko Stuebner wrote: > > From: Heiko Stuebner <heiko.stuebner@cherry.de> > > > > Cobra are Touchscreen devices built around the PX30 SoC using > > a variety of display options. > > > > The devices feature an EMMC, network port, usb host + OTG ports and > > a 720x1280 display with a touchscreen. > > > > Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de> > > --- > > arch/arm64/boot/dts/rockchip/Makefile | 4 + > > .../rockchip/px30-cobra-ltk050h3146w-a2.dts | 39 ++ > > .../dts/rockchip/px30-cobra-ltk050h3146w.dts | 39 ++ > > .../dts/rockchip/px30-cobra-ltk050h3148w.dts | 39 ++ > > .../dts/rockchip/px30-cobra-ltk500hd1829.dts | 73 +++ > > arch/arm64/boot/dts/rockchip/px30-cobra.dtsi | 566 ++++++++++++++++++ > > 6 files changed, 760 insertions(+) > > create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w-a2.dts > > create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w.dts > > create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3148w.dts > > create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk500hd1829.dts > > create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra.dtsi > > > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > > index 3e8771ef69ba..8151e8bb1cd3 100644 > > --- a/arch/arm64/boot/dts/rockchip/Makefile > > +++ b/arch/arm64/boot/dts/rockchip/Makefile > > @@ -1,4 +1,8 @@ > > # SPDX-License-Identifier: GPL-2.0 > > +dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-cobra-ltk050h3146w-a2.dtb > > +dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-cobra-ltk050h3146w.dtb > > +dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-cobra-ltk050h3148w.dtb > > +dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-cobra-ltk500hd1829.dtb > > dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-evb.dtb > > dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-engicam-px30-core-ctouch2.dtb > > dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-engicam-px30-core-ctouch2-of10.dtb > > diff --git a/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w-a2.dts b/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w-a2.dts > > new file mode 100644 > > index 000000000000..1d26164be7b8 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w-a2.dts > > @@ -0,0 +1,39 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +/* > > + * Copyright (c) 2025 Cherry Embedded Solutions GmbH > > + */ > > + > > +/dts-v1/; > > +#include "px30-cobra.dtsi" > > + > > +/ { > > + model = "Theobroma Systems Cobra with LTK050H3146W-A2 Display"; > > + compatible = "tsd,px30-cobra-ltk050h3146w-a2", "tsd,px30-cobra", "rockchip,px30"; > > +}; > > + > > +&dsi { > > + status = "okay"; > > + > > + panel@0 { > > + compatible = "leadtek,ltk050h3146w-a2"; > > + reg = <0>; > > + backlight = <&backlight>; > > + iovcc-supply = <&vcc_1v8>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&dsp_rst>; > > + reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>; > > + vci-supply = <&vcc_2v8>; > > + > > + port { > > 'port' is not allowed by this binding. It is since last week [0], because the Leadtek displays got their port property added. [0] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=bf0636f4348e098e2338eebbe42d7780c58a1195
Both the Cobra and PP1516 boards are based around the PX30 SoC and can be found with a variety of display options. As new boards should not use the deprecated snps,reset-* properties in the gmac node, I also added a core mdio-node for the gmac and converted the Theobroma Ringneck board over. Testing with the new node both before and after converting Ringneck showed the board finding its network both when booting locally and from the tftp/nfs. changes in v2: - add received Acks/Reviews - drop "rockchip" prefix from system-power-controller (Diederik) - split out prototype-pins to prototype variant - address Quentin's review comments - ethernet0 alias for Cobra - a number more pinctrl entries for gpios - drop unused slp pinctrl entries - additional comments - use gpio-constants for pmic int - ordering (nodes + properties) - clarify vccio_sd more - interrupt line for pp1516 accelerometer Heiko Stuebner (6): arm64: dts: rockchip: add basic mdio node to px30 arm64: dts: rockchip: move reset to dedicated eth-phy node on ringneck dt-bindings: arm: rockchip: add PX30-Cobra boards from Theobroma Systems arm64: dts: rockchip: add px30-cobra base dtsi and board variants dt-bindings: arm: rockchip: add PX30-PP1516 boards from Theobroma Systems arm64: dts: rockchip: add px30-pp1516 base dtsi and board variants .../devicetree/bindings/arm/rockchip.yaml | 18 + arch/arm64/boot/dts/rockchip/Makefile | 6 + .../rockchip/px30-cobra-ltk050h3146w-a2.dts | 39 ++ .../dts/rockchip/px30-cobra-ltk050h3146w.dts | 39 ++ .../dts/rockchip/px30-cobra-ltk050h3148w.dts | 39 ++ .../dts/rockchip/px30-cobra-ltk500hd1829.dts | 73 +++ arch/arm64/boot/dts/rockchip/px30-cobra.dtsi | 566 +++++++++++++++++ .../rockchip/px30-pp1516-ltk050h3146w-a2.dts | 39 ++ .../dts/rockchip/px30-pp1516-ltk050h3148w.dts | 39 ++ arch/arm64/boot/dts/rockchip/px30-pp1516.dtsi | 599 ++++++++++++++++++ .../boot/dts/rockchip/px30-ringneck.dtsi | 22 +- arch/arm64/boot/dts/rockchip/px30.dtsi | 6 + 12 files changed, 1482 insertions(+), 3 deletions(-) create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w-a2.dts create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w.dts create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3148w.dts create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk500hd1829.dts create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra.dtsi create mode 100644 arch/arm64/boot/dts/rockchip/px30-pp1516-ltk050h3146w-a2.dts create mode 100644 arch/arm64/boot/dts/rockchip/px30-pp1516-ltk050h3148w.dts create mode 100644 arch/arm64/boot/dts/rockchip/px30-pp1516.dtsi