mbox series

[0/7] msm8937/msm8976/qcs404 icc patches

Message ID 20240609182112.13032-1-a39.skl@gmail.com
Headers show
Series msm8937/msm8976/qcs404 icc patches | expand

Message

Adam Skladowski June 9, 2024, 6:20 p.m. UTC 
This series introduce new ICC drivers for some legacy socs
while at it also updates a bit of qcs404 driver which seems
to not receive much attention lately.
Please take in consideration i do not own any qcs404 board
so i cannot test anything else than if it compiles.

Adam Skladowski (7):
  dt-bindings: interconnect: Add Qualcomm MSM8976 DT bindings
  interconnect: qcom: Add MSM8976 interconnect provider driver
  dt-bindings: interconnect: Add Qualcomm MSM8937 DT bindings
  interconnect: qcom: Add MSM8937 interconnect provider driver
  interconnect: qcom: qcs404: Introduce AP-owned nodes
  interconnect: qcom: qcs404: Add regmaps and more bus descriptions
  dt-bindings: interconnect: qcom: msm8939: Fix example

 .../bindings/interconnect/qcom,msm8937.yaml   |   81 +
 .../bindings/interconnect/qcom,msm8939.yaml   |   22 +-
 .../bindings/interconnect/qcom,msm8976.yaml   |  107 ++
 drivers/interconnect/qcom/Kconfig             |   18 +
 drivers/interconnect/qcom/Makefile            |    4 +
 drivers/interconnect/qcom/msm8937.c           | 1374 ++++++++++++++++
 drivers/interconnect/qcom/msm8976.c           | 1443 +++++++++++++++++
 drivers/interconnect/qcom/qcs404.c            |  126 +-
 .../dt-bindings/interconnect/qcom,msm8937.h   |   93 ++
 .../dt-bindings/interconnect/qcom,msm8976.h   |   97 ++
 10 files changed, 3354 insertions(+), 11 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,msm8937.yaml
 create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,msm8976.yaml
 create mode 100644 drivers/interconnect/qcom/msm8937.c
 create mode 100644 drivers/interconnect/qcom/msm8976.c
 create mode 100644 include/dt-bindings/interconnect/qcom,msm8937.h
 create mode 100644 include/dt-bindings/interconnect/qcom,msm8976.h

Comments

Krzysztof Kozlowski June 10, 2024, 12:52 p.m. UTC | #1 
On 09/06/2024 20:20, Adam Skladowski wrote:
> Add driver for interconnect busses found in MSM8976 based platforms.
> The topology consists of four NoCs that are partially controlled
> by a RPM processor.
> 
> Signed-off-by: Adam Skladowski <a39.skl@gmail.com>

> +
> +static const struct qcom_icc_desc msm8976_snoc_mm = {
> +	.type = QCOM_ICC_NOC,
> +	.nodes = msm8976_snoc_mm_nodes,
> +	.num_nodes = ARRAY_SIZE(msm8976_snoc_mm_nodes),
> +	.bus_clk_desc = &bus_2_clk,
> +	.regmap_cfg = &msm8976_snoc_regmap_config,
> +	.qos_offset = 0x7000,
> +	.ab_coeff = 154,
> +};
> +
> +static const struct of_device_id msm8976_noc_of_match[] = {
> +	{ .compatible = "qcom,msm8976-bimc", .data = &msm8976_bimc },
> +	{ .compatible = "qcom,msm8976-pcnoc", .data = &msm8976_pcnoc },
> +	{ .compatible = "qcom,msm8976-snoc", .data = &msm8976_snoc },
> +	{ .compatible = "qcom,msm8976-snoc-mm", .data = &msm8976_snoc_mm },

Please run scripts/checkpatch.pl and fix reported warnings. Then please
run `scripts/checkpatch.pl --strict` and (probably) fix more warnings.
Some warnings can be ignored, especially from --strict run, but the code
here looks like it needs a fix. Feel free to get in touch if the warning
is not clear.

undocumented compatible



Best regards,
Krzysztof
Krzysztof Kozlowski June 10, 2024, 12:54 p.m. UTC | #2 
On 09/06/2024 20:20, Adam Skladowski wrote:
> Add driver for interconnect busses found in MSM8937 based platforms.
> The topology consists of four NoCs that are partially controlled
> by a RPM processor.
> 
> Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
> ---

> +
> +static const struct of_device_id msm8937_noc_of_match[] = {
> +	{ .compatible = "qcom,msm8937-bimc", .data = &msm8937_bimc },
> +	{ .compatible = "qcom,msm8937-pcnoc", .data = &msm8937_pcnoc },
> +	{ .compatible = "qcom,msm8937-snoc", .data = &msm8937_snoc },
> +	{ .compatible = "qcom,msm8937-snoc-mm", .data = &msm8937_snoc_mm },

Please run scripts/checkpatch.pl and fix reported warnings. Then please
run `scripts/checkpatch.pl --strict` and (probably) fix more warnings.
Some warnings can be ignored, especially from --strict run, but the code
here looks like it needs a fix. Feel free to get in touch if the warning
is not clear.


Best regards,
Krzysztof