| Message ID | 20240416-pm8xxx-vibrator-new-design-v11-0-7b1c951e1515@quicinc.com |
|---|---|
| Headers | show |
| Series | Add support for vibrator in multiple PMICs | expand |
On Tue, 16 Apr 2024 at 05:44, Fenglin Wu via B4 Relay <devnull+quic_fenglinw.quicinc.com@kernel.org> wrote: > > Add SW support for the vibrator module inside PMI632, PM7250B, PM7325B, PM7550BA. > It is very similar to the vibrator module inside PM8916 which is supported in > pm8xxx-vib driver but just the drive amplitude is controlled with 2 registers, > and the register base offset in each PMIC is different. > > Changes in v11: > 1. Drop the 1st patch since it has been applied > 2. Update to address review comments Please abstain from such changelog entries. Which comments were addressed? How were they addressed? > Link to v10: https://lore.kernel.org/r/20240412-pm8xxx-vibrator-new-design-v10-0-0ec0ad133866@quicinc.com > > Changes in v10: > 1. Add Fixes tag > 2. Update SSBI vibrator to use DT 'reg' value > 3. Add drv_in_step flag for programming vibrator level in steps > Link to v9: https://lore.kernel.org/r/20240411-pm8xxx-vibrator-new-design-v9-0-7bf56cb92b28@quicinc.com > > Changes in v9: > 1. Add a preceding change to correct VIB_MAX_LEVELS calculation > 2. Address review comments from Konrad > Link to v8: https://lore.kernel.org/r/20240401-pm8xxx-vibrator-new-design-v8-0-6f2b8b03b4c7@quicinc.com > > Changes in v8: > 1. Remove hw_type, and still keep the register info in match data > 2. Update to use register offset in pm8xxx_regs, and the base address > defined in DT for SPMI vibrator will be added in register access > 3. Update voltage output range for SPMI vibrator which has 2 bytes drive > registers > > Changes in v7: > 1. Fix a typo: SSBL_VIB_DRV_REG --> SSBI_VIB_DRV_REG > 2. Move the hw_type switch case in pm8xxx_vib_set() to the refactoring > change. > > Changes in v6: > 1. Add "qcom,pmi632-vib" as a standalone compatible string. > > Changes in v5: > 1. Drop "qcom,spmi-vib-gen2" generic compatible string as requested > and use device specific compatible strings only. > > Changes in v4: > 1. Update to use the combination of the HW type and register offset > as the constant match data, the register base address defined in > 'reg' property will be added when accessing SPMI registers using > regmap APIs. > 2. Remove 'qcom,spmi-vib-gen1' generic compatible string. > > Changes in v3: > 1. Refactor the driver to support different type of the vibrators with > better flexibility by introducing the HW type with corresponding > register fields definitions. > 2. Add 'qcom,spmi-vib-gen1' and 'qcom,spmi-vib-gen2' compatible > strings, and add PMI632, PM7250B, PM7325B, PM7550BA as compatbile as > spmi-vib-gen2. > > Changes in v2: > Remove the "pm7550ba-vib" compatible string as it's compatible with pm7325b. > > Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com> > --- > Fenglin Wu (3): > input: pm8xxx-vibrator: refactor to support new SPMI vibrator > dt-bindings: input: qcom,pm8xxx-vib: add new SPMI vibrator module > input: pm8xxx-vibrator: add new SPMI vibrator support > > .../devicetree/bindings/input/qcom,pm8xxx-vib.yaml | 16 +++- > drivers/input/misc/pm8xxx-vibrator.c | 93 ++++++++++++++++------ > 2 files changed, 80 insertions(+), 29 deletions(-) > --- > base-commit: 48c0687a322d54ac7e7a685c0b6db78d78f593af > change-id: 20240328-pm8xxx-vibrator-new-design-e5811ad59e8a > > Best regards, > -- > Fenglin Wu <quic_fenglinw@quicinc.com> > >
On Tue, 16 Apr 2024 at 05:44, Fenglin Wu via B4 Relay <devnull+quic_fenglinw.quicinc.com@kernel.org> wrote: > > From: Fenglin Wu <quic_fenglinw@quicinc.com> > > Currently, vibrator control register addresses are hard coded, > including the base address and offsets, it's not flexible to > support new SPMI vibrator module which is usually included in > different PMICs with different base address. Refactor it by using > the base address defined in devicetree. > > Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com> > --- > drivers/input/misc/pm8xxx-vibrator.c | 41 ++++++++++++++++++++++-------------- > 1 file changed, 25 insertions(+), 16 deletions(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Tue, 16 Apr 2024 at 05:44, Fenglin Wu via B4 Relay <devnull+quic_fenglinw.quicinc.com@kernel.org> wrote: > > From: Fenglin Wu <quic_fenglinw@quicinc.com> > > Add support for a new SPMI vibrator module which is very similar > to the vibrator module inside PM8916 but has a finer drive voltage > step and different output voltage range, its drive level control > is expanded across 2 registers. The vibrator module can be found > in following Qualcomm PMICs: PMI632, PM7250B, PM7325B, PM7550BA. > > Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com> > --- > drivers/input/misc/pm8xxx-vibrator.c | 52 +++++++++++++++++++++++++++++------- > 1 file changed, 43 insertions(+), 9 deletions(-) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On 4/16/24 04:44, Fenglin Wu via B4 Relay wrote: > From: Fenglin Wu <quic_fenglinw@quicinc.com> > > Currently, vibrator control register addresses are hard coded, > including the base address and offsets, it's not flexible to > support new SPMI vibrator module which is usually included in > different PMICs with different base address. Refactor it by using > the base address defined in devicetree. > > Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On 4/16/24 04:44, Fenglin Wu via B4 Relay wrote: > From: Fenglin Wu <quic_fenglinw@quicinc.com> > > Add support for a new SPMI vibrator module which is very similar > to the vibrator module inside PM8916 but has a finer drive voltage > step and different output voltage range, its drive level control > is expanded across 2 registers. The vibrator module can be found > in following Qualcomm PMICs: PMI632, PM7250B, PM7325B, PM7550BA. > > Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On 16/04/2024 04:44, Fenglin Wu via B4 Relay wrote: > Add SW support for the vibrator module inside PMI632, PM7250B, PM7325B, PM7550BA. > It is very similar to the vibrator module inside PM8916 which is supported in > pm8xxx-vib driver but just the drive amplitude is controlled with 2 registers, > and the register base offset in each PMIC is different. > > Changes in v11: > 1. Drop the 1st patch since it has been applied > 2. Update to address review comments Everything is an update. Such changelog is not really helping. Be specific. Best regards, Krzysztof
On Tue, Apr 16, 2024 at 10:44:31AM +0800, Fenglin Wu via B4 Relay wrote: > Add SW support for the vibrator module inside PMI632, PM7250B, PM7325B, PM7550BA. > It is very similar to the vibrator module inside PM8916 which is supported in > pm8xxx-vib driver but just the drive amplitude is controlled with 2 registers, > and the register base offset in each PMIC is different. Applied the lot, thank you.
Add SW support for the vibrator module inside PMI632, PM7250B, PM7325B, PM7550BA. It is very similar to the vibrator module inside PM8916 which is supported in pm8xxx-vib driver but just the drive amplitude is controlled with 2 registers, and the register base offset in each PMIC is different. Changes in v11: 1. Drop the 1st patch since it has been applied 2. Update to address review comments Link to v10: https://lore.kernel.org/r/20240412-pm8xxx-vibrator-new-design-v10-0-0ec0ad133866@quicinc.com Changes in v10: 1. Add Fixes tag 2. Update SSBI vibrator to use DT 'reg' value 3. Add drv_in_step flag for programming vibrator level in steps Link to v9: https://lore.kernel.org/r/20240411-pm8xxx-vibrator-new-design-v9-0-7bf56cb92b28@quicinc.com Changes in v9: 1. Add a preceding change to correct VIB_MAX_LEVELS calculation 2. Address review comments from Konrad Link to v8: https://lore.kernel.org/r/20240401-pm8xxx-vibrator-new-design-v8-0-6f2b8b03b4c7@quicinc.com Changes in v8: 1. Remove hw_type, and still keep the register info in match data 2. Update to use register offset in pm8xxx_regs, and the base address defined in DT for SPMI vibrator will be added in register access 3. Update voltage output range for SPMI vibrator which has 2 bytes drive registers Changes in v7: 1. Fix a typo: SSBL_VIB_DRV_REG --> SSBI_VIB_DRV_REG 2. Move the hw_type switch case in pm8xxx_vib_set() to the refactoring change. Changes in v6: 1. Add "qcom,pmi632-vib" as a standalone compatible string. Changes in v5: 1. Drop "qcom,spmi-vib-gen2" generic compatible string as requested and use device specific compatible strings only. Changes in v4: 1. Update to use the combination of the HW type and register offset as the constant match data, the register base address defined in 'reg' property will be added when accessing SPMI registers using regmap APIs. 2. Remove 'qcom,spmi-vib-gen1' generic compatible string. Changes in v3: 1. Refactor the driver to support different type of the vibrators with better flexibility by introducing the HW type with corresponding register fields definitions. 2. Add 'qcom,spmi-vib-gen1' and 'qcom,spmi-vib-gen2' compatible strings, and add PMI632, PM7250B, PM7325B, PM7550BA as compatbile as spmi-vib-gen2. Changes in v2: Remove the "pm7550ba-vib" compatible string as it's compatible with pm7325b. Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com> --- Fenglin Wu (3): input: pm8xxx-vibrator: refactor to support new SPMI vibrator dt-bindings: input: qcom,pm8xxx-vib: add new SPMI vibrator module input: pm8xxx-vibrator: add new SPMI vibrator support .../devicetree/bindings/input/qcom,pm8xxx-vib.yaml | 16 +++- drivers/input/misc/pm8xxx-vibrator.c | 93 ++++++++++++++++------ 2 files changed, 80 insertions(+), 29 deletions(-) --- base-commit: 48c0687a322d54ac7e7a685c0b6db78d78f593af change-id: 20240328-pm8xxx-vibrator-new-design-e5811ad59e8a Best regards,