| Message ID | 20240328-asrc_8qxp-v8-0-801cd6bb5be2@nxp.com |
|---|---|
| Headers | show |
| Series | arm64: dts: imx8qxp add asrc and sai | expand |
On Thu, 28 Mar 2024 10:51:32 -0400, Frank Li wrote: > Update binding doc to avoid warning. > Change from v1 to v2 > - Fixed dts DTB_CHECK warning > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/5] ASoC: dt-bindings: fsl,imx-asrc/spdif: Add power-domains property commit: 9b21531866fced634bcc7fca33667c7ef258433f [2/5] ASoC: dt-bindings: fsl,imx-asrc: update max interrupt numbers commit: 82330327ce03889f20072cef5167499d51cdf260 [3/5] ASoC: dt-bindings: fsl-sai: allow only one dma-names commit: 7b5f2072657a9041cbaf4ba139f672be11694ca3 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Thu, Mar 28, 2024 at 10:51:36AM -0400, Frank Li wrote: > lpcg cell0 should be clock's 'indices' instead of 'index'. > > imx_lpcg_of_clk_src_get(struct of_phandle_args *clkspec, void *data) > { > struct clk_hw_onecell_data *hw_data = data; > unsigned int idx = clkspec->args[0] / 4; > > .... > } > > <@sai0_lpcg 1> will be the same as <@sai_lpcg 0>. > > Replace 0 with IMX_LPCG_CLK_0 and replace 1 with IMX_LPCG_CLK_4. > > It can work at iMX8QXP because IMX_LPCG_CLK_4 is ipg clock, which already > enabled. But for iMX8QM IMX_LPCG_CLK_4 is mclk, which trigger issue. > > Fixes: 0a9279e9ae88 ("arm64: dts: imx8qxp: Add audio SAI nodes") > Signed-off-by: Frank Li <Frank.Li@nxp.com> Applied, thanks!
On Thu, Mar 28, 2024 at 10:51:37AM -0400, Frank Li wrote: > Add asrc[0,1], esai0, spdif0, sai[4,5] and related lpcg node for > imx8 audio subsystem. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> Applied, thanks!
Update binding doc to avoid warning. Change from v1 to v2 - Fixed dts DTB_CHECK warning Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Changes in v8: binding: - Add rob's review tag dts: - Add fixed patch to fix sai0 lpcg index - Update other node lpcg index - Remove extra space after = - Link to v7: https://lore.kernel.org/r/20240318-asrc_8qxp-v7-0-01ce5264a761@nxp.com Changes in v7: - Using rob method for dma-names - Drop conor acked tag form dma-names and interrupt patches - Fixed warning for interrupts - Pass dt_bindng check make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 dt_binding_check DT_SCHEMA_FILES=fsl,sai.yaml LINT Documentation/devicetree/bindings DTEX Documentation/devicetree/bindings/sound/fsl,sai.example.dts CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json DTC_CHK Documentation/devicetree/bindings/sound/fsl,sai.example.dtb make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 dt_binding_check DT_SCHEMA_FILES=fsl,spdif.yaml LINT Documentation/devicetree/bindings DTEX Documentation/devicetree/bindings/sound/fsl,spdif.example.dts CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json DTC_CHK Documentation/devicetree/bindings/sound/fsl,spdif.example.dtb make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 dt_binding_check DT_SCHEMA_FILES=fsl,imx-asrc.yaml LINT Documentation/devicetree/bindings DTEX Documentation/devicetree/bindings/sound/fsl,imx-asrc.example.dts CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json DTC_CHK Documentation/devicetree/bindings/sound/fsl,imx-asrc.example.dtb - Pass DTB_CHECK, below warning exist because binding doc still be txt. from schema $id: http://devicetree.org/schemas/dma/fsl,edma.yaml# arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: /bus@59000000/amix@59840000: failed to match any schema with compatible: ['fsl,imx8qm-audmix'] - Link to v6: https://lore.kernel.org/r/20240308-asrc_8qxp-v6-0-e08f6d030e09@nxp.com Changes in v6: - Add interrupt description in binding doc according to rob suggestion - Link to v5: https://lore.kernel.org/r/20240307-asrc_8qxp-v5-0-db363740368d@nxp.com Changes in v5: - using rob's suggest logic after fix maxItems. - sort dts nodes. - remove spdif1. Add later when do 8qm upstream - Link to v4: https://lore.kernel.org/r/20240305-asrc_8qxp-v4-0-c61b98046591@nxp.com Changes in v4: Combine comments' from v2 and v3. I hope I address everythings. - Krzysztof's comments - add reson about why change - rob's comments using rob's suggest logic to restrict interrupt number but for dma-names, still need use oneOf to cover 3 case - [rx, tx] - [rx] - [tx] oneOf - items: - tx - rx - enums: [rx, tx] - Conor's comments - add power-domains required for imx8qxp and imx8qm - remove dmas descript, not allow use index to get dma-channel. Current no user using this method. - Link to v3: https://lore.kernel.org/r/20240228-asrc_8qxp-v3-0-d4d5935fd3aa@nxp.com Changes in v3: - Fixed dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,spdif.example.dtb: spdif@2004000: interrupts: [[0, 52, 4]] is too short from schema $id: http://devicetree.org/schemas/sound/fsl,spdif.yaml# - Link to v2: https://lore.kernel.org/r/20240227-asrc_8qxp-v2-0-521bcc7eb1c0@nxp.com --- Frank Li (5): ASoC: dt-bindings: fsl,imx-asrc/spdif: Add power-domains property ASoC: dt-bindings: fsl,imx-asrc: update max interrupt numbers ASoC: dt-bindings: fsl-sai: allow only one dma-names arm64: dts: imx8: fix audio lpcg index arm64: dts: imx8qxp: add asrc[0,1], esai0, spdif0 and sai[4,5] .../devicetree/bindings/sound/fsl,imx-asrc.yaml | 14 + .../devicetree/bindings/sound/fsl,sai.yaml | 6 +- .../devicetree/bindings/sound/fsl,spdif.yaml | 35 ++- arch/arm64/boot/dts/freescale/imx8-ss-audio.dtsi | 285 ++++++++++++++++++++- 4 files changed, 327 insertions(+), 13 deletions(-) --- base-commit: 8552c902efe7ef670b6961fb8885b67961aeb629 change-id: 20240227-asrc_8qxp-25aa6783840f Best regards, --- Frank Li <Frank.Li@nxp.com>