| Message ID | 20240319132503.80628-1-prabhakar.mahadev-lad.rj@bp.renesas.com |
|---|---|
| Headers | show |
| Series | Add RIIC support for Renesas RZ/V2H SoC | expand |
On Tue, Mar 19, 2024 at 2:26 PM Prabhakar <prabhakar.csengg@gmail.com> wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Introduce helper functions for performing I2C read and write operations > in the RIIC driver. > > These helper functions lay the groundwork for adding support for the > RZ/V2H SoC. This is essential because the register offsets for the RZ/V2H > SoC differ from those of the RZ/A SoC. By abstracting the read and write > operations, we can seamlessly adapt the driver to support different SoC > variants without extensive modifications. > > This patch is part of the preparation process for integrating support for > the RZ/V2H SoC into the RIIC driver. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > v2->v3 > - Made val as second argument for riic_writeb Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
On Tue, Mar 19, 2024 at 01:25:01PM +0000, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Introduce helper functions for performing I2C read and write operations > in the RIIC driver. > > These helper functions lay the groundwork for adding support for the > RZ/V2H SoC. This is essential because the register offsets for the RZ/V2H > SoC differ from those of the RZ/A SoC. By abstracting the read and write > operations, we can seamlessly adapt the driver to support different SoC > variants without extensive modifications. > > This patch is part of the preparation process for integrating support for > the RZ/V2H SoC into the RIIC driver. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Looks good, builds fine: Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
On Tue, Mar 19, 2024 at 01:25:02PM +0000, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > With an increasing number of SoCs reusing this driver, each with slight > variations in the RIIC IP, it becomes necessary to support passing these > details as OF data. This approach simplifies the extension of the driver > for other SoCs. > > This patch lays the groundwork for adding support for the Renesas RZ/V2H > SoC. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
On Tue, Mar 19, 2024 at 01:25:03PM +0000, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Extend the RIIC driver to support the RZ/V2H(P) ("R9A09G057") SoC. It > accomplishes this by appending the compatible string list and passing > the RZ/V2H-specific OF data. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Hi On Tue, 19 Mar 2024 13:24:59 +0000, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Hi all, > > This patch series aims to add RIIC support for Renesas RZ/V2H(P) SoC. > > v2->v3 > - Included RB tags > - For riic_writeb() now passing val as second argument and > offset as third argument > > [...] Applied to i2c/i2c-host on git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git Thank you, Andi Patches applied =============== [1/4] dt-bindings: i2c: renesas,riic: Document R9A09G057 support commit: 1de515913c0fd8704d72d47ca5282e33b94d0992 [2/4] i2c: riic: Introduce helper functions for I2C read/write operations commit: 8c6a8f350c6338070b12ad62a71314dbea9e91db [3/4] i2c: riic: Pass register offsets and chip details as OF data commit: fbe81ad8b4242980d951926015e4fe306dccf5b6 [4/4] i2c: riic: Add support for R9A09G057 SoC commit: 6d7c1c58c11c6fa5e7a4380478151d0860664601
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Hi all, This patch series aims to add RIIC support for Renesas RZ/V2H(P) SoC. v2->v3 - Included RB tags - For riic_writeb() now passing val as second argument and offset as third argument v1->v2 - Dropped dt binding which update the comment. - Used a const for V2H SoC instead of enum in items list - Dropped internal review tags - Renamed i2c read/write to riic_readb/riic_writeb - Made riic as first parameter for riic_writeb - Dropped family from struct riic_of_data - Included RIIC_REG_END in enum list as flexible array member in a struct with no named members is not allowed Cheers, Prabhakar Lad Prabhakar (4): dt-bindings: i2c: renesas,riic: Document R9A09G057 support i2c: riic: Introduce helper functions for I2C read/write operations i2c: riic: Pass register offsets and chip details as OF data i2c: riic: Add support for R9A09G057 SoC .../devicetree/bindings/i2c/renesas,riic.yaml | 19 +-- drivers/i2c/busses/i2c-riic.c | 125 +++++++++++++----- 2 files changed, 100 insertions(+), 44 deletions(-)