| Message ID | 20240304-pm4125-typec-v4-0-f3601a16f9ea@linaro.org |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: qrb2210-rb1: enable Type-C support | expand |
On Mon, Mar 04, 2024 at 11:26:09AM +0200, Dmitry Baryshkov wrote: > Reuse Type-C support implemented for the PMI632 PMIC (found on Qualcomm > Robotics RB2 platform) and implement Type-C handling for the Qualcomm > Robotics RB1 platform. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Patch 1 added, 2 did not apply to my tree :(
On Mon, 4 Mar 2024 at 11:49, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Mon, Mar 04, 2024 at 11:26:09AM +0200, Dmitry Baryshkov wrote: > > Reuse Type-C support implemented for the PMI632 PMIC (found on Qualcomm > > Robotics RB2 platform) and implement Type-C handling for the Qualcomm > > Robotics RB1 platform. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Patch 1 added, 2 did not apply to my tree :( Thank you! Yes, patch 2 should go through arm-soc.
On Mon, Mar 04, 2024 at 11:51:27AM +0200, Dmitry Baryshkov wrote: > On Mon, 4 Mar 2024 at 11:49, Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > > > On Mon, Mar 04, 2024 at 11:26:09AM +0200, Dmitry Baryshkov wrote: > > > Reuse Type-C support implemented for the PMI632 PMIC (found on Qualcomm > > > Robotics RB2 platform) and implement Type-C handling for the Qualcomm > > > Robotics RB1 platform. > > > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > Patch 1 added, 2 did not apply to my tree :( > > Thank you! > Yes, patch 2 should go through arm-soc. Having patch series where each one goes to a different tree makes it really hard for maintainers to know what to do, and our tools want to take a whole series, not individual ones. Next time perhaps split it up? thanks, greg k-h
On Mon, 4 Mar 2024 at 12:09, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Mon, Mar 04, 2024 at 11:51:27AM +0200, Dmitry Baryshkov wrote: > > On Mon, 4 Mar 2024 at 11:49, Greg Kroah-Hartman > > <gregkh@linuxfoundation.org> wrote: > > > > > > On Mon, Mar 04, 2024 at 11:26:09AM +0200, Dmitry Baryshkov wrote: > > > > Reuse Type-C support implemented for the PMI632 PMIC (found on Qualcomm > > > > Robotics RB2 platform) and implement Type-C handling for the Qualcomm > > > > Robotics RB1 platform. > > > > > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > > > Patch 1 added, 2 did not apply to my tree :( > > > > Thank you! > > Yes, patch 2 should go through arm-soc. > > Having patch series where each one goes to a different tree makes it > really hard for maintainers to know what to do, and our tools want to > take a whole series, not individual ones. Next time perhaps split it > up? Ack, I'll keep this in mind when submitting series against usb-next. I have always been on the other side, because splitting the series makes the life of the reviewers and testers harder. With single series I can review, apply and test it as a whole item. With the feature being split, I have to collect all the driver changes and also the DT changes to be able to evaluate whether the approach is sensible or not.
On Mon, 04 Mar 2024 11:26:09 +0200, Dmitry Baryshkov wrote: > Reuse Type-C support implemented for the PMI632 PMIC (found on Qualcomm > Robotics RB2 platform) and implement Type-C handling for the Qualcomm > Robotics RB1 platform. > > Applied, thanks! [2/2] arm64: dts: qcom: qrb2210-rb1: enable USB-C port handling commit: c39c5aed65d428f2a1c2364851c8b44702e9d7db Best regards,
Reuse Type-C support implemented for the PMI632 PMIC (found on Qualcomm Robotics RB2 platform) and implement Type-C handling for the Qualcomm Robotics RB1 platform. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Changes in v4: - Rebased on top of linux-next, dropping applied patches - Link to v3: https://lore.kernel.org/r/20240221-pm4125-typec-v3-0-fdd0ee0465b8@linaro.org Changes in v3: - Fixed the commit subject for the regulators patch (Mark Brown) - Rebased on top of linux-next, dropping applied patches - Link to v2: https://lore.kernel.org/r/20240202-pm4125-typec-v2-0-12771d85700d@linaro.org Changes in v2: - Removed unnecessary conditional expansion, covered by existing compat string (Krzysztof) - Link to v1: https://lore.kernel.org/r/20240130-pm4125-typec-v1-0-e8d0097e2991@linaro.org --- Dmitry Baryshkov (2): dt-bindings: usb: qcom,pmic-typec: add support for the PM4125 block arm64: dts: qcom: qrb2210-rb1: enable USB-C port handling .../devicetree/bindings/usb/qcom,pmic-typec.yaml | 5 ++ arch/arm64/boot/dts/qcom/qcm2290.dtsi | 42 +++++++++++++++ arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 60 +++++++++++++++++++--- 3 files changed, 99 insertions(+), 8 deletions(-) --- base-commit: 67908bf6954b7635d33760ff6dfc189fc26ccc89 change-id: 20240117-pm4125-typec-8800d9c09aec Best regards,