| Message ID | 20240217-clk-mv200-v2-0-b782e4eb66f7@outlook.com |
|---|---|
| Headers | show |
| Series | clk: hisilicon: add support for Hi3798MV200 | expand |
On 17/02/2024 13:52, Yang Xiwen via B4 Relay wrote: > + > +static const struct hisi_crg_funcs hi3798mv200_sysctrl_funcs = { > + .register_clks = hi3798mv200_sysctrl_clk_register, > + .unregister_clks = hi3798mv200_sysctrl_clk_unregister, > +}; > + > +static const struct of_device_id hi3798mv200_crg_match_table[] = { > + { .compatible = "hisilicon,hi3798mv200-crg", > + .data = &hi3798mv200_crg_funcs }, > + { .compatible = "hisilicon,hi3798mv200-sysctrl", > + .data = &hi3798mv200_sysctrl_funcs }, These are undocumented compatibles. Run checkpatch or properly order your patchset. Best regards, Krzysztof
On 2/20/2024 6:11 PM, Krzysztof Kozlowski wrote: > On 17/02/2024 13:52, Yang Xiwen via B4 Relay wrote: >> + >> +static const struct hisi_crg_funcs hi3798mv200_sysctrl_funcs = { >> + .register_clks = hi3798mv200_sysctrl_clk_register, >> + .unregister_clks = hi3798mv200_sysctrl_clk_unregister, >> +}; >> + >> +static const struct of_device_id hi3798mv200_crg_match_table[] = { >> + { .compatible = "hisilicon,hi3798mv200-crg", >> + .data = &hi3798mv200_crg_funcs }, >> + { .compatible = "hisilicon,hi3798mv200-sysctrl", >> + .data = &hi3798mv200_sysctrl_funcs }, > These are undocumented compatibles. Run checkpatch or properly order > your patchset. It's in patch 5. You mean binding patch first and then driver? > > Best regards, > Krzysztof >
On 20/02/2024 11:14, Yang Xiwen wrote: > On 2/20/2024 6:11 PM, Krzysztof Kozlowski wrote: >> On 17/02/2024 13:52, Yang Xiwen via B4 Relay wrote: >>> + >>> +static const struct hisi_crg_funcs hi3798mv200_sysctrl_funcs = { >>> + .register_clks = hi3798mv200_sysctrl_clk_register, >>> + .unregister_clks = hi3798mv200_sysctrl_clk_unregister, >>> +}; >>> + >>> +static const struct of_device_id hi3798mv200_crg_match_table[] = { >>> + { .compatible = "hisilicon,hi3798mv200-crg", >>> + .data = &hi3798mv200_crg_funcs }, >>> + { .compatible = "hisilicon,hi3798mv200-sysctrl", >>> + .data = &hi3798mv200_sysctrl_funcs }, >> These are undocumented compatibles. Run checkpatch or properly order >> your patchset. > It's in patch 5. You mean binding patch first and then driver? https://elixir.bootlin.com/linux/v6.7/source/Documentation/devicetree/bindings/submitting-patches.rst Best regards, Krzysztof
This SoC is similar to Hi3798CV200 with a few more clocks in CRG module. Note this driver is still ongoing, many clocks are not registered in the driver now. Feedback is welcomed, especially from HiSilicon people. Signed-off-by: Yang Xiwen <forbidden405@outlook.com> --- Changes in v2: - s/dt-binding/dt-bindings in commit logs: (Krzysztof Kozlowski) - fix bot error by adding "hisilicon,hisi-sdmmc-dll" to syscon.yaml (Rob Herring) - hi3798mv200-crg: assign fixed rate parents to some gates - hi3798mv200-crg: s/ETH/FEMAC, add GMAC ctrl clock - Link to v1: https://lore.kernel.org/r/20240216-clk-mv200-v1-0-a29ace29e636@outlook.com --- Yang Xiwen (5): dt-bindings: clock: histb-clock: Add missing common clock and Hi3798MV200 specific clock definition clk: hisilicon: add CRG driver for Hi3798MV200 SoC dt-bindings: clock: merge all hisilicon clock bindings to hisilicon,clock-reset-generator dt-bindings: mfd: syscon: Add hisilicon,sdmmc-sap-dll compatible dt-bindings: clock: hisilicon,clock-reset-controller: add Hi3798MV200 SoC support .../devicetree/bindings/clock/hi3660-clock.txt | 47 --- .../devicetree/bindings/clock/hi3670-clock.txt | 43 -- .../devicetree/bindings/clock/hi6220-clock.txt | 52 --- .../devicetree/bindings/clock/hisi-crg.txt | 50 --- .../clock/hisilicon,clock-reset-generator.yaml | 175 +++++++++ .../clock/hisilicon,hi3559av100-clock.yaml | 59 --- Documentation/devicetree/bindings/mfd/syscon.yaml | 1 + drivers/clk/hisilicon/Kconfig | 8 + drivers/clk/hisilicon/Makefile | 1 + drivers/clk/hisilicon/crg-hi3798mv200.c | 436 +++++++++++++++++++++ include/dt-bindings/clock/histb-clock.h | 21 + 11 files changed, 642 insertions(+), 251 deletions(-) --- base-commit: 8d3dea210042f54b952b481838c1e7dfc4ec751d change-id: 20240216-clk-mv200-cc8cae396ee0 Best regards,