| Message ID | 20231206155740.5278-1-biju.das.jz@bp.renesas.com |
|---|---|
| Headers | show |
| Series | Convert DA906{1,2} bindings to json-schema | expand |
On 06/12/2023 16:57, Biju Das wrote: > Convert the below bindings to json-schema > 1) DA906{1,2} mfd bindings > 2) DA906{1,2,3} onkey bindings > 3) DA906{1,2,3} thermal bindings > > Also add fallback for DA9061 watchdog device and document > DA9063 watchdog device. Please explain here dependencies and make clear merging strategy. The patches cannot be taken independently. Best regards, Krzysztof
Hi Krzysztof Kozlowski, Lee Jones, > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Thursday, December 7, 2023 8:38 AM > Subject: Re: [PATCH v4 0/8] Convert DA906{1,2} bindings to json-schema > > On 06/12/2023 16:57, Biju Das wrote: > > Convert the below bindings to json-schema > > 1) DA906{1,2} mfd bindings > > 2) DA906{1,2,3} onkey bindings > > 3) DA906{1,2,3} thermal bindings > > > > Also add fallback for DA9061 watchdog device and document > > DA9063 watchdog device. > > Please explain here dependencies and make clear merging strategy. The > patches cannot be taken independently. Rob mentioned it needs to be taken through MFD tree. See [1] [1] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20231202192536.266885-9-biju.das.jz@bp.renesas.com/#25620636 Cheers, Biju
On 07/12/2023 10:01, Biju Das wrote: > Hi Krzysztof Kozlowski, Lee Jones, > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: Thursday, December 7, 2023 8:38 AM >> Subject: Re: [PATCH v4 0/8] Convert DA906{1,2} bindings to json-schema >> >> On 06/12/2023 16:57, Biju Das wrote: >>> Convert the below bindings to json-schema >>> 1) DA906{1,2} mfd bindings >>> 2) DA906{1,2,3} onkey bindings >>> 3) DA906{1,2,3} thermal bindings >>> >>> Also add fallback for DA9061 watchdog device and document >>> DA9063 watchdog device. >> >> Please explain here dependencies and make clear merging strategy. The >> patches cannot be taken independently. > > Rob mentioned it needs to be taken through MFD tree. See [1] > This I know, but you must explain it here - not in my reply, but in the cover letter. No one will remember what was agreed days ago, not mentioning that not everyone could read Rob's message. So how anyone reading your cover letter could know it? Best regards, Krzysztof
Hi Krzysztof Kozlowski, > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Thursday, December 7, 2023 9:16 AM > Subject: Re: [PATCH v4 0/8] Convert DA906{1,2} bindings to json-schema > > On 07/12/2023 10:01, Biju Das wrote: > > Hi Krzysztof Kozlowski, Lee Jones, > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> Sent: Thursday, December 7, 2023 8:38 AM > >> Subject: Re: [PATCH v4 0/8] Convert DA906{1,2} bindings to > >> json-schema > >> > >> On 06/12/2023 16:57, Biju Das wrote: > >>> Convert the below bindings to json-schema > >>> 1) DA906{1,2} mfd bindings > >>> 2) DA906{1,2,3} onkey bindings > >>> 3) DA906{1,2,3} thermal bindings > >>> > >>> Also add fallback for DA9061 watchdog device and document > >>> DA9063 watchdog device. > >> > >> Please explain here dependencies and make clear merging strategy. The > >> patches cannot be taken independently. > > > > Rob mentioned it needs to be taken through MFD tree. See [1] > > > > This I know, but you must explain it here - not in my reply, but in the > cover letter. No one will remember what was agreed days ago, not > mentioning that not everyone could read Rob's message. So how anyone > reading your cover letter could know it? Agreed, Will mention it in cover letter. Cheers, Biju
Convert the below bindings to json-schema 1) DA906{1,2} mfd bindings 2) DA906{1,2,3} onkey bindings 3) DA906{1,2,3} thermal bindings Also add fallback for DA9061 watchdog device and document DA9063 watchdog device. Note: This patch series is same as v3.1 as it allows the tools (PW, b4) to compare against previous versions. The review comments/tags received for v4 + (a.k.a v3.1) will be addressed in the next version(v5). Link to v3.1: https://lore.kernel.org/all/20231204172510.35041-1-biju.das.jz@bp.renesas.com/ v3->v4: * Patch#1 is merge of patch#1 from v2 + patch#8 from v2. * Dropped comment for d9061 watchdog fallback * Replaced enum->const for dlg,da9061-watchdog and its fallback. * Restored patch#4 in series 1 and dropped the thermal example * Added Ack from Conor Dooley for da9063 watchdog binding support. * Updated title DA9062/61->DA906{1,2,3} as it supports DA9063. * Retained Rb tag since the changes are trivial. * Added Ack from Conor for updating watchdog property * Dropped link to product information. * Patch#5(onkey) is squashed with patch#6 and patch#9 from v2. * Replaced enum->const for dlg,da9061-onkey and its fallback. * Dropped example * Restored the thermal binding patch from v2. * Dropped example * Replaced enum->const for compatible property. * Added Rb tag from Rob and retained Rb tag as changes are trivial. * Added Ack from Conor Dooley for patch#7. * Split the thermal binding patch separate * Updated the description v2->v3: * Updated Maintainer entries for watchdog,onkey and thermal bindings * Fixed bot errors related to MAINTAINERS entry, invalid doc references and thermal examples by merging patch#4. v1->v2: Link: https://lore.kernel.org/all/20231201110840.37408-5-biju.das.jz@bp.renesas.com/ * DA9062 and DA9061 merged with DA9063 * Sorted the child devices * mfd,onkey and thermal are pointing to child bindings Biju Das (8): dt-bindings: mfd: da9062: Update watchdog description dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063 watchdog dt-bindings: mfd: dlg,da9063: Update watchdog property dt-bindings: input: Convert da906{1,2,3} onkey to json-schema dt-bindings: thermal: Convert da906{1,2} thermal to json-schema dt-bindings: mfd: dlg,da9063: Sort child devices dt-bindings: mfd: dlg,da9063: Convert da9062 to json-schema .../bindings/input/da9062-onkey.txt | 47 ---- .../bindings/input/dlg,da9062-onkey.yaml | 39 ++++ .../devicetree/bindings/mfd/da9062.txt | 124 ---------- .../devicetree/bindings/mfd/dlg,da9063.yaml | 221 +++++++++++++++--- .../bindings/thermal/da9062-thermal.txt | 36 --- .../bindings/thermal/dlg,da9062-thermal.yaml | 35 +++ .../watchdog/dlg,da9062-watchdog.yaml | 13 +- MAINTAINERS | 6 +- 8 files changed, 272 insertions(+), 249 deletions(-) delete mode 100644 Documentation/devicetree/bindings/input/da9062-onkey.txt create mode 100644 Documentation/devicetree/bindings/input/dlg,da9062-onkey.yaml delete mode 100644 Documentation/devicetree/bindings/mfd/da9062.txt delete mode 100644 Documentation/devicetree/bindings/thermal/da9062-thermal.txt create mode 100644 Documentation/devicetree/bindings/thermal/dlg,da9062-thermal.yaml