| Message ID | 20230919014439.5795-1-chun-jen.tseng@mediatek.com |
|---|---|
| Headers | show |
| Series | soc: mediatek: svs: add support for mt8188 | expand |
Il 19/09/23 03:44, Mark Tseng ha scritto: > MT8188 svs gpu uses 2-line high bank and low bank to optimize the > voltage of opp table for higher and lower frequency respectively. > > Signed-off-by: Mark Tseng <chun-jen.tseng@mediatek.com> > --- > drivers/soc/mediatek/mtk-svs.c | 184 ++++++++++++++++++++++++++++++++- > 1 file changed, 180 insertions(+), 4 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c > index 3a2f97cd5272..f31e3bedff50 100644 > --- a/drivers/soc/mediatek/mtk-svs.c > +++ b/drivers/soc/mediatek/mtk-svs.c > @@ -407,6 +407,7 @@ struct svs_platform_data { > * @dcbdet: svs efuse data > * @dcmdet: svs efuse data > * @turn_pt: 2-line turn point tells which opp_volt calculated by high/low bank > + * @vbin_turn_pt: voltage bin turn point helps know which svsb_volt should be overridden > * @type: bank type to represent it is 2-line (high/low) bank or 1-line bank > * > * Svs bank will generate suitalbe voltages by below general math equation > @@ -469,6 +470,7 @@ struct svs_bank { > u32 dcbdet; > u32 dcmdet; > u32 turn_pt; > + u32 vbin_turn_pt; > u32 type; > }; > > @@ -751,11 +753,12 @@ static int svs_status_debug_show(struct seq_file *m, void *v) > > ret = thermal_zone_get_temp(svsb->tzd, &tzone_temp); > if (ret) > - seq_printf(m, "%s: temperature ignore, turn_pt = %u\n", > - svsb->name, svsb->turn_pt); > + seq_printf(m, "%s: temperature ignore, vbin_turn_pt = %u, turn_pt = %u\n", > + svsb->name, svsb->vbin_turn_pt, svsb->turn_pt); > else > - seq_printf(m, "%s: temperature = %d, turn_pt = %u\n", > - svsb->name, tzone_temp, svsb->turn_pt); > + seq_printf(m, "%s: temperature = %d, vbin_turn_pt = %u, turn_pt = %u\n", > + svsb->name, tzone_temp, svsb->vbin_turn_pt, > + svsb->turn_pt); > > for (i = 0; i < svsb->opp_count; i++) { > opp = dev_pm_opp_find_freq_exact(svsb->opp_dev, > @@ -952,6 +955,29 @@ static void svs_get_bank_volts_v3(struct svs_platform *svsp) > for (i = opp_start; i < opp_stop; i++) > if (svsb->volt_flags & SVSB_REMOVE_DVTFIXED_VOLT) > svsb->volt[i] -= svsb->dvt_fixed; > + > + /* For voltage bin support */ I already asked you to please send the voltage bin support as a separated commit because this is for *all SoCs* and not only for 8188. Again, please separate the voltage bin support from the MT8188 support. soc: mediatek: svs: Add support for voltage bins soc: mediatek: svs: Add support for MT8188 SoC Regards, Angelo
On Tue, 2023-09-19 at 12:52 +0200, AngeloGioacchino Del Regno wrote: > Il 19/09/23 03:44, Mark Tseng ha scritto: > > MT8188 svs gpu uses 2-line high bank and low bank to optimize the > > voltage of opp table for higher and lower frequency respectively. > > > > Signed-off-by: Mark Tseng <chun-jen.tseng@mediatek.com> > > --- > > drivers/soc/mediatek/mtk-svs.c | 184 > > ++++++++++++++++++++++++++++++++- > > 1 file changed, 180 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/soc/mediatek/mtk-svs.c > > b/drivers/soc/mediatek/mtk-svs.c > > index 3a2f97cd5272..f31e3bedff50 100644 > > --- a/drivers/soc/mediatek/mtk-svs.c > > +++ b/drivers/soc/mediatek/mtk-svs.c > > @@ -407,6 +407,7 @@ struct svs_platform_data { > > * @dcbdet: svs efuse data > > * @dcmdet: svs efuse data > > * @turn_pt: 2-line turn point tells which opp_volt calculated by > > high/low bank > > + * @vbin_turn_pt: voltage bin turn point helps know which > > svsb_volt should be overridden > > * @type: bank type to represent it is 2-line (high/low) bank or > > 1-line bank > > * > > * Svs bank will generate suitalbe voltages by below general math > > equation > > @@ -469,6 +470,7 @@ struct svs_bank { > > u32 dcbdet; > > u32 dcmdet; > > u32 turn_pt; > > + u32 vbin_turn_pt; > > u32 type; > > }; > > > > @@ -751,11 +753,12 @@ static int svs_status_debug_show(struct > > seq_file *m, void *v) > > > > ret = thermal_zone_get_temp(svsb->tzd, &tzone_temp); > > if (ret) > > - seq_printf(m, "%s: temperature ignore, turn_pt = %u\n", > > - svsb->name, svsb->turn_pt); > > + seq_printf(m, "%s: temperature ignore, vbin_turn_pt = > > %u, turn_pt = %u\n", > > + svsb->name, svsb->vbin_turn_pt, svsb- > > >turn_pt); > > else > > - seq_printf(m, "%s: temperature = %d, turn_pt = %u\n", > > - svsb->name, tzone_temp, svsb->turn_pt); > > + seq_printf(m, "%s: temperature = %d, vbin_turn_pt = %u, > > turn_pt = %u\n", > > + svsb->name, tzone_temp, svsb->vbin_turn_pt, > > + svsb->turn_pt); > > > > for (i = 0; i < svsb->opp_count; i++) { > > opp = dev_pm_opp_find_freq_exact(svsb->opp_dev, > > @@ -952,6 +955,29 @@ static void svs_get_bank_volts_v3(struct > > svs_platform *svsp) > > for (i = opp_start; i < opp_stop; i++) > > if (svsb->volt_flags & SVSB_REMOVE_DVTFIXED_VOLT) > > svsb->volt[i] -= svsb->dvt_fixed; > > + > > + /* For voltage bin support */ > > I already asked you to please send the voltage bin support as a > separated commit > because this is for *all SoCs* and not only for 8188. > > Again, please separate the voltage bin support from the MT8188 > support. > Hi Angelo, I have already checked "voltage bins turn point" with DE, it is support for *all SoCs* , not only for MT8188. > soc: mediatek: svs: Add support for voltage bins > soc: mediatek: svs: Add support for MT8188 SoC > > Regards, > Angelo >
Hi Mark, On Tue, Sep 19, 2023 at 8:38 PM Chun-Jen Tseng (曾俊仁) <Chun-Jen.Tseng@mediatek.com> wrote: > > On Tue, 2023-09-19 at 12:52 +0200, AngeloGioacchino Del Regno wrote: > > Il 19/09/23 03:44, Mark Tseng ha scritto: > > > MT8188 svs gpu uses 2-line high bank and low bank to optimize the > > > voltage of opp table for higher and lower frequency respectively. > > > > > > Signed-off-by: Mark Tseng <chun-jen.tseng@mediatek.com> > > > --- <snip> > > > + > > > + /* For voltage bin support */ > > > > I already asked you to please send the voltage bin support as a > > separated commit > > because this is for *all SoCs* and not only for 8188. > > > > Again, please separate the voltage bin support from the MT8188 > > support. > > > Hi Angelo, > > I have already checked "voltage bins turn point" with DE, it is support > for *all SoCs* , not only for MT8188. I think Angelo's point is that you should separate this patch into two, where: - "soc: mediatek: svs: Add support for voltage bins" contains changes only related to the "For voltage bin support" part. - "soc: mediatek: svs: Add support for MT8188 SoC" contains code that is specifically for MT8188, i.e. svs_mt8188_efuse_parsing, svs_mt8188_banks etc. It'd be easier for people to review, manage and cherry-pick patches if you add the generic changes apart from the platform-specific code. For example, someone will be able to simply pick up the patch for voltage bin support solely if they are not interested in MT8188. Regards, Fei > > > > soc: mediatek: svs: Add support for voltage bins > > soc: mediatek: svs: Add support for MT8188 SoC > > > > Regards, > > Angelo > >
On Wed, 2023-09-20 at 12:47 +0800, Fei Shao wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > Hi Mark, > > On Tue, Sep 19, 2023 at 8:38 PM Chun-Jen Tseng (曾俊仁) > <Chun-Jen.Tseng@mediatek.com> wrote: > > > > On Tue, 2023-09-19 at 12:52 +0200, AngeloGioacchino Del Regno > wrote: > > > Il 19/09/23 03:44, Mark Tseng ha scritto: > > > > MT8188 svs gpu uses 2-line high bank and low bank to optimize > the > > > > voltage of opp table for higher and lower frequency > respectively. > > > > > > > > Signed-off-by: Mark Tseng <chun-jen.tseng@mediatek.com> > > > > --- > <snip> > > > > + > > > > + /* For voltage bin support */ > > > > > > I already asked you to please send the voltage bin support as a > > > separated commit > > > because this is for *all SoCs* and not only for 8188. > > > > > > Again, please separate the voltage bin support from the MT8188 > > > support. > > > > > Hi Angelo, > > > > I have already checked "voltage bins turn point" with DE, it is > support > > for *all SoCs* , not only for MT8188. > > I think Angelo's point is that you should separate this patch into > two, where: > - "soc: mediatek: svs: Add support for voltage bins" contains changes > only related to the "For voltage bin support" part. > - "soc: mediatek: svs: Add support for MT8188 SoC" contains code that > is specifically for MT8188, i.e. svs_mt8188_efuse_parsing, > svs_mt8188_banks etc. > > It'd be easier for people to review, manage and cherry-pick patches > if > you add the generic changes apart from the platform-specific code. > For example, someone will be able to simply pick up the patch for > voltage bin support solely if they are not interested in MT8188. > > Regards, > Fei > > > > > > > soc: mediatek: svs: Add support for voltage bins > > > soc: mediatek: svs: Add support for MT8188 SoC > > > > > > Regards, > > > Angelo Hi Angelo, I have updated v4 patch and separate the voltage bin support from the MT8188. BRs, Mark Tseng > > >
This series supports MT8188 Smart Voltage Scaling (SVS) hardware which used as optimization of opp voltage table for gpu dvfs driver. Changes since v2: - Add Acked-by & Acked-by in patch Changes since v1: - thermal name change to lvts - fixed voltage bin flow - using svs_get_efuse_data() replace nvmem read API in mt8188 efuse parsing Mark Tseng (2): dt-bindings: soc: mediatek: add mt8188 svs dt-bindings soc: mediatek: svs: add support for mt8188 .../bindings/soc/mediatek/mtk-svs.yaml | 1 + drivers/soc/mediatek/mtk-svs.c | 184 +++++++++++++++++- 2 files changed, 181 insertions(+), 4 deletions(-)