| Message ID | 20230608163734.2578-1-a-bhatia1@ti.com |
|---|---|
| Headers | show |
| Series | Add DSS support for AM625 SoC | expand |
Hi, On 08/06/2023 19:37, Aradhya Bhatia wrote: > Add support for the DSS controller on TI's AM625 SoC in the tidss > driver. > > The AM625 DSS supports 2 video planes connecting to 2 video ports. > The first plane is a full plane supporting all the features, while the > 2nd plane is a "lite" plane without scaling support. The DRM planes are reversed compared to the HW planes, aren't they? Is the above referring to HW planes? > The first video port in AM625 DSS internally provides DPI output to 2 > OLDI transmitters. Each OLDI TX outputs 4 differential lanes of video > output and 1 of clock output. I think it should be explained that OLDI is not supported in this version, but will be added later. Other than that: Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Tomi
Hi Tomi, Thank you for the reviews! On 16-Jun-23 18:15, Tomi Valkeinen wrote: > Hi, > > On 08/06/2023 19:37, Aradhya Bhatia wrote: >> Add support for the DSS controller on TI's AM625 SoC in the tidss >> driver. >> >> The AM625 DSS supports 2 video planes connecting to 2 video ports. >> The first plane is a full plane supporting all the features, while the >> 2nd plane is a "lite" plane without scaling support. > > The DRM planes are reversed compared to the HW planes, aren't they? Is > the above referring to HW planes? Yes, I am referring to the HW planes, and the DRM planes reversed as well. =) > >> The first video port in AM625 DSS internally provides DPI output to 2 >> OLDI transmitters. Each OLDI TX outputs 4 differential lanes of video >> output and 1 of clock output. > > I think it should be explained that OLDI is not supported in this > version, but will be added later. Okay, I will make the change. Regards Aradhya > > Other than that: > > Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> > > Tomi >
This patch series adds a new compatible for the Display SubSystem (DSS) controller on TI's AM625 SoC. It further adds the required support for the same in the tidss driver. The AM625-DSS is a newer version of the DSS from the AM65X version with the major change being the addition of another OLDI TX. With the help of 2 OLDI TXes, the AM625 DSS can support dual-linked OLDI displays with a resolution of up-to 2K or WUXGA (1920x1200@60fps) at half the OLDI clock frequency or even cloned video outputs on each of the TXes. This patch series acts as a continuation of the patches posted in v3[1]. The OLDI support patches combined from v5 onwards are now separated again. The OLDI support will be added subsequently with a separte patch series. I have dropped Krzysztof Kozlowski's and Rahul T R's R-b tags from patch 1/2 considering the changes involved in the binding. I have tested these patches on AM625 SK-EVM and AM625 based Beagle Play. To test this series on AM625 based platforms, basic display support patches, (for driver + devicetree) can be found in the "next_am62-base_support" branch on my github fork[2]. [1]: V3: https://patchwork.freedesktop.org/series/105373/ [2]: https://github.com/aradhya07/linux-ab/tree/next_am62-base_support Previous versions: - V7: https://patchwork.freedesktop.org/series/113328/ - V6: https://patchwork.freedesktop.org/series/111106/ - V5: https://patchwork.freedesktop.org/series/109194/ Changelog: V8: - Rebase for current merge window. - Drop all the OLDI support patches. - Update the binding to remove the 2nd OLDI port instances. - Drop the Reviewed-by tags of Krzysztof Kozlowski and Rahul T R because of the changes. V7: - Rebase to current linux-next. - Address Tomi Valkeinen's comments. 1. Separate the DSS VP and output port coupling. v6 introduced 'output_port_bus_type' in addition to 'vp_bus_type' but having both of the variables was redundant. Hence, in v7 the 'output_port_bus_type' essentially replaces 'vp_bus_type'. 2. Break Patch v6 2/5 into 2 separate patches (v7 1/6 and v7 3/6). 3. Change in name and addition of OLDI mode macros. 4. Other minor changes. V6: - Rebase for current merge window. - Add 'allOf:' condition in the DT binding. - Address Tomi Valkeinen's comments. 1. Combine DT binding patches for new compatible and 3rd DSS port. 2. Further separate DSS VPs and output ports. 3. Separate OLDI mode discovery logic from the panel/bridge discovery (which allowed support for OLDI bridges as well.) 4. Organize OLDI IO control register macros platform wise. V5: - Rebase for current merge window. - Add max DT ports in DSS features. - Combine the OLDI support series. (Changes from OLDI support series v1) - Address Tomi Valkeinen's comments. 1. Update the OLDI link detection approach. 2. Add port #3 for 2nd OLDI TX. 3. Configure 2 panel-bridges for cloned panels. 4. Drop the OLDI clock set patch. 5. Drop rgb565-to-888 patch. V3: - Change yaml enum in alphabetical order. - Correct a typo. V2: - Remove redundant register array. Aradhya Bhatia (2): dt-bindings: display: ti,am65x-dss: Add am625 dss compatible drm/tidss: Add support for AM625 DSS .../bindings/display/ti/ti,am65x-dss.yaml | 18 ++++-- drivers/gpu/drm/tidss/tidss_dispc.c | 57 ++++++++++++++++++- drivers/gpu/drm/tidss/tidss_dispc.h | 2 + drivers/gpu/drm/tidss/tidss_drv.c | 1 + 4 files changed, 71 insertions(+), 7 deletions(-)