| Message ID | 20230501195525.6268-1-aweber.kernel@gmail.com |
|---|---|
| Headers | show |
| Series | Re-introduce Exynos4212 support and add Samsung Galaxy Tab 3 8.0 boards | expand |
On 01/05/2023 21:55, Artur Weber wrote: > Support for the Exynos4212 SoC was originally dropped as there were > no boards using it. We will be adding a device that uses it, so add > it back. > > This reverts commit 2d41a0c9ae51ac363d107f2510022106e7234b33. > > Signed-off-by: Artur Weber <aweber.kernel@gmail.com> > --- > drivers/media/platform/samsung/exynos4-is/Kconfig | 2 +- > drivers/media/platform/samsung/exynos4-is/fimc-core.c | 2 +- > drivers/media/platform/samsung/exynos4-is/fimc-lite.c | 2 +- Subject: media: Revert "media: Remove dependency on obsolete SoC support" I assume this will go via media tree. If not, let me know. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 01/05/2023 21:55, Artur Weber wrote: > Support for the Exynos4212 SoC was originally dropped as there were > no boards using it. We will be adding a device that uses it, so add > it back. > > This reverts commit fee7e1d50c6e6da1d99035181ba5a5c88f5bb526. Subject: phy: Revert "phy: Remove SOC_EXYNOS4212 dep. from PHY_EXYNOS4X12_USB" I assume this will go via phy tree. If not, let me know. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, 01 May 2023 21:55:15 +0200, Artur Weber wrote: > Support for the Exynos4212 SoC was originally dropped as there were > no boards using it. We will be adding a device that uses it, so add > back the relevant code. > > This reverts commit 9e43eca3c87476f75680f472ff3ebcd85f357b86. > > > [...] Applied, thanks! [03/13] ARM: exynos: Re-introduce Exynos4212 support https://git.kernel.org/krzk/linux/c/4e486a650162a20e5c3c7987715f8297c84c85f4 Best regards,
On Mon, 01 May 2023 21:55:16 +0200, Artur Weber wrote: > Support for the Exynos4212 SoC was originally dropped as there were > no boards using it. We will be adding a device that uses it, so add > it back. > > This reverts commit c40610198f35e8264f9175dafe74db6288a07eda. > > > [...] Applied, thanks! [04/13] soc: samsung: Re-introduce Exynos4212 support https://git.kernel.org/krzk/linux/c/514a935fd0d4d522a08257f5acbc5439174c7cf0 Best regards,
On Mon, 01 May 2023 21:55:17 +0200, Artur Weber wrote: > Support for the Exynos4212 SoC was originally dropped as there were > no boards using it. We will be adding a device that uses it, so add > it back. > > This reverts commit d5cd103b06f9d766295d18798de484528eb120ea. > > > [...] Applied, thanks! [05/13] clk: samsung: Add Exynos4212 compatible to CLKOUT driver https://git.kernel.org/krzk/linux/c/48b359732e166d0f5d53649e21eac8d9343b8e13 Best regards,
On Mon, 01 May 2023 21:55:18 +0200, Artur Weber wrote: > Support for the Exynos4212 SoC was originally dropped as there were > no boards using it. We will be adding a device that uses it, so add > it back. > > This reverts commit c9194fb623b0158029a268376df09fe28a2a2b05. > > > [...] Applied, thanks! [06/13] clk: samsung: Re-add support for Exynos4212 CPU clock https://git.kernel.org/krzk/linux/c/40b4ffe5e921a8db911a7e5ffe3ad8da86ac0dfd Best regards,
On Mon, 01 May 2023 21:55:21 +0200, Artur Weber wrote: > In preparation for the re-introduction of the Exynos4212, move > their shared definitions to a separate file. Rename the pinctrl > definitions accordingly, and adapt the Exynos4412 DTSI to these > changes. > > This reverts part of commit bca9085e0ae9 ("ARM: dts: exynos: > remove Exynos4212 support (dead code)"). > > [...] Applied, thanks! [09/13] ARM: dts: Move common Exynos4x12 definitions to exynos4x12.dtsi https://git.kernel.org/krzk/linux/c/b4354b9761437ba136329e3f2ea1386e8d483e1c Best regards,
On Mon, 01 May 2023 21:55:22 +0200, Artur Weber wrote: > Support for the Exynos4212 SoC was originally dropped as there were > no boards using it. We will be adding a device that uses it, so add > it back. > > This reverts commit bca9085e0ae93253bc93ce218c85ac7d7e7f1831. > > > [...] Applied, thanks! [10/13] ARM: dts: Re-introduce Exynos4212 DTSI https://git.kernel.org/krzk/linux/c/41bf1a9f9fbdec5dd1ba69fe26157f42e44dcee4 Best regards,
On 01/05/2023 21:55, Artur Weber wrote: > Change 'specfic' to 'specific', 'optiosn' to 'options' and remove > duplicated 'are listed' in DTSI heading comments. > > Signed-off-by: Artur Weber <aweber.kernel@gmail.com> > --- This needs rebasing. Best regards, Krzysztof
On 01/05/2023 21:55, Artur Weber wrote: > Introduce support for the Galaxy Tab 3 8.0 series of boards: > > - Samsung Galaxy Tab 3 8.0 WiFi (SM-T310/lt01wifi) > - Samsung Galaxy Tab 3 8.0 3G (SM-T311/lt013g) > - Samsung Galaxy Tab 3 8.0 LTE (SM-T315/lt01lte) > > What works: > > - Display and backlight > - Touchscreen (without touchkeys) > - GPIO buttons, hall sensor > - WiFi and Bluetooth > - USB, fuel gauge, charging > - Accelerometer and magnetometer > - WiFi model only: light sensor > > Signed-off-by: Artur Weber <aweber.kernel@gmail.com> Thank you for your patch. There is something to discuss/improve. > --- > Changed in v3: > - Addressed review comments > - Removed rtc node (RTC is provided by PMIC) > - Added CPU thermal node > - Fixed dtb_check warnings > - Added common changes from next/dt > > Display panel bindings are added by a separate patchset: > "[PATCH 0/3] Add Samsung S6D7AA0 panel controller driver"[1] > > LP855X node is adapted to changes from a separate patchset: > "[PATCH 0/4] video: backlight: lp855x: modernize bindings"[2] > > [1] https://lore.kernel.org/all/20230501185103.25939-1-aweber.kernel@gmail.com/ > [2] https://lore.kernel.org/all/20230429104534.28943-1-aweber.kernel@gmail.com/ New failures: arch/arm/boot/dts/exynos4212-tab3-3g8.dtb: rtc@10070000: clocks: [[5, 346]] is too short > --- > arch/arm/boot/dts/Makefile | 3 + > arch/arm/boot/dts/exynos4212-tab3-3g8.dts | 29 + > arch/arm/boot/dts/exynos4212-tab3-lte8.dts | 44 + > arch/arm/boot/dts/exynos4212-tab3-wifi8.dts | 26 + > arch/arm/boot/dts/exynos4212-tab3.dtsi | 1171 +++++++++++++++++++ > 5 files changed, 1273 insertions(+) > create mode 100644 arch/arm/boot/dts/exynos4212-tab3-3g8.dts > create mode 100644 arch/arm/boot/dts/exynos4212-tab3-lte8.dts > create mode 100644 arch/arm/boot/dts/exynos4212-tab3-wifi8.dts > create mode 100644 arch/arm/boot/dts/exynos4212-tab3.dtsi > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index efe4152e5846..e5f63b636637 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -217,6 +217,9 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \ > exynos4210-smdkv310.dtb \ > exynos4210-trats.dtb \ > exynos4210-universal_c210.dtb \ > + exynos4212-tab3-3g8.dtb \ > + exynos4212-tab3-lte8.dtb \ > + exynos4212-tab3-wifi8.dtb \ > exynos4412-i9300.dtb \ > exynos4412-i9305.dtb \ > exynos4412-itop-elite.dtb \ > diff --git a/arch/arm/boot/dts/exynos4212-tab3-3g8.dts b/arch/arm/boot/dts/exynos4212-tab3-3g8.dts > new file mode 100644 > index 000000000000..6d890353ae76 > --- /dev/null > +++ b/arch/arm/boot/dts/exynos4212-tab3-3g8.dts > @@ -0,0 +1,29 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Samsung's Exynos4212 based Galaxy Tab 3 8.0 3G board device tree > + * source > + * > + * Copyright (c) 2013 Samsung Electronics Co., Ltd. > + * http://www.samsung.com > + */ > + > +/dts-v1/; > +#include "exynos4212-tab3.dtsi" > + > +/ { > + model = "Samsung Galaxy Tab 3 8.0 3G (SM-T311) based on Exynos4212"; > + compatible = "samsung,t311", "samsung,tab3", "samsung,exynos4212", "samsung,exynos4"; > + chassis-type = "tablet"; > +}; > + > +/* Pin control sleep state overrides */ > +&sleep0 { > + PIN_SLP(gpb-5, INPUT, UP); Too much indentent. > +}; > + > +&sleep1 { > + PIN_SLP(gpl0-0, OUT0, NONE); Same here. > + PIN_SLP(gpl1-0, OUT0, NONE); > + PIN_SLP(gpl2-4, OUT0, NONE); > + PIN_SLP(gpm3-3, OUT1, NONE); > +}; > diff --git a/arch/arm/boot/dts/exynos4212-tab3-lte8.dts b/arch/arm/boot/dts/exynos4212-tab3-lte8.dts > new file mode 100644 > index 000000000000..c5ec68c292b0 > --- /dev/null > +++ b/arch/arm/boot/dts/exynos4212-tab3-lte8.dts > @@ -0,0 +1,44 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Samsung's Exynos4212 based Galaxy Tab 3 8.0 LTE board device tree > + * source > + * > + * Copyright (c) 2013 Samsung Electronics Co., Ltd. > + * http://www.samsung.com > + */ > + > +/dts-v1/; > +#include "exynos4212-tab3.dtsi" > + > +/ { > + model = "Samsung Galaxy Tab 3 8.0 LTE (SM-T315) based on Exynos4212"; > + compatible = "samsung,t315", "samsung,tab3", "samsung,exynos4212", "samsung,exynos4"; > + chassis-type = "tablet"; > +}; > + > +/* Pin control sleep state overrides */ > +&sleep0 { > + PIN_SLP(gpa0-4, INPUT, UP); > + PIN_SLP(gpa0-5, INPUT, UP); Same. > + > + PIN_SLP(gpb-5, INPUT, UP); > + > + PIN_SLP(gpc0-0, PREV, NONE); > + PIN_SLP(gpc1-3, INPUT, NONE); > + > + PIN_SLP(gpf1-6, INPUT, NONE); > + PIN_SLP(gpf2-2, PREV, NONE); > +}; > + > +&sleep1 { > + PIN_SLP(gpl0-0, PREV, NONE); > + > + PIN_SLP(gpl1-0, PREV, NONE); > + > + PIN_SLP(gpl2-1, INPUT, DOWN); > + PIN_SLP(gpl2-2, INPUT, DOWN); > + PIN_SLP(gpl2-4, OUT0, NONE); > + PIN_SLP(gpl2-5, PREV, NONE); > + > + PIN_SLP(gpm3-3, OUT1, NONE); ... > + buck5_reg: BUCK5 { > + regulator-name = "VMEM_1.2V_AP"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + regulator-always-on; > + regulator-boot-on; > + op_mode = <1>; > + }; > + > + buck6_reg: BUCK6 { > + regulator-name = "CAM_ISP_CORE_1.2V"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + op_mode = <1>; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + }; > + > + s5m8767_osc: clocks { > + compatible = "samsung,s5m8767-clk"; > + #clock-cells = <1>; > + clock-output-names = "en32khz_ap", > + "en32khz_cp", > + "en32khz_bt"; Are these aligned with opening "? > + }; > + }; > +}; Best regards, Krzysztof
On 01/05/2023 21:55, Artur Weber wrote: > This patches re-introduces the Exynos4212 platform and adds support > for the Samsung Galaxy Tab 3 8.0 series of tablets that uses it: > > - Samsung Galaxy Tab 3 8.0 WiFi (SM-T310/lt01wifi) > - Samsung Galaxy Tab 3 8.0 3G (SM-T311/lt013g) > - Samsung Galaxy Tab 3 8.0 LTE (SM-T315/lt01lte) > > What works: > > - Display and backlight > - Touchscreen (without touchkeys) > - GPIO buttons, hall sensor > - WiFi and Bluetooth > - USB, fuel gauge, charging > - Accelerometer and magnetometer > - WiFi model only: light sensor Thanks for the patches, nice work. I applied parts of the set. Please: 1. Split the patchset per subsystems, so separate to media, phy and me. 2. Check reviews and resend bindings for display and LP855X. 3. Rebase and check/fix DTS and send a new version. I cannot apply DTS without bindings being reviewed. Best regards, Krzysztof
This patches re-introduces the Exynos4212 platform and adds support for the Samsung Galaxy Tab 3 8.0 series of tablets that uses it: - Samsung Galaxy Tab 3 8.0 WiFi (SM-T310/lt01wifi) - Samsung Galaxy Tab 3 8.0 3G (SM-T311/lt013g) - Samsung Galaxy Tab 3 8.0 LTE (SM-T315/lt01lte) What works: - Display and backlight - Touchscreen (without touchkeys) - GPIO buttons, hall sensor - WiFi and Bluetooth - USB, fuel gauge, charging - Accelerometer and magnetometer - WiFi model only: light sensor Display panel bindings used by the Tab3 DTSI are added in a separate patchset - "[PATCH 0/3] Add Samsung S6D7AA0 panel controller driver": https://lore.kernel.org/all/20230501185103.25939-1-aweber.kernel@gmail.com/ LP855X binding updates used by the Tab3 DTSI are added in a separate patchset - "[PATCH 0/4] video: backlight: lp855x: modernize bindings": https://lore.kernel.org/all/20230429104534.28943-1-aweber.kernel@gmail.com/ Changed in v2: - Added note about display panel bindings to cover letter and Tab3 DTSI commit Changed in v3: - Addressed review comments - Tab3 DTS tweaks (remove broken RTC, add CPU thermal node) - Fixed typos in Exynos DTSIs Artur Weber (13): dt-bindings: soc: samsung: add Exynos4212 PMU compatible dt-bindings: clock: add Exynos4212 clock compatible ARM: exynos: Re-introduce Exynos4212 support soc: samsung: Re-introduce Exynos4212 support clk: samsung: Add Exynos4212 compatible to CLKOUT driver clk: samsung: Re-add support for Exynos4212 CPU clock Revert "media: exynos4-is: Remove dependency on obsolete SoC support" Revert "phy: Remove SOC_EXYNOS4212 dep. from PHY_EXYNOS4X12_USB" ARM: dts: Move common Exynos4x12 definitions to exynos4x12.dtsi ARM: dts: Re-introduce Exynos4212 DTSI ARM: dts: exynos: Fix some typos in comments dt-bindings: arm: samsung: Add Samsung Galaxy Tab3 family boards ARM: dts: exynos: Add Samsung Galaxy Tab 3 8.0 boards .../bindings/arm/samsung/samsung-boards.yaml | 10 + .../bindings/clock/samsung,exynos-clock.yaml | 1 + .../bindings/soc/samsung/exynos-pmu.yaml | 5 + arch/arm/boot/dts/Makefile | 3 + arch/arm/boot/dts/exynos3250-pinctrl.dtsi | 4 +- arch/arm/boot/dts/exynos3250.dtsi | 2 +- arch/arm/boot/dts/exynos4.dtsi | 2 +- arch/arm/boot/dts/exynos4210-pinctrl.dtsi | 4 +- arch/arm/boot/dts/exynos4212-tab3-3g8.dts | 29 + arch/arm/boot/dts/exynos4212-tab3-lte8.dts | 44 + arch/arm/boot/dts/exynos4212-tab3-wifi8.dts | 26 + arch/arm/boot/dts/exynos4212-tab3.dtsi | 1171 +++++++++++++++++ arch/arm/boot/dts/exynos4212.dtsi | 157 +++ arch/arm/boot/dts/exynos4412.dtsi | 646 +-------- ...2-pinctrl.dtsi => exynos4x12-pinctrl.dtsi} | 6 +- .../dts/{exynos4412.dtsi => exynos4x12.dtsi} | 165 +-- arch/arm/boot/dts/exynos5.dtsi | 2 +- arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 4 +- arch/arm/boot/dts/exynos5250.dtsi | 2 +- arch/arm/boot/dts/exynos5260-pinctrl.dtsi | 2 +- arch/arm/boot/dts/exynos5410.dtsi | 2 +- arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 2 +- arch/arm/boot/dts/exynos5420.dtsi | 2 +- arch/arm/boot/dts/exynos5800.dtsi | 2 +- arch/arm/boot/dts/s3c6400.dtsi | 2 +- arch/arm/boot/dts/s3c6410.dtsi | 2 +- arch/arm/boot/dts/s3c64xx.dtsi | 2 +- arch/arm/boot/dts/s5pv210-pinctrl.dtsi | 2 +- arch/arm/boot/dts/s5pv210.dtsi | 2 +- arch/arm/mach-exynos/Kconfig | 5 + arch/arm/mach-exynos/common.h | 8 + arch/arm/mach-exynos/exynos.c | 2 + arch/arm/mach-exynos/firmware.c | 8 +- arch/arm/mach-exynos/pm.c | 2 +- arch/arm/mach-exynos/suspend.c | 4 + drivers/clk/samsung/clk-exynos-clkout.c | 3 + drivers/clk/samsung/clk-exynos4.c | 44 +- .../media/platform/samsung/exynos4-is/Kconfig | 2 +- .../platform/samsung/exynos4-is/fimc-core.c | 2 +- .../platform/samsung/exynos4-is/fimc-lite.c | 2 +- drivers/phy/samsung/Kconfig | 2 +- drivers/soc/samsung/exynos-pmu.c | 9 + drivers/soc/samsung/exynos-pmu.h | 2 + drivers/soc/samsung/exynos4-pmu.c | 13 +- 44 files changed, 1534 insertions(+), 837 deletions(-) create mode 100644 arch/arm/boot/dts/exynos4212-tab3-3g8.dts create mode 100644 arch/arm/boot/dts/exynos4212-tab3-lte8.dts create mode 100644 arch/arm/boot/dts/exynos4212-tab3-wifi8.dts create mode 100644 arch/arm/boot/dts/exynos4212-tab3.dtsi create mode 100644 arch/arm/boot/dts/exynos4212.dtsi rename arch/arm/boot/dts/{exynos4412-pinctrl.dtsi => exynos4x12-pinctrl.dtsi} (99%) copy arch/arm/boot/dts/{exynos4412.dtsi => exynos4x12.dtsi} (81%) base-commit: e154a338e16cc3b3bbd54c891253319d22383746