mbox series

[v3,0/2] spi: loongson: add bus driver for the loongson spi

Message ID 20230324063317.14664-1-zhuyinbo@loongson.cn
Headers show
Series spi: loongson: add bus driver for the loongson spi | expand

Message

Yinbo Zhu March 24, 2023, 6:33 a.m. UTC 
Loongson platform support spi hardware controller and this series patch
was to add spi driver and binding support.

Change in v2:
		1. This [PATCH v2 1/2] dt-bindings patch need depend on clk patch:
	 	   https://
		   lore.kernel.org/all/20230307115022.12846-1-zhuyinbo@loongson.cn/
		2. Remove the clock-names in spi yaml file.
		3. Add "loongson,ls7a-spi" compatible in spi yaml file.
		4. Add an || COMPILE_TEST and drop && PCI then add some CONFIG_PCI
		   macro to limit some pci code.
		5. Make the spi driver top code comment block that use C++ style.
		6. Drop spi->max_speed_hz.
		7. Add a spin_lock for loongson_spi_setup.
		8. Add a timeout and cpu_relax() in loongson_spi_write_read_8bit.
		9. Add spi_transfer_one and drop transfer and rework entire spi
		   driver that include some necessary changes.
		10. Use module_init replace subsys_initcall.
		11. About PM interface that I don't find any issue so I don't add
		    any changes.
Change in v3:
		1. This [PATCH v3 1/2] dt-bindings patch need depend on clk patch:
		   https://
		   lore.kernel.org/all/20230323025229.2971-1-zhuyinbo@loongson.cn/
		2. Drop the unused blank line in loongson,ls-spi.yaml file.
		3. Replace clock minItems with clock maxItems in yaml file.
		4. Separate spi driver into platform module, pci module and core
		   module.
		5. Replace DIV_ROUND_UP with DIV_ROUND_UP_ULL to fix compile error
		   "undefined reference to `__aeabi_uldivmod'" and  "__udivdi3 undefined"
		   that reported by test robot.
		6. Remove the spin lock.
		7. Clear the loongson_spi->hz and loongson_spi->mode in setup to fixup
		   the issue that multiple spi device transfer that maybe cause spi was
		   be misconfigured.

Yinbo Zhu (2):
  dt-bindings: spi: add loongson spi
  spi: loongson: add bus driver for the loongson spi controller

 .../bindings/spi/loongson,ls-spi.yaml         |  43 +++
 MAINTAINERS                                   |  10 +
 drivers/spi/Kconfig                           |  31 ++
 drivers/spi/Makefile                          |   3 +
 drivers/spi/spi-loongson-core.c               | 302 ++++++++++++++++++
 drivers/spi/spi-loongson-pci.c                |  89 ++++++
 drivers/spi/spi-loongson-plat.c               |  66 ++++
 drivers/spi/spi-loongson.h                    |  41 +++
 8 files changed, 585 insertions(+)

Comments

Krzysztof Kozlowski March 24, 2023, 11:31 a.m. UTC | #1 
On 24/03/2023 07:33, Yinbo Zhu wrote:
> This bus driver supports the Loongson spi hardware controller in the
> Loongson platforms and supports to use DTS and PCI framework to
> register spi device resources.
> 
> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
> ---
>  MAINTAINERS                     |   4 +
>  drivers/spi/Kconfig             |  31 ++++
>  drivers/spi/Makefile            |   3 +
>  drivers/spi/spi-loongson-core.c | 302 ++++++++++++++++++++++++++++++++
>  drivers/spi/spi-loongson-pci.c  |  89 ++++++++++
>  drivers/spi/spi-loongson-plat.c |  66 +++++++
>  drivers/spi/spi-loongson.h      |  41 +++++
>  7 files changed, 536 insertions(+)
>  create mode 100644 drivers/spi/spi-loongson-core.c
>  create mode 100644 drivers/spi/spi-loongson-pci.c
>  create mode 100644 drivers/spi/spi-loongson-plat.c
>  create mode 100644 drivers/spi/spi-loongson.h

Your patches still have build warnings. Are these false postives or you
forgot to build it? Anyway, please respond to the report.

Best regards,
Krzysztof
Yinbo Zhu March 27, 2023, 8:42 a.m. UTC | #2 
在 2023/3/24 下午7:31, Krzysztof Kozlowski 写道:
> On 24/03/2023 07:33, Yinbo Zhu wrote:
>> This bus driver supports the Loongson spi hardware controller in the
>> Loongson platforms and supports to use DTS and PCI framework to
>> register spi device resources.
>>
>> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
>> ---
>>   MAINTAINERS                     |   4 +
>>   drivers/spi/Kconfig             |  31 ++++
>>   drivers/spi/Makefile            |   3 +
>>   drivers/spi/spi-loongson-core.c | 302 ++++++++++++++++++++++++++++++++
>>   drivers/spi/spi-loongson-pci.c  |  89 ++++++++++
>>   drivers/spi/spi-loongson-plat.c |  66 +++++++
>>   drivers/spi/spi-loongson.h      |  41 +++++
>>   7 files changed, 536 insertions(+)
>>   create mode 100644 drivers/spi/spi-loongson-core.c
>>   create mode 100644 drivers/spi/spi-loongson-pci.c
>>   create mode 100644 drivers/spi/spi-loongson-plat.c
>>   create mode 100644 drivers/spi/spi-loongson.h
> 
> Your patches still have build warnings. Are these false postives or you
> forgot to build it? Anyway, please respond to the report.
> 
> Best regards,
> Krzysztof
thanks your reminder, I have already provided feedback about compile issue.
>
Krzysztof Kozlowski March 27, 2023, 8:53 a.m. UTC | #3 
On 27/03/2023 10:42, zhuyinbo wrote:
> 
> 
> 在 2023/3/24 下午7:31, Krzysztof Kozlowski 写道:
>> On 24/03/2023 07:33, Yinbo Zhu wrote:
>>> This bus driver supports the Loongson spi hardware controller in the
>>> Loongson platforms and supports to use DTS and PCI framework to
>>> register spi device resources.
>>>
>>> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
>>> ---
>>>   MAINTAINERS                     |   4 +
>>>   drivers/spi/Kconfig             |  31 ++++
>>>   drivers/spi/Makefile            |   3 +
>>>   drivers/spi/spi-loongson-core.c | 302 ++++++++++++++++++++++++++++++++
>>>   drivers/spi/spi-loongson-pci.c  |  89 ++++++++++
>>>   drivers/spi/spi-loongson-plat.c |  66 +++++++
>>>   drivers/spi/spi-loongson.h      |  41 +++++
>>>   7 files changed, 536 insertions(+)
>>>   create mode 100644 drivers/spi/spi-loongson-core.c
>>>   create mode 100644 drivers/spi/spi-loongson-pci.c
>>>   create mode 100644 drivers/spi/spi-loongson-plat.c
>>>   create mode 100644 drivers/spi/spi-loongson.h
>>
>> Your patches still have build warnings. Are these false postives or you
>> forgot to build it? Anyway, please respond to the report.
>>
>> Best regards,
>> Krzysztof
> thanks your reminder, I have already provided feedback about compile issue.

Then please test your patches before sending...

Best regards,
Krzysztof
Yinbo Zhu March 28, 2023, 3:25 a.m. UTC | #4 
在 2023/3/27 下午4:53, Krzysztof Kozlowski 写道:
> On 27/03/2023 10:42, zhuyinbo wrote:
>>
>>
>> 在 2023/3/24 下午7:31, Krzysztof Kozlowski 写道:
>>> On 24/03/2023 07:33, Yinbo Zhu wrote:
>>>> This bus driver supports the Loongson spi hardware controller in the
>>>> Loongson platforms and supports to use DTS and PCI framework to
>>>> register spi device resources.
>>>>
>>>> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
>>>> ---
>>>>    MAINTAINERS                     |   4 +
>>>>    drivers/spi/Kconfig             |  31 ++++
>>>>    drivers/spi/Makefile            |   3 +
>>>>    drivers/spi/spi-loongson-core.c | 302 ++++++++++++++++++++++++++++++++
>>>>    drivers/spi/spi-loongson-pci.c  |  89 ++++++++++
>>>>    drivers/spi/spi-loongson-plat.c |  66 +++++++
>>>>    drivers/spi/spi-loongson.h      |  41 +++++
>>>>    7 files changed, 536 insertions(+)
>>>>    create mode 100644 drivers/spi/spi-loongson-core.c
>>>>    create mode 100644 drivers/spi/spi-loongson-pci.c
>>>>    create mode 100644 drivers/spi/spi-loongson-plat.c
>>>>    create mode 100644 drivers/spi/spi-loongson.h
>>>
>>> Your patches still have build warnings. Are these false postives or you
>>> forgot to build it? Anyway, please respond to the report.
>>>
>>> Best regards,
>>> Krzysztof
>> thanks your reminder, I have already provided feedback about compile issue.
> 
> Then please test your patches before sending...
That's for sure, I tested it on LoongArch platform.
> 
> Best regards,
> Krzysztof
>