| Message ID | 20220402143636.15222-1-jbx6244@gmail.com |
|---|---|
| Headers | show |
| Series | Convert Rockchip clk | expand |
On 02/04/2022 16:36, Johan Jonker wrote: > Combined serie of previously converted Rockchip clk bindings. > > Changed V4: > combine dts patches > add more clocks > add clocks to example > add clocks requirement > I think I reviewed most of them and gave you tags, but I do not see any tags. Did you remove them because of some change? See also: https://elixir.bootlin.com/linux/v5.13/source/Documentation/process/submitting-patches.rst#L543 Best regards, Krzysztof
On 02/04/2022 16:36, Johan Jonker wrote: > The rockchip,rk3328-cru.txt file was converted to YAML. > A DT test of the rk3328 cru node gives notifications regarding > the compatible string. Bring it in line with the binding by > removing some unused fall back strings. I explained to you on your v1, syscon is not a fallback compatible. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > arch/arm64/boot/dts/rockchip/rk3328.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi > index 9c76c288b..8ceac0388 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi > @@ -756,7 +756,7 @@ > }; > > cru: clock-controller@ff440000 { > - compatible = "rockchip,rk3328-cru", "rockchip,cru", "syscon"; Please do not resend the same patch without changes and without finishing the discussion. This looks wrong (and external references you gave support this). What does this resend means? Discussion is over? Best regards, Krzysztof
On 02/04/2022 16:36, Johan Jonker wrote: > Combined serie of previously converted Rockchip clk bindings. > > Changed V4: > combine dts patches > add more clocks Why adding more clocks? The discussion whether to do it did not finish. You merged all your patches into one series, but this makes impossible to compare them with your previous submission: b4 diff ... Analyzing 20 messages in the thread ERROR: Could not auto-find previous revision Run "b4 am -T" manually, then "b4 diff -m mbx1 mbx2" Please provide links to previous versions on lore, so we can check what changed. Best regards, Krzysztof
Combined serie of previously converted Rockchip clk bindings. Changed V4: combine dts patches add more clocks add clocks to example add clocks requirement Johan Jonker (16): dt-bindings: clock: convert rockchip,px30-cru.txt to YAML dt-bindings: clock: convert rockchip,rk3036-cru.txt to YAML dt-bindings: clock: convert rockchip,rk3188-cru.txt to YAML dt-bindings: clock: convert rockchip,rk3228-cru.txt to YAML dt-bindings: clock: convert rockchip,rk3288-cru.txt to YAML dt-bindings: clock: convert rockchip,rk3308-cru.txt to YAML dt-bindings: clock: convert rockchip,rk3328-cru.txt to YAML dt-bindings: clock: convert rockchip,rk3368-cru.txt to YAML dt-bindings: clock: convert rockchip,rv1108-cru.txt to YAML ARM: dts: rockchip: add clocks property to Rockchip cru nodes arm64: dts: rockchip: add clocks property to Rockchip cru nodes arm64: dts: rockchip: rk3399: use generic node name for pmucru arm64: dts: rockchip: fix compatible string rk3328 cru node dt-bindings: clock: replace a maintainer for rockchip,rk3399-cru.yaml dt-bindings: clock: use generic node name for pmucru example in rockchip,rk3399-cru.yaml dt-bindings: clock: fix some conversion clock issues for rockchip,rk3399-cru.yaml .../bindings/clock/rockchip,px30-cru.txt | 70 ---------- .../bindings/clock/rockchip,px30-cru.yaml | 120 ++++++++++++++++++ .../bindings/clock/rockchip,rk3036-cru.txt | 56 -------- .../bindings/clock/rockchip,rk3036-cru.yaml | 80 ++++++++++++ .../bindings/clock/rockchip,rk3188-cru.txt | 61 --------- .../bindings/clock/rockchip,rk3188-cru.yaml | 86 +++++++++++++ .../bindings/clock/rockchip,rk3228-cru.txt | 58 --------- .../bindings/clock/rockchip,rk3228-cru.yaml | 82 ++++++++++++ .../bindings/clock/rockchip,rk3288-cru.txt | 67 ---------- .../bindings/clock/rockchip,rk3288-cru.yaml | 93 ++++++++++++++ .../bindings/clock/rockchip,rk3308-cru.txt | 60 --------- .../bindings/clock/rockchip,rk3308-cru.yaml | 86 +++++++++++++ .../bindings/clock/rockchip,rk3328-cru.txt | 58 --------- .../bindings/clock/rockchip,rk3328-cru.yaml | 82 ++++++++++++ .../bindings/clock/rockchip,rk3368-cru.txt | 61 --------- .../bindings/clock/rockchip,rk3368-cru.yaml | 86 +++++++++++++ .../bindings/clock/rockchip,rk3399-cru.yaml | 59 ++++----- .../bindings/clock/rockchip,rv1108-cru.txt | 59 --------- .../bindings/clock/rockchip,rv1108-cru.yaml | 83 ++++++++++++ arch/arm/boot/dts/rk3036.dtsi | 2 + arch/arm/boot/dts/rk3066a.dtsi | 3 +- arch/arm/boot/dts/rk3188.dtsi | 3 +- arch/arm/boot/dts/rk322x.dtsi | 2 + arch/arm/boot/dts/rk3288.dtsi | 2 + arch/arm/boot/dts/rv1108.dtsi | 2 + arch/arm64/boot/dts/rockchip/rk3308.dtsi | 5 +- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 4 +- arch/arm64/boot/dts/rockchip/rk3368.dtsi | 2 + arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 +- 29 files changed, 853 insertions(+), 585 deletions(-) delete mode 100644 Documentation/devicetree/bindings/clock/rockchip,px30-cru.txt create mode 100644 Documentation/devicetree/bindings/clock/rockchip,px30-cru.yaml delete mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3036-cru.txt create mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3036-cru.yaml delete mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3188-cru.txt create mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3188-cru.yaml delete mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3228-cru.txt create mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3228-cru.yaml delete mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3288-cru.txt create mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3288-cru.yaml delete mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3308-cru.txt create mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3308-cru.yaml delete mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3328-cru.txt create mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3328-cru.yaml delete mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3368-cru.txt create mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3368-cru.yaml delete mode 100644 Documentation/devicetree/bindings/clock/rockchip,rv1108-cru.txt create mode 100644 Documentation/devicetree/bindings/clock/rockchip,rv1108-cru.yaml