| Message ID | 20220216074927.3619425-1-o.rempel@pengutronix.de |
|---|---|
| Headers | show |
| Series | document dt-schema and fix node names for some USB Ethernet controllers | expand |
On 16/02/2022 08:49, Oleksij Rempel wrote: > The node name of Ethernet controller should be "ethernet" instead of > "usbether" as required by Ethernet controller devicetree schema: > Documentation/devicetree/bindings/net/ethernet-controller.yaml > > This patch can potentially affect boot loaders patching against full > node path instead of using device aliases. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > arch/arm/boot/dts/exynos4412-odroidu3.dts | 2 +- > arch/arm/boot/dts/exynos4412-odroidx.dts | 2 +- > arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 +- > arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts | 2 +- > arch/arm/boot/dts/exynos5422-odroidxu3.dts | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) > Hi Oleksij, Both Exynos patches look good, unfortunately I forgot about them a week ago when I was preparing late pull request and now it is too late for this cycle. I will pick them up after the merge window. Sorry, for this. Best regards, Krzysztof
On Tue, Mar 08, 2022 at 12:02:29PM +0100, Krzysztof Kozlowski wrote: > On 16/02/2022 08:49, Oleksij Rempel wrote: > > The node name of Ethernet controller should be "ethernet" instead of > > "usbether" as required by Ethernet controller devicetree schema: > > Documentation/devicetree/bindings/net/ethernet-controller.yaml > > > > This patch can potentially affect boot loaders patching against full > > node path instead of using device aliases. > > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > --- > > arch/arm/boot/dts/exynos4412-odroidu3.dts | 2 +- > > arch/arm/boot/dts/exynos4412-odroidx.dts | 2 +- > > arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 +- > > arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts | 2 +- > > arch/arm/boot/dts/exynos5422-odroidxu3.dts | 2 +- > > 5 files changed, 5 insertions(+), 5 deletions(-) > > > > Hi Oleksij, > > Both Exynos patches look good, unfortunately I forgot about them a week > ago when I was preparing late pull request and now it is too late for > this cycle. I will pick them up after the merge window. Sorry, for this. No problem. Thank you for the feedback :) Regards, Oleksij
On Wed, 16 Feb 2022 08:49:23 +0100, Oleksij Rempel wrote: > The node name of Ethernet controller should be "ethernet" instead of > "usbether" as required by Ethernet controller devicetree schema: > Documentation/devicetree/bindings/net/ethernet-controller.yaml > > This patch can potentially affect boot loaders patching against full > node path instead of using device aliases. > > [...] Applied, thanks! [5/9] ARM: dts: exynos: fix ethernet node name for different odroid boards commit: c1ed0f41032f54e47c03088f096f8b37cae40d8e Best regards,
On Wed, 16 Feb 2022 08:49:24 +0100, Oleksij Rempel wrote: > Fix compatible string for Ethernet USB device as required by USB device schema: > Documentation/devicetree/bindings/usb/usb-device.yaml > The textual representation of VID and PID shall be in lower case hexadecimal > with leading zeroes suppressed. > > Since there are no kernel driver matching against this compatibles, I > expect no regressions with this patch. At the same time, without this fix, we > are not be able to validate this device nodes with newly provided DT > schema. > > [...] Applied, thanks! [6/9] ARM: dts: exynos: fix compatible strings for Ethernet USB devices commit: 2e33a7b5fdb3930a9b1051bc792dbdc6a7490aae Best regards,
On Wed, 16 Feb 2022 08:49:22 +0100, Oleksij Rempel <o.rempel@pengutronix.de> wrote: > It should be "ethernet@x" instead of "usbether@x" as required by Ethernet > controller devicetree schema: > Documentation/devicetree/bindings/net/ethernet-controller.yaml > > This patch can potentially affect boot loaders patching against full > node path instead of using device aliases. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks! -- Florian
+ Frieder Schrempf who is the board owner. On Wed, Feb 16, 2022 at 08:49:27AM +0100, Oleksij Rempel wrote: > The node name of Ethernet controller should be "ethernet" instead of > "usbether" as required by Ethernet controller devicetree schema: > Documentation/devicetree/bindings/net/ethernet-controller.yaml > > This patch can potentially affect boot loaders patching against full > node path instead of using device aliases. Frieder, Are you okay with that? Shawn > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts > index d40caf14ac4a..23be1ec538ba 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts > @@ -182,7 +182,7 @@ usb1@1 { > #address-cells = <1>; > #size-cells = <0>; > > - usbnet: usbether@1 { > + usbnet: ethernet@1 { > compatible = "usb424,ec00"; > reg = <1>; > local-mac-address = [ 00 00 00 00 00 00 ]; > -- > 2.30.2 >
Am 06.04.22 um 03:13 schrieb Shawn Guo: > + Frieder Schrempf who is the board owner. > > On Wed, Feb 16, 2022 at 08:49:27AM +0100, Oleksij Rempel wrote: >> The node name of Ethernet controller should be "ethernet" instead of >> "usbether" as required by Ethernet controller devicetree schema: >> Documentation/devicetree/bindings/net/ethernet-controller.yaml >> >> This patch can potentially affect boot loaders patching against full >> node path instead of using device aliases. > > Frieder, > > Are you okay with that? Yes! > > Shawn > >> >> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> Acked-by: Frieder Schrempf <frieder.schrempf@kontron.de> >> --- >> arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts >> index d40caf14ac4a..23be1ec538ba 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts >> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts >> @@ -182,7 +182,7 @@ usb1@1 { >> #address-cells = <1>; >> #size-cells = <0>; >> >> - usbnet: usbether@1 { >> + usbnet: ethernet@1 { >> compatible = "usb424,ec00"; >> reg = <1>; >> local-mac-address = [ 00 00 00 00 00 00 ]; >> -- >> 2.30.2 >>
On Wed, Feb 16, 2022 at 08:49:27AM +0100, Oleksij Rempel wrote: > The node name of Ethernet controller should be "ethernet" instead of > "usbether" as required by Ethernet controller devicetree schema: > Documentation/devicetree/bindings/net/ethernet-controller.yaml > > This patch can potentially affect boot loaders patching against full > node path instead of using device aliases. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> Applied, thanks!
* Oleksij Rempel <o.rempel@pengutronix.de> [220216 09:49]: > The node name of Ethernet controller should be "ethernet" instead of > "usbether" as required by Ethernet controller devicetree schema: > Documentation/devicetree/bindings/net/ethernet-controller.yaml > > This patch can potentially affect boot loaders patching against full > node path instead of using device aliases. Picking up this patch into omap-for-v5.19/dt branch. Thanks, Tony
changes v5: - move compatible string changes to a separate patch - add note about possible regressions changes v4: - reword commit logs. - add note about compatible fix Oleksij Rempel (9): dt-bindings: net: add schema for ASIX USB Ethernet controllers dt-bindings: net: add schema for Microchip/SMSC LAN95xx USB Ethernet controllers dt-bindings: usb: ci-hdrc-usb2: fix node node for ethernet controller ARM: dts: bcm283x: fix ethernet node name ARM: dts: exynos: fix ethernet node name for different odroid boards ARM: dts: exynos: fix compatible strings for Ethernet USB devices ARM: dts: omap3/4/5: fix ethernet node name for different OMAP boards ARM: dts: tegra20/30: fix ethernet node name for different tegra boards arm64: dts: imx8mm-kontron: fix ethernet node name .../devicetree/bindings/net/asix,ax88178.yaml | 68 ++++++++++++++++ .../bindings/net/microchip,lan95xx.yaml | 80 +++++++++++++++++++ .../devicetree/bindings/usb/ci-hdrc-usb2.txt | 2 +- arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi | 2 +- arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi | 2 +- arch/arm/boot/dts/exynos4412-odroidu3.dts | 4 +- arch/arm/boot/dts/exynos4412-odroidx.dts | 8 +- arch/arm/boot/dts/exynos5410-odroidxu.dts | 4 +- .../boot/dts/exynos5422-odroidxu3-lite.dts | 6 +- arch/arm/boot/dts/exynos5422-odroidxu3.dts | 6 +- arch/arm/boot/dts/omap3-beagle-xm.dts | 2 +- arch/arm/boot/dts/omap4-panda-common.dtsi | 2 +- arch/arm/boot/dts/omap5-igep0050.dts | 2 +- arch/arm/boot/dts/omap5-uevm.dts | 2 +- arch/arm/boot/dts/tegra20-colibri.dtsi | 2 +- arch/arm/boot/dts/tegra30-colibri.dtsi | 2 +- arch/arm/boot/dts/tegra30-ouya.dts | 2 +- .../dts/freescale/imx8mm-kontron-n801x-s.dts | 2 +- 18 files changed, 173 insertions(+), 25 deletions(-) create mode 100644 Documentation/devicetree/bindings/net/asix,ax88178.yaml create mode 100644 Documentation/devicetree/bindings/net/microchip,lan95xx.yaml